From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0683D5D66F for ; Thu, 7 Nov 2024 17:20:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D7216B007B; Thu, 7 Nov 2024 12:20:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1609A6B0083; Thu, 7 Nov 2024 12:20:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 001036B0085; Thu, 7 Nov 2024 12:20:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D49D36B007B for ; Thu, 7 Nov 2024 12:20:48 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D8991209E3 for ; Thu, 7 Nov 2024 17:20:48 +0000 (UTC) X-FDA: 82759961970.03.59C4431 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 56BC514000C for ; Thu, 7 Nov 2024 17:20:19 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MAdYMJm1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730999962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XoHYpA8iXkJZMGQIiPzYVfYCnRL1iJl3BQzdgU5nsiA=; b=cY9z9fP8DnuwHUE72iR81mVvbpgtZ1MP/Ug2mvs5sr7fpUHTlHAz1EjMY+mSoT72WsOAVj WNkWLWsotgnsxH7Cj2pAGZbhiWJMOwPOUIb5OO1EaIMbvqSa0uL2Q+4bzoo3NcVyMVo2Zd c/xHgyzHybZ1T2nfB1YcVmwczDrkgk8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MAdYMJm1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730999962; a=rsa-sha256; cv=none; b=s+1QOfQqUKUIoaA4kMKkoqp3gDQMPPH9KjPHxV2Bf+/5r7FaaI1d95eYyOzS8qeCvbymP4 H/FcH3pnQ6oEE3TfB57DBn7MwJPgKC3KpjiJ6++hpd3lWlfi07ZxjJ7iO1E8wCH4SyLc+8 cxpsc2iFIHnuEnXf2gCAwPjfVBFaX74= Date: Thu, 7 Nov 2024 17:20:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731000044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XoHYpA8iXkJZMGQIiPzYVfYCnRL1iJl3BQzdgU5nsiA=; b=MAdYMJm1p1sccNMtQagg8R/IwIAMpGR1nt0c/ub84+i8L3H5Y47qRxb6kEbMWouK283wcT 18OOBnsphHRc8URbqAADkyeuMV2IGnOf4sEEds5rPal5ZYBQAa5WgVKL+bACfCDCoJIn1+ 5fDY2sjd/dGnbu99fjyT1djeNeeLVZE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Keren Sun Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() Message-ID: References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-5-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104222737.298130-5-kerensun@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 56BC514000C X-Stat-Signature: kbcx83g4w6n4hqjy4phrzeqjfd8d9eyr X-HE-Tag: 1731000019-981167 X-HE-Meta: U2FsdGVkX19MXZrSENqcK4rm/MbqYYiMxNU3cwTWeVP9/dVhVwShfytneY4+5Y7efhPxc0r+LgDv4DjR2T87SDROYskCyyiO+ldULRhxR0x1skVK9S6EU/X56KAcL8E3oGJrVQmNbIB353sEDEmd0Zu4E7N5nQCIZUEikVqMdQdfNlvMhD+iWWqn4VJOYN0xrlMnNoR82X30+di9T8hEsUEuAc0pJtVRGBnBTo6pj8DPpM9r0CH8JljW7AZpuMAozosr8135svs4LwNXKn4AvZuOi26l0cKoD6T69k3UfiQJRg+33IoFWCAnDvFbF/bXGu90Y/lffkZceS0q9++DEhoo6I/HCE32f+yrCEKSJDaS5juaRZeef8X/uAJ6oztI+unVXpJdtYyGSgOtlGVSKsSoKNxItgARzbpgmI6SMpuwUi9Z3c8Q7ddr3c8vlTID70X1ME4iCXa5U6v9Pp5wHDN+BAkMGFFly3pL8wM8Gucx9DfqSVgyH7pnFPnKzjnk9TD5hRtMDUHkUizTZuq5h/cjj1cIpFVXPfEZ2UG0eTdNhuUAv61RX3IdyP/eLfFvDS9nbORUUsVjaOVT4dmPPMSmjeVJAvSDkPH69OqiHSrbGN6oHcnxiYxVXN8D/pQ8nY5tCSRumWu0eb51TZfhJuHCUosu9IvpnAXc8/LN3vXy+/x5oHbKx2g8s7vv/v8DSXBqO0VoDTu9zik3bcNuKf3QIl/8Gc2jnyHxJtfuH9QqLqRFEaPuz+OImAh5e/GE3fs/WLnFI04z2RNXVfvnsiLhP9l9NWN9xpLUV4OnDTBBACdPH7CwT+BVhLGAGkL9kTqShRAkZ0ZmM4880CG0d3OPNsrbQ58ml/ZXQue3ya6px/zYb+/L/uqiJFSOYHtUGJqEVazTah9GKm956wW/AKduPYbsemL3+1YIFxoCEpJdkUIOp4SHfYMTAECceaEUHVPwfNPt4Hg7BwylZWF rb+ph6/T KPvwUVVnvMxo0lUdzP3npCJTbUu93fcw5VhI8d/r3TQeYRfKTXTwkXHQWM+qrWVpcI0EofOBMOztGQGMAWfk3/x6em5d5wOJpK4j8ZUjjhvElOfi2u3M9UVPvjfVSuZOIEFX6YiCX9m9NRw/h3E4q3HxM9y0TuDxMZ9e2b/6MZr6c4WbJNXKUlSG4tmxRTDXj9eizpsrte94rBDoHdbK0yHZBxo+aHBuqBPx7yJXP6l9ZYE3y2FDFUFedzxIf0jotREbJ1naS/dF8zw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Sun wrote: > simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in mmcg. ^^^^ ? Btw, did you test this code? Shakeel was poiting out that kstrtoul() might not work here, is it false? Thanks!