From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B420D3176A for ; Wed, 6 Nov 2024 01:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F39B6B0085; Tue, 5 Nov 2024 20:33:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A3456B0088; Tue, 5 Nov 2024 20:33:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 891FB6B0089; Tue, 5 Nov 2024 20:33:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A8996B0085 for ; Tue, 5 Nov 2024 20:33:06 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 174651218C6 for ; Wed, 6 Nov 2024 01:33:06 +0000 (UTC) X-FDA: 82753945344.27.F15FB1E Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf19.hostedemail.com (Postfix) with ESMTP id E400E1A0003 for ; Wed, 6 Nov 2024 01:32:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lchHlTP9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730856725; a=rsa-sha256; cv=none; b=vvsQQAyKR/yNSEQHgDJ+5PhH4z2tmB9vDsvO7Cv4e2m4OIJxcMm2Zm1XWSiOq7lbhDDtp0 73mClsa/4PMma+5Y1/jR4Tjij1zkY1PaazdMdsbe1q7Nn23UPPufr+b0uO44sY+uqajYqh LoGJTvPu4AxOslW9ZBd25zmdORwZ7+U= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lchHlTP9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730856725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UXENiiBPrtKGHgokfuDpSrDdZeSnPcm0OZeF9aDTtlk=; b=qJoUuhigbW5YgcMGDgPuvuEwycC6BdR0/o9YC4ZTmhS5CG8AYenGdfH0bWyE4jt7iijEMT Bm1oFy+Nqj9MF36pvWiaFHQOagQ5O7XkI4ojtg3v0gGQ9ZXjlYYNZo2cHsPZ8vQeU6FPQ9 E4ZDDVe2ipxtuVOvisTZaIZa7GVriik= Date: Wed, 6 Nov 2024 01:32:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730856781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UXENiiBPrtKGHgokfuDpSrDdZeSnPcm0OZeF9aDTtlk=; b=lchHlTP9AyPGZhl8bTdCCXBeyzBTnOI/tAYx3EnNg15TY7hLErpysQZpCplkXKcBkF+6on sPJsLLggrc9CwFqVxmeBNF6u4BoqVKIFHBf0Cs76ZpAKBzf0xOZKY+SJHeR1uRCCO+USJ2 DpbgbDS3MsR+6eyUik+e6vOmE5BeTOw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Sean Christopherson Cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Matthew Wilcox , Shakeel Butt Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: E400E1A0003 X-Rspamd-Server: rspam11 X-Stat-Signature: 6c3ceoqmw4hjz3gz4w47xdr4e69hipdq X-HE-Tag: 1730856741-140753 X-HE-Meta: U2FsdGVkX1+9JyJkuRos7oYRKnsNm+PirKP61ml+nkwNUMgJ2Di3OsCsBzyH4RiKN2MCP726TLHiDMoDR8yPuHzAbFEYXNZfEKvsbJlAC+8lIIIzcIBksqBYPZoBfAbDwSZK+bQNchPMlE03pdfRZCAZ2eWEDwebU4BVPWUXN05+WBL/Q8PjPMsja2tqXIMioKDsgvvpbhEtXUMqJtUjSwi9/8toOF3ey1GymEUu07Yp99WkprS5tPCbfqIa0wjZqcpj8djhGsjqTcMtTkIoROgXeLdKLPfhXLtxUoUPn1jFkCl+HrV4QK/sjpVVxXK88rV0Y91b1SAYlDSBh+gu3od4gXm7GQU6FEfJQJyyzphx5KT+Zu764fLFUWzoHQ8+6UYAhV9E12+fvvWKrsHvoHHwLg7gALEfojbIF6fPPXeh5Qd+OMyDV2xC9Ou3LziZi698Vf8nYpI51hWtquIFZk9QRC+g4gqh3ivbaxUaBMuti8D5llFHceYdQ0d0hL9LroRkUKgjI7BrFjDHPlf3UhT8y9hxxmRBYLofEA2mFh0d/5zrYTYl20+IzjyBII4QAv46+t2F4rJMZsWEfQIyKRNFAGo0vC9gMpsurzxVXZCaje07RpF3P91SjIXPUjfa3fLrIq0j7On3wkLTTG1jSru7ITNXmV+nP0JArXaplO/KE25tq/FTfPFW9r5yr4ybLI0lcTCEmHvMlJqUSI29WWsEaTqseZeGQpmGqUM2pLLoPd7WuiKyfn/cN5pRdaCB+ft2ZrXo4PHjlf94fcQU/gPnYo0v+OzZbvpy2dgcvuUHL7mOK+3Z++LrNi1ayCD5tlCgSzReNYzrjZfzgivR8hNR906Q3uW/jTRJ3trv7eYvPwTl9TTXeZTG3GVoskkuHrXpZBAjoN+LNjx2ZRm/SpBCjN/nDSoHANI3a5HfcCI+g3W+48hJNBZ/kdkIb4i8gHRnndc/2mndN9Njhsh 7+P3lAkD 2LtMFUlV6jeIDBairv1RIKOvzSg1fY9PxpVFgWQUzESSUe+5k8BitjLX2XgbvNcdda7oDETN+hCR1+m2wzxXr7ltcpUBnpoj4QxudXCfRJRX+uRcbNC4RQDBVf8rIl8VsGd/yHbgUog7n1KYxSBq6QCAIoj6Z9aQSvrGTOu+mAQR7QgMd2qPAhvb/oVDPGz0nibwM7O2iiZ5tF21O8lpM1B33DgBiOtZILboE3T0qzMD4AVW2kugTVT+Bufq7qwov/wP39GXhWs3Ogto= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 05, 2024 at 05:09:13PM -0800, Sean Christopherson wrote: > On Tue, Oct 22, 2024, Roman Gushchin wrote: > > On Mon, Oct 21, 2024 at 12:49:28PM -0700, Hugh Dickins wrote: > > > On Mon, 21 Oct 2024, Roman Gushchin wrote: > > > I don't think there's any need to change your text, but > > > let me remind us that any "Bad page" report stops that page from being > > > allocated again (because it's in an undefined, potentially dangerous > > > state): so does amount to a small memory leak even if otherwise harmless. > > > > It looks like I need to post v3 as soon as I get a publicly available > > syzkaller report, so I'll add this to the commit log. > > Today is your lucky day :-) I've been waiting for it for a long time :) Thanks for forwarding it my way! I'm still not sure what the conclusion of our discussion was. My understanding is that my fix is not that pretty, but there are no better immediate ideas, only long-term improvement projects. Does it matches everybody else's understanding? If so, I'll prepare a v3 with an updated link. Otherwise, please, let me know. Thanks!