From: Roman Gushchin <roman.gushchin@linux.dev>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/3] Introduce acctmem
Date: Wed, 6 Nov 2024 00:09:16 +0000 [thread overview]
Message-ID: <ZyqzrPpFiV7me5Ca@google.com> (raw)
In-Reply-To: <20241104210602.374975-1-willy@infradead.org>
On Mon, Nov 04, 2024 at 09:05:57PM +0000, Matthew Wilcox wrote:
> As a step towards shrinking struct page, we need to remove all references
> to page->memcg_data. The model I'm working towards is described at
> https://kernelnewbies.org/MatthewWilcox/Memdescs
>
> In working on this series, I'm dissatisfied with how much I've assumed
> that every page belongs to a folio. There will need to be more changes
> in order to split struct acctmem from struct folio in the future.
> The first two patches take some steps in that direction, but I'm not
> going to do any more than that in this series.
Is this series supposed to be merged in the current form or it's an rfc?
The code looks good to me and the approach makes sense, but the series
needs a bit more formal commit logs and series description.
Also, it would be great to have at least a short description of
the high-level design in place, without a link to an external site.
Thanks!
prev parent reply other threads:[~2024-11-06 0:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 21:05 Matthew Wilcox (Oracle)
2024-11-04 21:05 ` [PATCH 1/3] mm: Opencode split_page_memcg() in __split_huge_page() Matthew Wilcox (Oracle)
2024-11-05 17:30 ` David Hildenbrand
2024-11-04 21:05 ` [PATCH 2/3] mm: Simplify split_page_memcg() Matthew Wilcox (Oracle)
2024-11-05 17:34 ` David Hildenbrand
2024-11-08 15:06 ` Zi Yan
2024-11-04 21:06 ` [PATCH 3/3] mm: Introduce acctmem Matthew Wilcox (Oracle)
2024-11-06 0:09 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyqzrPpFiV7me5Ca@google.com \
--to=roman.gushchin@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox