From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F880D1CA13 for ; Tue, 5 Nov 2024 00:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E27246B0088; Mon, 4 Nov 2024 19:44:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD69A6B0089; Mon, 4 Nov 2024 19:44:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC60D6B008A; Mon, 4 Nov 2024 19:44:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AF0FB6B0088 for ; Mon, 4 Nov 2024 19:44:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 40640AC77F for ; Tue, 5 Nov 2024 00:44:44 +0000 (UTC) X-FDA: 82750195080.10.80E77D8 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf03.hostedemail.com (Postfix) with ESMTP id 501462000C for ; Tue, 5 Nov 2024 00:44:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qioACxOC; spf=pass (imf03.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730767299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AEmM3g8sIXghcPr8TOIqNkDpB8IugLU270wgo1SRLLo=; b=Q1W6zjXEfxA6avfprxzg0e50bXPvop5gw+ysI0jiZEm2q+5av9rHpB1y30TdTkjGCInhLl hLGb2LnUdMRocVDMZHnDjXfirA1r6BBDutILi+HVxsRzJv0SR+sVeAucfooIzAgfcjPJAD S7oWxWyH2xnn0YZXHMmf4KHQB0Pbknk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qioACxOC; spf=pass (imf03.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730767299; a=rsa-sha256; cv=none; b=urBXowQ+TGM11m06CCqqVvtcWvgMnCHZ7qFWqmCKQRFRWRkxKSkQ4Rr9Ee5D30X4zw2fAP 6UHSrHEqtige3Eg4LefefChJyFmmc/yfA7IkQBLiABl3PIghlis57yq9I/cbHPzrRfYDic 5dTRSZ/nphcZ46+KwcsCsP9nP/tBTY0= Date: Tue, 5 Nov 2024 00:44:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730767479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AEmM3g8sIXghcPr8TOIqNkDpB8IugLU270wgo1SRLLo=; b=qioACxOCGjN7SHmWYQ7+Cxp3M1WITO3BM64vMpdiVyUJNvZ2+SkP8tOC/rFW5bVcMLe2J0 7KUYane+fiGHuUsYmEwJRd4RS4M6maq1Lj44tZuGz5TrOFa6HZxY0y3XtcaEr9UndKPKSm nuM5sDlFcgQfVjFiJc62TV7WJTKif44= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Matthew Wilcox Cc: Keren Sun , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code Message-ID: References: <20241104222737.298130-1-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 501462000C X-Stat-Signature: sinrdn5uwmig58b71yxzoxunjp9eqbkx X-Rspam-User: X-HE-Tag: 1730767467-254289 X-HE-Meta: U2FsdGVkX1/kZwWoawANt1Uwm+roWSFqQcPhlErnG66NvhyIsMIWoNs0qqWB67kss+oQFutL3kWJUGUf2Ke0Qw6K30ALuSlrDDdB+v/SySt8+dpXZncxfDNo3bTl9AnLX2gh4+NvWrBXsdoEavu70Kqe/Ysjs28cQUukmKzgNbxnm7XrAJAOgG0i5LWA/mN9QMbyByFGZJgFpibuYh98bk/Hmel1vBvVkiZMqJgd4SmOEVoLBOGqAfALrZQCLcrbrUkpoyl70YwABdVNWnjaOUjwvdVQtcTMRhGRuJKey8kqow3VA6TMvJw44nuAqJSflsgjAAIRmalV8VZPmJo6zhKdaIdYYr+82/Qbf6W6/FGT5kABYDA5c9uS3Rlhwy5Sectqy3xbU26HhnGVgl/6Gm7RHEPcOjPLgD96bcD6DzJQQJenGTH7L2TV2zNcsJge2hegs5KmQQAP4c7Vyc4Zc78OI68k7xG1+dwruZBbD/ht5PCK6Xy+i8Ht7tY/Zyge5EdwptNWBKalWSzlLyxGRrBWtXyYocISSspo3DBbxVToc3s7TLLooUL5mBBERKuJbj1i8lJpu0BZXlPeQGGwtei/lbud7Mlzkw9ia1kp5Aq1f8j0NNXiHrQyUCrStyq0I0xrQtDcKiK1T1HZQQ9meLlrCH7sn3AKdybDfyXmQ5TMeph0YRxkbebw5TfbBRMyDWFpHH8iJ5XZUzBjGAZJikhuFnD8hgD5hSq2MckA3SbMN8sB6Wbiu+bwYngcfmfzS72ctRl542/HEuvNOig1TSGMOVWGRjtdpTXO7B6r+6P4Vt4KZbfqHKLoScLRaj72HhoFRwMfOi5eIVjnU52FBoq3Sc8LeM3u27GNP3tkfdKNUJgTiJGP+dPPax6wCBBHkuZzNXa0Kmlfd70AG7rvUG4j3Exko+6csLYgxx44S69SzNjODRX/B7zpCZA3RaNrC9z0AMGH8jRJmATwr61 26IGkJQt /i2oKzMJBo3JmJeTP9l4vCfoUkmFUOXlh24GkHhTYtTtDhPNiLi2LWUqnmJwP2FpZ65jlG5EEXYjcWIeuf/TKdlz/61P8GSZgewes0u8khNZzdWe6qY/iH89Blk84I1XwG//Vb8qiGFOozZXl+awyRA56H7jhk3gBoN72U2zixYY3xS6H0R4tD9zVCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 05, 2024 at 12:31:36AM +0000, Matthew Wilcox wrote: > On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote: > > The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the > > memcg1 code. > > Please do not do this. Fixing checkpatch messages in existing code > is counterproductive. Only run checkpatch on new code, and even then > take its suggestions with a grain of salt. I do agree in general, but not in this case. These are nice cleanups no matter what checkpatch.pl thinks of it :) Thanks!