From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF69DD1CA13 for ; Tue, 5 Nov 2024 00:31:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBBC76B0083; Mon, 4 Nov 2024 19:31:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6BE96B0088; Mon, 4 Nov 2024 19:31:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A926B008A; Mon, 4 Nov 2024 19:31:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B9D1D6B0083 for ; Mon, 4 Nov 2024 19:31:44 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44366AC7F1 for ; Tue, 5 Nov 2024 00:31:44 +0000 (UTC) X-FDA: 82750161858.08.9D6A1C8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id BF84580008 for ; Tue, 5 Nov 2024 00:30:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JjKPNDOJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730766536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UOyKBCJv4kPFZCEVQ/auD/OQoVNuo1XVVxJkxEPstRY=; b=aLSTzqbJcMPPp/ezDWPZZfBdXeJg3qgorR3PQLY7aofUXDRqQ5hcR5xmdQZQa+hLTevA/9 BWFS7E3KlCyr0oo+DlUKWwlR5xF6C/e748jws59uEByOGWjUCUrv6cqerJTJK+KZVK/4/n 7UVzDOac5WeTDg1Y9BbKtmpN9YKUPDI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JjKPNDOJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730766536; a=rsa-sha256; cv=none; b=QwPaFW2vwZZPckkV8XfgeRLCBCJvA1MbB32BOOaLq6M6qWirMBUZpv4fO6nszXIIAUKij1 eRdVZ9B4QV/8E3p/b9tdFGnBm0kI4SHb9pH0xkzHbSqkKh/Pk0JMpew0/tNmWwFe/eqxcs aQwtIQ5A886WJkqqmGp5f/PSyuEVN08= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UOyKBCJv4kPFZCEVQ/auD/OQoVNuo1XVVxJkxEPstRY=; b=JjKPNDOJAYX42o6fCiUC1s37st Ivz867pa2fqAYQt/xUGGtOsjcx6Y/MonTopIt9QKRgy5ObVdUPxCvYR4ZkHKHghbsp3ZutbZeKOET 6rk0hQkBbZt0Xo+cobz+O8mi3Z7zPJ+zBUmG9bjwyj/TQ4FqCv1oMZstPvboQ1X0POdnWXIfL8com mpLdOrp6fUu/oQXp9pAnMEZPh5S5JoOm4c1qddFzSkd2erQYYdJ+UepC89TCubus6GkyBVPpXAIrl 54kpvMbm4eUV6ZRzCqcygZiNQgDkABH36NFWPTkGPtzejpnekKlXhScxkwJpwlQUqIwuRUJ67GBu6 jpSMlksQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t87Tt-00000001jhZ-07St; Tue, 05 Nov 2024 00:31:37 +0000 Date: Tue, 5 Nov 2024 00:31:36 +0000 From: Matthew Wilcox To: Keren Sun Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mm: fix checkpatch.pl warnings in memcg v1 code Message-ID: References: <20241104222737.298130-1-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104222737.298130-1-kerensun@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BF84580008 X-Stat-Signature: 6juj9gkze69h3fquj7mwbmpgnbn97a1j X-Rspam-User: X-HE-Tag: 1730766640-155752 X-HE-Meta: U2FsdGVkX1+ig2z3p7wQdlwKU120/sg0eNLYB3nxXan8LWsofbSflRtJXMxQDVzbd1Q6+mVNzbs2weuU/9q+YapQAWNstnAP8cmp9MZ2zSP57y8ZrI4As8g9bOWc1r+swpVNHEJA9xN1/x05cjaMDRKhha++0E0za+RyhzB8u2XQPiyGjU5f0NQa+G21kD4YbuIJJFkb68Gw1gJ8EZB6nU4Myo4+yyGUeJ38D4DGSr+rgH+7rG++XIuK7+wkROpXO/bo7pccUo23LftjvI+mtsmVZlNLDcmzJgupLNb8EyyGjeMtr6NtkSS7H8M/5tcCcs3wZg/GoGtE0W6OBqNEIV9N4To5JyLMKMP4qgtgYaMJgpZqLh4e325vr/34muEfCauvZb/bxMa3+xVqH/4iQi35SdVAIuLz//vNotkXprm42NX4IzGfGSUQyoY7qO8+glh8iIfEvL3NCu6dAinmPozql9ms1pB353piskcDotjjLzl5ocaS7HyetegwwFIlZHW3UXohdCdzI9cmGoStZQ1k4NHNZIL6pbZc6ScHpYq5LKrnCwUQ95qALxxSfuIiQAYyneKyS94nLmLDvuKO+7WXO1Sfta9Nz/IqxPRxzOt1T32XUntqvvS7qpYc0ceq9mNZSbGFgfR29Lkitgf2+fqn0V6wmkdaFQ7XUWyZY8Tkcqpb0biYn2In2xryBuO3Boi0Qk1GaZo39KoRpKCgHo5R0mk5x6zYB/B0QY7Z6ZJ/3lhMe3E5WTAuR7CE68wmb4a4vLfwlVWmqlD9z1OeZS9ky2LiEX2QACTL+r5LORGDtmSUpbu+ZXv4qciYxhyD6G0sPqT45hmCHvHBtQjo1nWlQh6uBX5+SITeMSOhdMW4fHQTuo4KF4/U1bjPdYSWusHF04ehts2txDjAhB2sIqKx/8EQx20r2BD7A1ir2hz7mA7W/+n6qR3Fn3RjBAdnDqYKNH6zhb7ZGqKssZU u/udYE8u Zf2ERAVd7qbrTeJvzGBWN15iiYiqxMEm3DRQhXaLhY0JTLsw3aoBBnv8KJLAthQKP8+fRoLg6SpJxqeSIIqdHToMnSZrjc+84Xnek92aqL1fZ7XkAa9B5znJab5B+/DhLLztzQJFEdBpuF2qPtdRxTIHFdE9yK9CVLigAKso4NcpFBIN64V4XjdAVV69fdcty0Y9ZAwjvHcVZGAXYGzMpLEEtr84jd0syl9lJh8Ui5AVX3zaA0pbLImjMPgX0ifd2o2fg5ako5t0rZlk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote: > The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the > memcg1 code. Please do not do this. Fixing checkpatch messages in existing code is counterproductive. Only run checkpatch on new code, and even then take its suggestions with a grain of salt.