From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CF8D1BDD4 for ; Mon, 4 Nov 2024 18:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97CA86B009F; Mon, 4 Nov 2024 13:00:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 906776B00A0; Mon, 4 Nov 2024 13:00:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8226B00A1; Mon, 4 Nov 2024 13:00:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 578FF6B009F for ; Mon, 4 Nov 2024 13:00:48 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 10BD9120755 for ; Mon, 4 Nov 2024 18:00:48 +0000 (UTC) X-FDA: 82749176538.03.FC8983C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 601B740012 for ; Mon, 4 Nov 2024 18:00:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OCVcJhXU; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730743063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0KEUojX769cFGFmjiOJu9LFcNjv63c+8Mtn9KKoSfvQ=; b=3/OrNOUQAkcnml0sfC4fHvb7dc8XQ4DGDbKq36LsbVZPDERMOUV4A/7Pu8pOVPbV3tWnFr lAZAeo+fSQMHZIB+vozQUc92iqj9DgtIVYOp7alxQrJwObxU2509B1OZBeoTN2rMBJiC4S eipRVvKUOFVrrrEKkKqM8jgeSldmoOE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OCVcJhXU; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730743063; a=rsa-sha256; cv=none; b=pjumM1C34kXo7XIbdEw3dLhyQBar+e+d26MeOA4ZSYBsBk13ZHyuC+teaEJ+WndcG/QPQK 62ZOTyMa0+AWyeLIhqlO1mGxwf2xTY2zpXYKuxwFP7IQlk/UXbUsvhCzLi0UCYD6mRtzlr TsEd54D2KSxm1KkFy8pxjYjfKRMrBTo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0KEUojX769cFGFmjiOJu9LFcNjv63c+8Mtn9KKoSfvQ=; b=OCVcJhXUUUxPqDlx3lGFnhCT0L M5kJrwySKofGEFCLf8XdvyIbdHMy8vHdTTPP/gMM2LrzKhKR65E8zYdeYo5bCY+WjlV4Nf+66G/pD hQD/cYTgGWXIFgt550GAATKhBmAXmYpN1b2WIjj3E8BWbAnc2Vbx415/UTg2URtFKpRFag12RuaHx TcggLzHKnbQK5vjnfxxD5GTDmpA+rkcVoXhpsV542JItdJIL3deXSCmQNDEkRtAacNGhhn6WudeAJ Fq1x8N6IXpomeov0dISYwozNLAL9s60AvFqqwqT13JZQ3QLJ5rQHsOTIFuQTV/EyWRlcUWCcJKBCv nWFVznRQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t81NV-00000001Qps-0up4; Mon, 04 Nov 2024 18:00:37 +0000 Date: Mon, 4 Nov 2024 18:00:36 +0000 From: Matthew Wilcox To: Koichiro Den Cc: vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, kees@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create Message-ID: References: <20241104150837.2756047-1-koichiro.den@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104150837.2756047-1-koichiro.den@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 601B740012 X-Stat-Signature: 1imdjn5iazzfwbo4umi87t9bm834npb9 X-Rspam-User: X-HE-Tag: 1730743231-850580 X-HE-Meta: U2FsdGVkX1+b1QeacFTwM3nkH+lxXSDhPcbn1ftZBuPdOOmGrTpSgBScgDCiSqa4nDKD02eDCVEMPKB6T6H5UjTqn1hvIfRN1RaRcX0lQG7IKp2vxVu26j1WmLdSyE0Hs3db0nWrPtkoGNf0CQu3MtKRnIgkhJ30dyhz0WlNTJi14gnm8nBa4lS8L4i/kBuLcIQ8Zr+AU5KoPKz9dz4RvHN+efSSYnlhxhCe5XxA6CJLOXzZix/dtI8ASOw+pErEsZXqr84l5UBOjOeKZOa/2Vy/qtHV7BeRd70kXfh6n7ZCWCgXtFRtDGeqk3T3sbTsOoCUFPJ203qBfqPneeM4KqcKRrR2rJBKz658mxgclzaosXyo9Kz4yFv5kWwfqN2NeRyjsyf842862iXevPGKs5kEUWbdbFskf7Mg6kPeoeoVDagPoC+MbBP1z/mzHPOELjCZhR4mxtH+p8yzVavKL03U9SUGMjQfpgbZ3CNcwUqLexvup4JTCFTDruAdQDBnlMalRo6ST6pJx7dPFLmnAMW7C4hjAfZJQeoDWdowY9Lb7XtUrpvhshNe712/oKrbB6y9EAEgiz5XOd6WsnP6B7XrDH/DJpoaGsQD4mrq+r90YfEh1YFnveZsvBM8/JxXqSrGUhZZtk/vmw+CzF0rU1KYZ7v9BkrLx8w+buHuLwzcYZU/0HRlx6ZyPxxEwtGo4vVs2sZXRUk+EvXzf2SIznLvku4M+s+0CrfotiWHZafWpm6odW784hO0ccIvaXzorny4ccc7EqxNXT0balB02vrcG8HMTA4Vp9SPCvUMbT8fI6z6C1bbZnHuhvD3UtsANsIRvKhUhuyuvyfkxgUQYWhGgyZCPxit6MtNhaOL8Uj5Thl5LNy+WFJISwzKASTE4P1fklhJZBvjXPh26smRZpGvQFtjONhXyTKjIYI7BBok/n35kHJ54cFj6z/Ew6yQWXJHeBgV1dt4iSSL+6v tonL6z8e k64V+uUz2YlZ6r0NEt5FBw6o64HVlLY4Y9clwD5XjggsDSwnnZjmyXMTkjfd9pGClJHxpOdalCqL47j2LbJmGqXro479A0QbFg3S7T+vBcnJS2cm5gCZMgFBgXLTdnAZwiAQBTFVDb73MW5VLj3Tjddd2S1FPNVDhXJ+tsS03PXMv+Id86+hCJutguKe9YYia3t1fSoB//UMIbfc65UM31zVLS/x5Ha6oDfy1yuCg+zwpalNFnlQIiFadCZj4/FWTF0wLJC1yTsO2WxKfFCHrM+wyfT4tSimTYJCFmiiHbglN1XBh3Yta7ljmJ57QqrVxeFznNuIHpe6Bai/4souDH1C6fBq7fk1HHCFX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 05, 2024 at 12:08:37AM +0900, Koichiro Den wrote: > Commit b035f5a6d852 ("mm: slab: reduce the kmalloc() minimum alignment > if DMA bouncing possible") reduced ARCH_KMALLOC_MINALIGN to 8 on arm64. > However, with KASAN_HW_TAGS enabled, arch_slab_minalign() becomes 16. > This causes kmalloc_caches[*][8] to be aliased to kmalloc_caches[*][16], > resulting in kmem_buckets_create() attempting to create a kmem_cache for > size 16 twice. This duplication triggers warnings on boot: Wouldn't this be easier? +++ b/arch/arm64/include/asm/cache.h @@ -33,7 +33,11 @@ * the CPU. */ #define ARCH_DMA_MINALIGN (128) +#ifdef CONFIG_KASAN_HW_TAGS +#define ARCH_KMALLOC_MINALIGN (16) +#else #define ARCH_KMALLOC_MINALIGN (8) +#endif #ifndef __ASSEMBLY__