From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97678D1BDD2 for ; Mon, 4 Nov 2024 17:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 010546B0085; Mon, 4 Nov 2024 12:30:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F03446B008A; Mon, 4 Nov 2024 12:30:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCA006B008C; Mon, 4 Nov 2024 12:30:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C07FA6B0085 for ; Mon, 4 Nov 2024 12:30:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E9711A0671 for ; Mon, 4 Nov 2024 17:30:42 +0000 (UTC) X-FDA: 82749100686.07.52801B4 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf16.hostedemail.com (Postfix) with ESMTP id 87D6B180008 for ; Mon, 4 Nov 2024 17:30:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2ktwFT6X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730741382; a=rsa-sha256; cv=none; b=YTZHJ66JLzpez8vPg68UP1NXdNbwZniAvxvRRRlcq10APplPgu8fkGPIDG7er87KgL3hb8 QhcCZhV24/4KDVnsbDjQ/k0SoMByofXouUCQV2bWgKeixkhqergrCRy8nxxs0KqGAEhO9p f7B/4hZAXK1bgM2aNoxaGT4vwIoCGKo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2ktwFT6X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730741382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uko8HRkTeNblmOW9btgKs6zqXzdL6OFUo+xRmjIxbBI=; b=KHT1GyYJLVA2iGD8zXlBuIcJhHRHuTT5XWdOddZMQPkPnRpuYfz6ACrWIuUakaX3NLkWkK BNSHsq8cRXdyBz8wAY8cRzin6WnJPL5WMphnwxqFiOd/pPq/hc+SaY0mml7oKAP3V06tu1 VeZ24Vd4jfOgtURMkA0KeuZiuJtYCbU= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71e7086c231so3855456b3a.0 for ; Mon, 04 Nov 2024 09:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730741439; x=1731346239; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Uko8HRkTeNblmOW9btgKs6zqXzdL6OFUo+xRmjIxbBI=; b=2ktwFT6X3moQbCMiF4h868EtDcqDn4JnhnaHbjHlnpKfJDP1QKlpKnj6SuivEJql3L IoiVZ6KPZI82Zz8JfbjL3hbzRzTGXfXqbHHNIk5pMQ8W2uVs/Z3okGyAGNudY9zpwOzl mgG80u6upM92KexmCGdttsCETlmWbaP5F2iEnRAooPDc7MGL1Yrku8cKKJHc0RbtedRQ h7htGbgtVPBm6yDVBA3kqh4T/U1l2oCz4u++NINuItQFR4ug9VC3rnRYM9Ir1vbRd3q2 gW1Iyl4qtP0NRbjYabSgjIPriXxrC/QANSzBaXkYcC+LhL8gDWF+vDjcbqepwISShD/a TEXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730741439; x=1731346239; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uko8HRkTeNblmOW9btgKs6zqXzdL6OFUo+xRmjIxbBI=; b=lpH/DIpv1G7jBwpcO4dwL/XEFOb7iNWUgJD8cgITbM6ojbbL84mOXWQJ1+ooUs2/7R 6KG8SLjuxvbcf/v70hAX47ViAb19K7Eudbzs30EqEVRC4Bii/K7o5GD6GETxfniXpWDi XpxtYpafqa8I84Z3ul7b7O7MnnVdsJxAUXhzbkUKSv/f6i0dWWlKJYt6iO8VQ8MiDd3c 3tveoegFpSRwWJPL0OvWZVzIP+eD1PmLaVEW4wYMdvx/3W+MEvu1j8GGbC7LlVd52R+e unfWrQ21G5xshA/gjfr+XzcPljyQTkxFnPJLBM0y0Vajc8aZR3xZajm65U33ClCjaQ/3 +SFg== X-Forwarded-Encrypted: i=1; AJvYcCU2NckKeprGRyl9qth0b5aeY4velPRKjHcdT1z4qz3kwzXylHx5lQpQ7Urc/eay+2u5xz85jeJBCA==@kvack.org X-Gm-Message-State: AOJu0Yx7LShHmT3S9DjKcMeG1x4qYJ5IkA/HzF4E43Qukvm+r7Wa7vob 2h3ry9POTKfbWZDR6xqyLRnn4X4y2nd3JrMR5HoBRca5R5F1A5dkdD0UBZmZEw== X-Google-Smtp-Source: AGHT+IEGOOT/8Hf+1rAAAGQHfgG5uBjGTgnPTvESY0/W1ruAvP96UeZmKwzbhDibddrutT5kRXi5Lg== X-Received: by 2002:a05:6a20:b68a:b0:1d2:e8f6:818 with SMTP id adf61e73a8af0-1d9a83d0a95mr45329316637.17.1730741438695; Mon, 04 Nov 2024 09:30:38 -0800 (PST) Received: from google.com ([2a00:79e0:2e28:6:e673:81cf:d338:f1bc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc2c7ef1sm7698084b3a.103.2024.11.04.09.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 09:30:37 -0800 (PST) Date: Mon, 4 Nov 2024 10:30:29 -0700 From: Yu Zhao To: Shakeel Butt , Andrew Morton Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 5/6] memcg-v1: no need for memcg locking for MGLRU Message-ID: References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-6-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 87D6B180008 X-Rspamd-Server: rspam01 X-Stat-Signature: oosa5beae73owtack5t9jrgo8qqfs3pj X-HE-Tag: 1730741408-542491 X-HE-Meta: U2FsdGVkX1+4f16XyC4yuGN2ibuOiUBmS1HPx6NTUQb9MiB7mhTL0uIemb0cC8Z+BuM6BdMBRyU7jnRX8+fyyCbbL5r5BDWdxQixXztvBvSd2Ae7ejsSheiXnHNkGJHTIqhRxyT71pjV24nsonou4pXcjWo1S5tSv4mWlx2rvaDGJplqEaWUdfECZjDebF/xyOt48iQx3P0vxPrASy4E0n4YBAepbnvYdWA5HzSVZDYMdpcSqAX/+hw93Fy2QRBQXCNLSJ+W6utPUeLV78Vh9T/y90i6FRR01Ed9rEOH8RQW5l2qe7TQJWbXLZlqlFd5JE46DznQ6Fk3wPTWEHNQQvqJOjCfWND63nqBgBXGF1+/JO6ZrqTpSx4u8APRRYGqW3Na4HCcLPscavVexzW6j80YWHSNEpFYjy7RvTdcfty3eFEfbrgtORqROdxZmq/bmb1Phon04d0lKecwLSK1gkTQnoyoSVvyaN1Muvl4o8V352H7MtSvDltwh049rDx0bVtOtkAbq/Y2pR3Hc4UxzPXiS6GG4fof1KJkOJl45CfCS530cVXjtBwx5hVwmCbmh3ry9IEY6qE5Il0IsaOaza7sF9UpHf1NSlHpI1JQwlOm5eYKRya6n3GLwaueMuNYXO/Xq2wouQzM0R0gC9RSikfNArGK3zUNv3VIcaLuintC7bwzSA/p/IYbdXroN+pwJfi/k606kQMrTsY6SUOj84CjbZtiQz4P8IBsq7ypAG4FfE4x9wTeb3pMOd9knspNhzj8WuzQLRsqeXnz88G3zrTgfIBqHokv4rAStNgZjkouv0a1BuJx7MLXA9VsqTfwP1FaYWox4EBYy4TMB3pvi1/FXby01ZKofQOX5biF+h5nFTQ7DB99dS221WgQnU5KoZqPhY4+bpW2Nwtswp6rLAhiMeAmqjxYAJRZqZGrh1bUnHUH+SVjEtB2FvIfs7DVLXUJNV/lPnoCmawtEdv MN180LwX J/cwndjmMEAbXEsrrSFfLcyj2L6KWmlZbOskRraA9jsBVTd+UDegJIlGwz8/1C5Yx7/1hcaVrPRAnhXiCjI1nNhzWXc/3qGrlf5y65c1JobqufcAHPuTTpAmTE9ZSPF4aEPk04KPLqCU//51XpmJBAT7D2zUzQyMvC9IA/IP7MUsjRYJrX9nb0awdgDb6uE4nZYYQAs0bHpTfKipFexrLLwaLjliQtAJcq/C3VcJVQW3QUnzYcUvRyXtK9ubIsSHLgubM8N2BN/CXB6kdsgpCvyLXWqI3DkvtySQxaKrH6jC2h6T/K2omXpNV+PvzTNkMfwOZSdbZdcew09ydLx6sbv7HiuhQU2y2V+ROxmxhf+PNFg97A6ns7SUPCPnhy/Kb/d4nn6dxzOcH/L4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 26, 2024 at 09:26:04AM -0600, Yu Zhao wrote: > On Sat, Oct 26, 2024 at 12:34 AM Shakeel Butt wrote: > > > > On Thu, Oct 24, 2024 at 06:23:02PM GMT, Shakeel Butt wrote: > > > While updating the generation of the folios, MGLRU requires that the > > > folio's memcg association remains stable. With the charge migration > > > deprecated, there is no need for MGLRU to acquire locks to keep the > > > folio and memcg association stable. > > > > > > Signed-off-by: Shakeel Butt > > > > Andrew, can you please apply the following fix to this patch after your > > unused fixup? > > Thanks! syzbot caught the following: WARNING: CPU: 0 PID: 85 at mm/vmscan.c:3140 folio_update_gen+0x23d/0x250 mm/vmscan.c:3140 ... Andrew, can you please fix this in place? Thank you. diff --git a/mm/vmscan.c b/mm/vmscan.c index ddaaff67642e..9a610dbff384 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3138,7 +3138,6 @@ static int folio_update_gen(struct folio *folio, int gen) unsigned long new_flags, old_flags = READ_ONCE(folio->flags); VM_WARN_ON_ONCE(gen >= MAX_NR_GENS); - VM_WARN_ON_ONCE(!rcu_read_lock_held()); do { /* lru_gen_del_folio() has isolated this page? */