From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6195ED132C4 for ; Mon, 4 Nov 2024 13:39:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 702666B0089; Mon, 4 Nov 2024 08:39:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68BEC6B008A; Mon, 4 Nov 2024 08:39:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52CA76B008C; Mon, 4 Nov 2024 08:39:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 348226B0089 for ; Mon, 4 Nov 2024 08:39:39 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D0DB11A068E for ; Mon, 4 Nov 2024 13:39:38 +0000 (UTC) X-FDA: 82748519112.22.94EFFE6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 6AF54C000E for ; Mon, 4 Nov 2024 13:38:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cvMabDsX; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730727410; a=rsa-sha256; cv=none; b=PtO8DndYSD2LMBfSt0mJ+rcEmd1O9SjqoZ367TBIHBtHYxvow2zGxlk/qO/J0Txog68TGW M952mRFks7gIHO5+ci9nAzCR9Ukf94TF5XBZJH+78ZQTG4tU6xg/njqr/nv8JXd43hvTD9 Ig+nmY1yeNSooQzFQ50QXx4BT+g4htk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cvMabDsX; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730727410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BRdPBTlcOPtzPn5IHt2FPOSweajW0rcsz4AYTMWTfBs=; b=lQ1rWpzRJyF/zKPPviV+i/jG31WNAhMrOncl4ppxxPmx8pjjf/HLtFpqqKxayk1n3ocoy8 wNfUc5xIQZyIfA7IgwvK+aszIMOZSGrO0CyiJmJolv+2Ek0sTxo7THBCQjwJHRDwDknRKu 8ZJ/8ySm1I6d1zZi/ZrVnX+6QLdmCy8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BRdPBTlcOPtzPn5IHt2FPOSweajW0rcsz4AYTMWTfBs=; b=cvMabDsX91S0/7F4RXfzf74F2o ADSbtBhzvzT4cQlA4lKp0/gUr1gMuFI4WaDryu/1yJacQ6dDF8pzoUfcZXcE8HCPnNNg32PBVtjFB dIYjnquczJPZ8/KqclXXrJpJp5TnZbP0v1CpxHR72UXCVQ9TghU3hkLSvvlC6GDk4vmuFo6tlDzZH Gt4F6gYNq8Go1RjIjFpnlEVKO3Mddhk1aBqqL6FobZdAnFxerU94y7V5UHD7OcAgizKP3jOleJUBO I+iKwnm+N29s5HVr/cerUSB1TrNBafVtuAFVXNl5hbx98zA6fVHzY+mKQkLZ5UD/2/Pj4uERYWsuo N81LWvrw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t7xIo-00000001DQl-12uQ; Mon, 04 Nov 2024 13:39:30 +0000 Date: Mon, 4 Nov 2024 13:39:29 +0000 From: Matthew Wilcox To: Kassey Li quic Cc: "Vlastimil Babka (SUSE)" , akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event Message-ID: References: <20241031024222.505844-1-quic_yingangl@quicinc.com> <8418b91e-04bb-4b74-96dd-a9489fbf9ba6@kernel.org> <55f6332d-3b4c-4478-93f9-514a906e348d@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55f6332d-3b4c-4478-93f9-514a906e348d@quicinc.com> X-Stat-Signature: 7557nboo7dj8qcsbcp91tnnj1cfm6qgz X-Rspamd-Queue-Id: 6AF54C000E X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730727537-85343 X-HE-Meta: U2FsdGVkX1/nG+dsBNkDGj3TLyOKbrcIvAnV1SdZjVtvyvMCJi73PmL5CFfSLgDcDyVkYBES4/yuhv7aOp+8Vt4Lsu4JIwJMCZtXP+MKD/6mMmZWsD1QtCess/sOkr64utOukEFR6xi04FNQwpNr48eZgDpGXXe+4ZgEIGcw3QTH70jsPxoi6yFzE7QYKy+W4YaLwxWavhnP2/DV+TV4gBIvcviax3Pm5dmUIysgTliUzF8w+R8GYT4K9inKu4rPk2H2uBAyUtrO9/4j1yq1pfTJNtMpKMLAyjsgQMmbtzynRn44K520a9XVVlW6OtypzYa1/0jjaOFRnAPWju3tnZJNzpbOMy+iPMPjWdau80x7jKfNHHzSDd9vlwC2bCmI1ZaZyLTLDWOobawJ3PRYRcuk6t9WkUjuoIqEaMcS5AklO+cQjpcjYGjCVcCMAdl0f2rUO1Ij8BoOYXJes8ruuvlZjdAuUf9xaPZwP7GOR5epSJ+rH1kvKz5Mve+851hHKMXG1wF5Dnf1KfJXj0YeL9K5L9ip6HZMIzdilFBlJwphV9VN2y1/chLaFmK9Wc/jC94lPXtoiAoiG3TN78XJ3KM5ZvT7roz4+km5eXvkiEiXl+HCSeNMxekMnypY1tI8LXTS5h+lKlTzWHrafLdT7BOiSdmfTPBWyxCBh2Yg6HMFppMpHw6Ky9vw5zmkL3yf/fjLSoF26cCyoHrclKIF4YaWoQS2nMEJShUzPeDvP8J88UPuQG/KH1K4NqdNiKywlRAwbCJzoDKjOeGjoSsCp+zbJzbWfnW9IE8TDNl0KnV8iT5Dp0j0pPzuySFeWClbE+FfyCNXrJ07T6SLwdpOJbzt90hcKusz8aWDGgy4N4L+VYs6r5MTWl6zMVlYpIT3NsfxzCiXIIH73yqB/Yt6hkQZyKnROeIzSCoXUyldUaLAv1RZmSV2+86Z+37ppvsSJPfwLrMBLEts9Pyn/jf rqyVH/cQ 333prk2xL4aa87rLps8m3HRvajM2FeXQNQrE+RBxFswa+gky+UD2xydgKZiHIwCG+FHGZl9/NHRAbrMYEvkrPBXMUnddrm8U47xEQhjBMNxJoRT0pB6xXXMd4fSx3B09TPhKRbA4vICl3jKVAsjp5jWH34/JQfxQOssNDKnbpFgOxIKFFdt24MG4J/J+HKAHw+N6PONNaVDC5IcxQ8s9F3Vn9cPIsvi3MwovoUj9PaUbhIcq/K5nXuDLwq6r168U8MKKMjyl6wBeHohjKCF1GeSOTfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000119, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 03:35:37PM +0800, Kassey Li quic wrote: > > > In many kernel code we are talking with page other than pfn, > > > here we added page algin with pfn. > > How exactly would this help you, what are you doing with the trace? > > we met some problem where filesystem held the page. > > we can show the page pointer other than pfn in filesystem code. Don't do that. Change the filesystem code to show the pfn, and send *that* patch instead.