From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F69D132C0 for ; Mon, 4 Nov 2024 13:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F15626B0089; Mon, 4 Nov 2024 08:27:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC5CA6B008A; Mon, 4 Nov 2024 08:27:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8D786B008C; Mon, 4 Nov 2024 08:27:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA4D06B0089 for ; Mon, 4 Nov 2024 08:27:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3FFE5A1C48 for ; Mon, 4 Nov 2024 13:27:10 +0000 (UTC) X-FDA: 82748487864.15.CF5902F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 84A4A40023 for ; Mon, 4 Nov 2024 13:26:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m7evfYLj; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730726664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ltCOULzMZZB81VID2mdcLwDfPQD/mrw/085OYyFIBy0=; b=Tk/PrYQ/LlSyUpWcEC+AkpJALh/nHtysrvVakw1bkhb2tMwLRok8Ql83N1MmD4/+CmS5sC 1uurCnZRBugyDM5mel4LNni8ot74YW4BJnnNOj5/qz8cZO3zNArvyAg95IQVb5LjydTpSy rfofSx5efL+2H0ZGGEi9OImZhsujFRk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m7evfYLj; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730726664; a=rsa-sha256; cv=none; b=AA3CJwv1ICJRja8X2M8scm0YDz/quyC+nhFsLbKaTgY6IyMHXR8N99MpAhheesMbcrksLh 5YaKK6nHULWze1CP0nXYOk2f2gwJeqKEihqOGvZZPbXXvfiKlWJOcHcc8RUxndzJpDeO9f PO1CD5TEDj0v3N3b2EXmfDvxlZA9OeM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ltCOULzMZZB81VID2mdcLwDfPQD/mrw/085OYyFIBy0=; b=m7evfYLjs32CAoqpIryBvDXIRT bJMtUKgaCKA6gUWyOb95zLvt3RBbuJu3SxvgskmWxq4eQm3cE8me0OZygXLUHp7H1cis1ssKnwIAW bbAOnHEPb2o1vd3qCKsTSW1s6AiIMjAiGF5QXxWBdUJKC67hjaP75wYJqjLVPhyLoY0drzvHFpPJF hvFADlNE5eWaW+wfd+nwu4UhlDGzGox4J9OjbqU+4dCudXrjkhviY3NG43Lg9xT+pb0Lxii+KEgBz EagfoH9tlVbd/Hnj5jZCiM9d8iVbNSpbVOKQWzRaa5oRVTGWPfx+ooxKnL8R6/FKnbGyptthsZ078 leNLpI0A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t7x6j-00000001Cma-2rR4; Mon, 04 Nov 2024 13:27:01 +0000 Date: Mon, 4 Nov 2024 13:27:01 +0000 From: Matthew Wilcox To: Ke Sun Cc: Andrew Morton , "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] maple_tree: use KMEM_CACHE to create maple_node caches Message-ID: References: <20241104061617.450907-1-sunke@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104061617.450907-1-sunke@kylinos.cn> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 84A4A40023 X-Stat-Signature: rfcfngtga7cdz6s58m54xi5dxj4z6p4s X-Rspam-User: X-HE-Tag: 1730726802-712294 X-HE-Meta: U2FsdGVkX1/WUAAg1QVzctTtptfXSudAsF/vVzBrJsfXH3umdKpIdCfpBDe24DYYPSet/Zx6pNOqVi0Fj3bJlOTIIqGgsFANc7sPWMV1jkshaJIupvfnuz1u7TOn9NXm6QWokyTIRiz9U8smbGs6p/YKQijclQg7EocbB6lShbIlqqXuO3ZoOmOVYQfYGxhGit8BCuBdAUmo43XrnoPu09WrEM35qu3BE/y6IGIc1QrkPz/q4aHnkNuFKYTq6X93zsVhGnz4S8S5KT62CLBjn/r8g+Ykf+W30UF4f4C66eM9MNnrkBABfsbaW+g/QSn9xCU+Dl/3jICP0g3aCDx5DrqJe/Rb1BFxX/xC2s2nZ45cvOAoIBAGFtWcFuispKcqhiLV9Ahm787/zEiB5hwKb//YKIfAq4eelmJk3cIPH3NIu4vRWRMZSzuV4nWYQJKa+2b38K0QmOL9YeB4U/dKG03F6tNoXcSTF0LVM28Dy/IswMUcogAuRR9yUgRq7miZGOCUkII8tPHWdZWysyqdmrvegMO5/ey5aYmOmVuOekCssyY1H4Sl85xkXn+bqCN2FjdRdprmMiGvySdPB9mFGR5sOgilGwc1rQzXduuhMtlHtE083+rX/GyHV200Wvt8sDr49IuUbqeed/ELRHG6LYN7vQan2rWzsdNtjw3AQ1aDElgMC5dwKdcH7KdOccj6clZPNt9jjKFGsy0edZF+u3Lvku9m5k2/b0izA89QExLrUcusNvARiLuB0syTtBvGwMOmK+xMUZwbzF2GgogPaVqvTj0uYGZEXSAMSDRB2uxCjPyirDmFJzCAiKj1detbWa6h3TXUcnAvGXFX8vGWzVsUVhkT75vBUxATVBRDoS78N5EyXXuU456mYZ/4+twCwJLOcFXx4SXbugR9rHZyJPzJ84Xy6rEbJsHfxe8poP2p1qHntWMVCoNM/1ugRkq56B75SWgA+CIvt36dVMv QhGEipeH OpH4cMJ+DDGfW8pP1OcuGlTbfqfBILVT5X071dmDc/322MzXcznpkBQkIqhQnFL3RmBAFziAISf3mzRbzbqGF8ONE5NFM3Q5XNflRa6tI/CctYHyQC3kKGBljh8pnZQFCajer57Jw4oBsK9poe1PWkI1t0LBSkP3LU8CDXAkOaS2OPhSl3XBuSq1TzQcvA54I4Z0h9u/aB5pvqwx1HkrPWGPKExFgbQx/M3xWSDgRwyWLjqDKIYa/LtGOJ2DCfFpvyrDZLclZW792hflDXyjjjnJ45Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 02:16:17PM +0800, Ke Sun wrote: > Use the KMEM_CACHE() macro instead of kmem_cache_create() to simplify > the creation of SLAB caches. Did you even test this? It is REQUIRED that maple_node be aligned to its size (eg 256 bytes) as the bottom bits of pointers to nodes are used for other purposes. KMEM_CACHE() does not give us this guarantee. NACK.