From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62153E677F5 for ; Sat, 2 Nov 2024 11:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 733C96B0089; Sat, 2 Nov 2024 07:30:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E4256B008C; Sat, 2 Nov 2024 07:30:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2506B0092; Sat, 2 Nov 2024 07:30:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3FB206B0089 for ; Sat, 2 Nov 2024 07:30:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 98D478158E for ; Sat, 2 Nov 2024 11:29:59 +0000 (UTC) X-FDA: 82740933702.17.51E1695 Received: from kawka3.in.waw.pl (kawka3.in.waw.pl [68.183.222.220]) by imf03.hostedemail.com (Postfix) with ESMTP id 303B920016 for ; Sat, 2 Nov 2024 11:29:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of zbyszek@in.waw.pl designates 68.183.222.220 as permitted sender) smtp.mailfrom=zbyszek@in.waw.pl ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730546941; a=rsa-sha256; cv=none; b=vMBS+PvOlbhqzwW3MiUneQaZbn8G6a57BqM2MqYYGPEmzUcXI5N4Es6qrXKVvmNRCkU6Se HByZfwcCf/IOGpS22dAfm2yvADxo15OGcyGaIpVf9gZNzXy6gxkHer/PVEyhoL+1z1tPRC P3PTyWxDyM+8tLkaRY0jg5izV115k90= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of zbyszek@in.waw.pl designates 68.183.222.220 as permitted sender) smtp.mailfrom=zbyszek@in.waw.pl ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730546941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hqMBY7Ft7p8i1cemAnQv6pAKXfEjBe7xQtJGMqTiO9M=; b=3frJ0sS7VYyZ7Ojny8DcFcZdyfYaAdQDQIeTgVkaMW4YQAhEvK82qLGQCRR8cmvOoi17+C c5WhbtE8kt/FQ1ickGwOJhkecl4Hx7OVYaulQeYHW/rPRzi6ei4Wsw6ww5LvH1Yhb0l1TN skmlsW3amAJRXKrO3aUoImulT/sifXg= Received: by kawka3.in.waw.pl (Postfix, from userid 1000) id B80CB5826E1; Sat, 2 Nov 2024 11:29:55 +0000 (UTC) Date: Sat, 2 Nov 2024 11:29:55 +0000 From: Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= To: Tycho Andersen Cc: Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Shuah Khan , Kees Cook , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case Message-ID: References: <20241030203732.248767-1-tycho@tycho.pizza> <173041263505.1781237.9706368369948860422.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173041263505.1781237.9706368369948860422.b4-ty@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: 303B920016 X-Rspamd-Server: rspam11 X-Stat-Signature: 7o1toq9eiicd4gio4jz5x4oajn9q5ws9 X-HE-Tag: 1730546983-397886 X-HE-Meta: U2FsdGVkX18sfZ79El81hlS50feqGRwuFpXtwbFg3MNU7L3N75YTc613SHfXKKothAbp5TRUaUtRecMFWx6EZZ2yjYuVTPMdqV45O7MZiavbVOnxZj5YmvrNwavE/H4QIDRzV/1t/AjQIo8WwkFaYUog8ZPf3OZo4ULKrQzeWiJ7LYo4teDDFdT4eX/GUmcUmIlraJ0vkBQB/+T0CqpEwrbAtOYCCS04bAJvt9TS5rItNyRZPK3rtiq/KJ+bxjfVgPvi7C4LAyGCRhcThAofj0jLO5j5Gwi30ruKwSOhVrYXYtSyxhLlByKvxNFaksW7H6OrGVNe3IBYG808NAjELaA2TEZ/QeiicuIaeFrRurkcHz8exa7ynD7O+y4waA47LwurKOcDcZt6A8nJNygnhsDFkHfXkV+6lNkqWRN9Vl/Cf1WMfgteAoIoiSplf0odpU9BT1QCO0XT9XUKHhuGv4jl22p3eHtInaK1JglVYXhHxMhFDPh3WQZJY5vprvHZJ9iUrhthJoqn7Z52rYn/z/xGLWv4bj59FEnIXradlU0Q9eV/929lNvQQrsHvVhz50rea9DC0HsL2P4upOqhIvlgoqERgzfaizVexBpcpCLL+pJ+9M7dDLMJ68ZS9kZAk5EuFLTPS2fV/WXCW0ht9ViFT+FrZ+p7jzM/P4W3f+y6OswMAVNe64onHEJu725hm3SKrKqQFCipE9FCiHzh7IHfktxBti32Ldo+t/bJq91xLY+efUJOGjE+QTZiFwUyRB76ZxnsxRwk6LTVJuu63KJvMwYpdi4eoYauVBpO7eVp8r+1LoiCUz4wqgzLGL1x+X5JCAiGDIK9Ch77AIV/5d9KgDogtjw/3pL6TOp4Zx2FdX0Z3MJ9EkOQai/nmGcH2CO7xOnGGFCRCVfFfb3v2ltIE42IXGXUvSYR/Z8J7JVbCZr3OgmMWPz3chLr3JfU5ZFRb1WbWvDleD70TlFt zaN1nC9u Sm3nTIx2l4GXhe+auNV/AhOmURL7+M+2mArw2C0CCKX/VDUPu26q3OR3uhQcwgRvpoFwXN7bjtKEz2QiN5zdM4fs1pXwYblxS20F/rn2DsL/tdPpkpDawdq83dyzKv/bE48NmqeQsKhvXUW7nol6Ba6KXkMlL2bC0T/AQZesPbx4OtV8JmKdHC9hRCmHrjOZ4PLhWwmhZnSRClcVsfDIdBYO3/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 03:10:37PM -0700, Kees Cook wrote: > On Wed, 30 Oct 2024 14:37:31 -0600, Tycho Andersen wrote: > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > switching to execveat() for service execution, but can't, because the > > contents of /proc/pid/comm are the file descriptor which was used, > > instead of the path to the binary. This makes the output of tools like > > top and ps useless, especially in a world where most fds are opened > > CLOEXEC so the number is truly meaningless. > > > > [...] > > Applied to for-next/execve, thanks! > > [1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case > https://git.kernel.org/kees/c/7bdc6fc85c9a > [2/2] selftests/exec: add a test for execveat()'s comm > https://git.kernel.org/kees/c/bd104872311a I tested this with systemd compiled with -Dfexece=true and it all seems to work fine. Thanks! Zbyszek