From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B6FE6B278 for ; Fri, 1 Nov 2024 13:30:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C21206B0093; Fri, 1 Nov 2024 09:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1636B0095; Fri, 1 Nov 2024 09:30:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98566B0099; Fri, 1 Nov 2024 09:30:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 856E76B0093 for ; Fri, 1 Nov 2024 09:30:44 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E90071202D0 for ; Fri, 1 Nov 2024 13:30:43 +0000 (UTC) X-FDA: 82737610326.26.48956D1 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf06.hostedemail.com (Postfix) with ESMTP id D0F1218001A for ; Fri, 1 Nov 2024 13:30:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=bLqR8qUe; dmarc=none; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730467760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O+zxaTrh7HADeaQip64uvXVpGpMgvPdgqlePcZ62Y0I=; b=Rr1n09d/hDw44gtLWHIld8uSgmHgCA8d4ipPxHZeV0r7Hul+11ZUuWV2W64H3IoUdDb6YH y5SdLoiy2WX02/2uAN8c7dFHloNa6xVL8HDdcT+FZC5DklWXBbCh47BGG1Tt+vSZXHA96I 7ErLiAlFGrdKnR/DvMJTkFq2VPpfkOI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=bLqR8qUe; dmarc=none; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730467760; a=rsa-sha256; cv=none; b=muxc8hjmcsnHGCZspzMYUliDywBoHSj+ExBCxoQhT8N2pFI8Uiy1S6x0+bB+EDKl3yw5Bn bmE5oKbtqV+W9/WpSKaj3qWNc/kdTJ3Ohwgc3lucbtP91JJz0D44z2Xn2v1A+Wy3ykczi0 x8632UFrPv/KXGWoCHnAZTez9IdrxIA= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-46090640f0cso16065341cf.0 for ; Fri, 01 Nov 2024 06:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730467841; x=1731072641; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O+zxaTrh7HADeaQip64uvXVpGpMgvPdgqlePcZ62Y0I=; b=bLqR8qUegUPplZDJx+PJNJX7ovarkEf8mzTSBt4H5+nJ6WVSPaKONxdfldkmO0XF+F tdUq2ChJscchU9uKHnluEI7WNmlbGDs8euZ8SD5jIBTtJUt8qNGxAa96rejY5rVdZSZ6 INtJAa71h2lo+53FVcGnoulVqD4o5FwmBtiCLFicJpao/g9hlQFrGKoWYdFi522Jy8y0 3iqVamiz/6zjNXEhXKeDsykmFeeuQrpQVwS/7TaxSXsHXQrHiD1UPCYf+dAbi8rwJHqE cCyDMSZRzCoe3dQTyezkViRifrhqIbMC+LIhHrWKj8HQXagYvn/5wPaaX/iouJCTm0ii iL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730467841; x=1731072641; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O+zxaTrh7HADeaQip64uvXVpGpMgvPdgqlePcZ62Y0I=; b=t0odqRJMlrEo2XZow3L/mEArOYFnOkPHwMCj+LysO4CqEitOCNh6PBM4OmCEQINaw3 PFfkKuYdBFO/ES6aIagrwCYg2Ty/5o6Dy4JlwVuPI7qOam1GiykQKfLLg0z7ZS8Dg4cR FlXNK2bqFqzS1DUwc048zLw6xXcfBQQzNqHGnQcrj6Yur6aKPGWQ4PLHRZY0w4aaAjt1 tdavOWEHd9PPcg5o+cXbPIrEc+ASKwpCHTdmDy6rMPDTDbpAYclxnk2MCvMsv3NqIusn TttQjOs/SXmvJUat5zwBBoUbabWP+PRpglpguDX1Nc+pAG4ibQqDGcUXQSvuNzc8L75n QhEw== X-Forwarded-Encrypted: i=1; AJvYcCXYe4Xbb6F7+s+ezigfz5oITk0M+7JMhxgpq5YNXxSh8awTNreSwDfF53QiGlafwJ8glfcQgfYVGQ==@kvack.org X-Gm-Message-State: AOJu0Yy3PttdWXqLMho6zh4yGZ52oZZZ8ngNGsOKK7j+2kKMhBl+zlhi HKvp57Upn0G8jXGo5ysSAQdQCoPxHqUP5PDuGZh1dUGcP7V5KB1DCcRANKI9QLU= X-Google-Smtp-Source: AGHT+IE+EOVGC2mCMhtnwt/3GoIcBU1ivZDsYVQH624sCY48sw9XZqQuML9P4o193+v7BNLzgzWiYg== X-Received: by 2002:a05:622a:1456:b0:460:a825:636c with SMTP id d75a77b69052e-462b86804b2mr40043091cf.14.1730467840881; Fri, 01 Nov 2024 06:30:40 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com ([50.193.156.113]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-462ad0cac90sm18553271cf.53.2024.11.01.06.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 06:30:40 -0700 (PDT) Date: Fri, 1 Nov 2024 09:30:37 -0400 From: Gregory Price To: Hugh Dickins Cc: Shivank Garg , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: use vma_policy() to get vm_policy Message-ID: References: <20241101071350.402878-1-shivankg@amd.com> <8169912f-82dc-e210-862c-f6eb092db78d@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8169912f-82dc-e210-862c-f6eb092db78d@google.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D0F1218001A X-Stat-Signature: 8p75mis5etafuonh9g5t3qp6dgyhnn65 X-HE-Tag: 1730467821-227642 X-HE-Meta: U2FsdGVkX18/8WAamLVcmfncZbEwPTXZn4VwyVeWqT3dQkmaM6hkb2BAUtnhD5YQXPeGYlymGVeXp3a8m4tUHuSVvJHpYeOIac9GlmPCip86KkIyYGXo0V83ILd59MdNRNgmEBRPuKKKJtndC4OSk/us8aHkr8Y5R7d8laYGmyurRhsU8xifhkLWGfcHIJicdt+A1WJ09u7PJjdTaiC0d5u4zWV3gpXChBjfDz1kVcQfa0KH0h9uhDXY1yIWvTsXd+QGUgTyCA7shSY/4qGU/ZQSJ6fC1uqu3NiZoGSZAhhmTFqB/rFN4+YFWNVj1+tN0VVYwao2HU4EoIGE7vCForOjxd7HU0Ff9mfDvcVarsM1+D/+qB8rUbYndwehBuHlKv30B/uv0n8xd4SUa7GxJC5w3W8n4kvQMM35U1iQvwQ8y18UvJpAPl1FCBfA8yuiEiDEAI5LqbMACkk4DC2zQHEBEBlkW36l1m6QnuQKHM1A98r/kEhdYOQWSP0w0caszFTBQcneDlCAYncgGZwP36u54br0WG2+gWMwA8fmsqgXFub+brUcbkIQkAVKH9ZgfcWGcNug1NyK4a4INXD6JzDf3wMU9m7+I0qmKqNHEpo++w1RZ8ALl85/syy5X+DUwkDMzHL1WLd+Xb52LSSMLNTdNzuh8DwpsOQnaO/K/kClZFdSi8DJ6x0/uZbzn2bnwe1yRLvBfcuvin+PdOOLrJRNrhMQlXT5PhrU048dhpVAJCt+stMsnLEtx/7iGBMEA11EdGsBsTpFpse7eEsWxXjPOsPJwIuiN9/hNC0un2zpeY9XEDsDIrgQ19H9E5Y/KoRjQ/qpLcvnrrMTlPnBLmPIgFWWGSZ3o4Yniqoo9NWpGcJckN/rIHySsI3n3DO/64p+hQjkm5xqKWWd97bT5qvuGCsaV2Dvg7qlb+wQmy/U2rwej/MI7btPtz2yLCHX3RGqPiEgd7DIwT8lPMC LY5ftf/J D6moqAcFp/XhIcd37Y7Q3PNsM8IXhLJwep6bVxmAlwE8udRdyKgi8sAKLg94Ibb1RFXWjpTACUvGxnn5Y3mjK3veCUVUHIRYcyrwlukqQecgrG+CK2DDmM9pnbEFNnAqlBFcf97Ow97eawE9yHT3M92BmGregtEBHO8a9h6lxvX0ZCD8Q+u2Pb6+vALSg6WpuaL4RdM5GGUK0DZgmhX+lEUbTns3WGUXZ8NfFpk1RCwZG8jh3skIUTXADxwhfypMxM7daOLvsZxXOwqF4pD8hNMX538Q20Y8NcYzHAiTRjtEb3bEzcprLaWilnZakMmLOpbK57Y5VsJVMoJ7AlwdiepI4xuBGjfOm6A07p9ojGZ3nIH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 01, 2024 at 12:37:45AM -0700, Hugh Dickins wrote: > On Fri, 1 Nov 2024, Shivank Garg wrote: > > > Instead of accessing vma->vm_policy directly, use vma_policy() like > > other places for consistency. > > > > Signed-off-by: Shivank Garg > > NAK. The vma_policy(vma) wrapper exists to avoid #ifdef CONFIG_NUMAs > all over the place; there is no point to it inside CONFIG_NUMA source. > > Hugh > In that case we should do the opposite of this patch inside mempolicy.c Only 1 place to update ~Gregory diff --git a/mm/mempolicy.c b/mm/mempolicy.c index b858e22b259d..beffdc17aad5 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1572,7 +1572,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le * or MPOL_PREFERRED_MANY we return error. We don't reset * the home node for vmas we already updated before. */ - old = vma_policy(vma); + old = vma->vm_policy; if (!old) { prev = vma; continue;