From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D1CE6F06D for ; Fri, 1 Nov 2024 16:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F3436B0088; Fri, 1 Nov 2024 12:07:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17C046B0093; Fri, 1 Nov 2024 12:07:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01D426B0095; Fri, 1 Nov 2024 12:07:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D8A8E6B0088 for ; Fri, 1 Nov 2024 12:07:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5CD4C1A098D for ; Fri, 1 Nov 2024 16:07:10 +0000 (UTC) X-FDA: 82738004622.12.B9AC250 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 1B1F280022 for ; Fri, 1 Nov 2024 16:06:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IDyiwIPV; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730477049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lyrBN4g3L5t1QHj6styrHMo5POENBFif6oNQRqquBuo=; b=oWzW5D87yU/SzQKJnmUIYF0ZhbNBMFCXTRbVGG62D5FFKkzhf92rgOMubsxIz0qazCXuXJ +OrcsL4AWEUuEgWbWLk1rbTOZIyfRBI3Rs3tH1rsDKIU65r7d8AsbJ0JrZvmgokiE63Qib WA4FmQKJHfn6yqJ1YlawpKL1P4K118c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IDyiwIPV; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730477049; a=rsa-sha256; cv=none; b=ag3E66UEhz/SMO0g9yfpR0Ab/I9QU8qLrZ/LNHMZ0+9vUrCmFhFSZnKyIpWsRR2lzeDaJO GTdwE5SvnUcg6dNMvZdv8R43WNmr50AcKL52wopzhJb8XJAKCRVF8KjGNUT7hv72HsCPUq qONP5HdMHBpHz+pIyjYIHHtSiRtspO8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 151E85C0543; Fri, 1 Nov 2024 16:06:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C7AC4CECD; Fri, 1 Nov 2024 16:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730477227; bh=puI0SDs+qW0sm7zOSrd3QmW6U6V6nJKwF+V/Ey016WI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IDyiwIPVC+I0nepW1fG1JKltB1CDBSghPhStdMSDm3fSS1h4EYVT7zmYznBKN8cdQ 0HATH/bViuo8VFAwcd4LEv/8SVwknLLhAM5/oC2xitEW26DiRlgDbM1k4xhtJEUO12 Sb18c6Aq+tCK57mEyQ36LH+AvqZdYdTp5M1htgSLxZ8oABFvrJut73RH8KEYGtoDcG FRyfBxx8pdeBb76UIR0lOKwpiq5b8OdCXpxGPJ9Xz/g43jHzqSoHNm3D0Fbls8akED 35bn2xh0gnSSBcYWCucb3JZmSGGr5cxanroAWQDN93Qb+K72jt+e2tCZt2Wj8NyO7t 4L1wXfBiK/83g== Date: Fri, 1 Nov 2024 18:03:02 +0200 From: Mike Rapoport To: Gregory Price Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org Subject: Re: [PATCH v5 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20241101134706.1185-1-gourry@gourry.net> <20241101134706.1185-4-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241101134706.1185-4-gourry@gourry.net> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1B1F280022 X-Stat-Signature: qzzycjptyi39fptkjsgs9pwuzbrx1uqu X-Rspam-User: X-HE-Tag: 1730477174-968247 X-HE-Meta: U2FsdGVkX1/sjNcP3NcRsqEPfNmQGfGL7+htQJZvQagI3TC9mNs4enl4zHJFZKNzYcOLYkpdfWF43j8wWrplXmYAQU1mefr9VERkboKI4HIGq656Zn8EDUD/dSGVh8qo1E966xIYd5CTWhRisOboMfQaHXcwW/M8SaWbbGC2gXEZYK8edvqGp04WXNZ3gccVIcmOI+kPDEZhV9gEjYRrURm3BgTBhYKDObb02JFfyUUHACgVZ5IGL0FuUSWKlGSesSTJmsNqQOOMrQBlKPPBW/6tIhDbBTx+PEhyFvWiyHHrGT0vbVaEEowX3l2cMUvR+71P3uGmJyexq69/sdurE8K5uUvKbhBvOFFDAUZENBiMIfeTm1V3hqgaQpCYZucD/rXDpDC6J1Eb9vXDnd6V5my+skdzKp2U3Uk6SfGLT/tWyYwZ2NKGMoJm0DlbvLY8BfMooukCqlhnbCuY6KY2YMfjv7Kta7Mo9aA+8neNDhMx9otNSkhM9jL/agYWIRMIrELEjreXq+3eH6KWRv76UnjVnG/PP+CMsU75IxBgldO0H9OB2AIT8T1QdzDYlIdiWoPBXAE6lk3z3m/A7YdMeCx8lVAeOg0BPL6sqDRQRwTlfXMGj2E2wRS88pDN25sz9cLaVuO40g+bZGu9pvSKyYuFDtWka3Sxsbgax0Av8XSWAvSmdhHa4btUd6fndsv0LQ9nfTl6y9gnFJSiqZAU5L82QGzCC/mhYzIK61lqRIZ5sqTBmosq+DAGy9Huwzwa9Y4CNsjugSXP3B4TUnboQYdEF1wqioEfpgHLmHEDnF4btOrATSre/dlAb762zMn/Wr06il2kn1NH8rjkGdAKRe0Du/9ChvwX3ZvR6TpqrtMHRHLtMAutyjpFu6HgNWP0YpXa34PnPIFy31HXwfzzF/HhdztTTSKPW/ITZTHke20Bbg56BVM2dwY7Zt9rAnCYC4HhegI9O0ImipWxrA8 iA+2WAan o1SkMiw7zekiCFxETF20G70a4gu4kg9Wv84mBoyR7WuYOGg6bAseP5tAAUeuF8pmEqI17AxFl1Dca8Z49ihh+86YqaV8eAevB8p+LmeUTyTbS+l+ZBwKxuTA13hvoeADPac1IVQ3fRXkFPQe6iEulcTb6gNXa2SKETmU/g+aBgiho8xEjl8ag5f769arsCEzp8D5mCj++z/z58HAqheOODTWUGAfURtfOmJMJlHbt2jZoanbL1RSTCXfqulLszC8VqDN79zjMN4Wjv1rsoeYSZxVvFXwqtGeGAwE9T0T8l3w0poZkT8tnCL96woxwBEc6bu5nsUMlzyA9duY6uxr8A8xo85D1jsYa2RDOZ9ijUSbguTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 01, 2024 at 09:47:05AM -0400, Gregory Price wrote: > Capacity is stranded when CFMWS regions are not aligned to block size. > On x86, block size increases with capacity (2G blocks @ 64G capacity). > > Use CFMWS base/size to report memory block size alignment advice. > > Suggested-by: Dan Williams > Signed-off-by: Gregory Price Acked-by: Mike Rapoport (Microsoft) > --- > drivers/acpi/numa/srat.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 44f91f2c6c5d..34b6993e7d6c 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -338,13 +339,22 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > { > struct acpi_cedt_cfmws *cfmws; > int *fake_pxm = arg; > - u64 start, end; > + u64 start, end, align; > int node; > > cfmws = (struct acpi_cedt_cfmws *)header; > start = cfmws->base_hpa; > end = cfmws->base_hpa + cfmws->window_size; > > + /* Align memblock size to CFMW regions if possible */ > + align = 1UL << __ffs(start | end); > + if (align >= SZ_256M) { > + if (memory_block_advise_max_size(align) < 0) > + pr_warn("CFMWS: memblock size advise failed\n"); > + } else { > + pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n"); > + } > + > /* > * The SRAT may have already described NUMA details for all, > * or a portion of, this CFMWS HPA range. Extend the memblks > -- > 2.43.0 > > -- Sincerely yours, Mike.