From: Matthew Wilcox <willy@infradead.org>
To: Stepanov Anatoly <stepanov.anatoly@huawei.com>
Cc: Michal Hocko <mhocko@suse.com>,
Gutierrez Asier <gutierrez.asier@huawei-partners.com>,
akpm@linux-foundation.org, david@redhat.com,
ryan.roberts@arm.com, baohua@kernel.org, peterx@redhat.com,
hannes@cmpxchg.org, hocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
alexander.kozhevnikov@huawei-partners.com, guohanjun@huawei.com,
weiyongjun1@huawei.com, wangkefeng.wang@huawei.com,
judy.chenhui@huawei.com, yusongping@huawei.com,
artem.kuzin@huawei.com, kang.sun@huawei.com,
nikita.panov@huawei-partners.com
Subject: Re: [RFC PATCH 0/3] Cgroup-based THP control
Date: Fri, 1 Nov 2024 16:01:05 +0000 [thread overview]
Message-ID: <ZyT7QebITxOKNi_c@casper.infradead.org> (raw)
In-Reply-To: <80d76bad-41d8-4108-ad74-f891e5180e47@huawei.com>
On Thu, Oct 31, 2024 at 05:37:12PM +0300, Stepanov Anatoly wrote:
> Don't get us wrong, we're not trying to push this into memcg specifically.
> We're just trying to find a proper/friendly way to control
> THP mode for a group of processes (which can be tasks without common parent).
>
> May be if the process grouping logic were decoupled from hierarchical resource control
> logic, it could be possible to gather multiple process, and batch-control some task properties.
> But it would require to build kind of task properties system, where
> a given set of properties can be flexibly assigned to one or more tasks.
>
> Anyway, i think we gonna try alternative
> approaches first.(prctl, process_madvise).
I oppose all of these approaches. They are fundamentally misguided.
You're trying to blame sysadmins for our inadequacies as programmers.
All of this should be automatic. Certainly the kernel will make mistakes
and not use the perfectly optimal size at all times, but it should be able
to get close to optimal. Please, focus your efforts on allocating memory
of the right size, not on this fake problem of "we only have 235 THPs
available and we must make sure that the right process gets 183 of them".
next prev parent reply other threads:[~2024-11-01 16:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:33 gutierrez.asier
2024-10-30 8:33 ` [RFC PATCH 1/3] mm: Add thp_flags control for cgroup gutierrez.asier
2024-10-30 8:33 ` [RFC PATCH 2/3] mm: Support for huge pages in cgroups gutierrez.asier
2024-10-30 8:33 ` [RFC PATCH 3/3] mm: Add thp_defrag control for cgroup gutierrez.asier
2024-10-30 8:38 ` [RFC PATCH 0/3] Cgroup-based THP control Michal Hocko
2024-10-30 12:51 ` Gutierrez Asier
2024-10-30 13:27 ` Michal Hocko
2024-10-30 14:58 ` Gutierrez Asier
2024-10-30 15:15 ` Michal Hocko
2024-10-31 6:06 ` Stepanov Anatoly
2024-10-31 8:33 ` Michal Hocko
2024-10-31 14:37 ` Stepanov Anatoly
2024-11-01 7:35 ` Michal Hocko
2024-11-01 11:54 ` Stepanov Anatoly
2024-11-01 13:15 ` Michal Hocko
2024-11-01 13:24 ` Stepanov Anatoly
2024-11-01 13:28 ` Michal Hocko
2024-11-01 13:39 ` Stepanov Anatoly
2024-11-01 13:50 ` Michal Hocko
2024-11-01 14:03 ` Stepanov Anatoly
2024-11-01 16:01 ` Matthew Wilcox [this message]
2024-10-30 13:14 ` Matthew Wilcox
2024-10-30 13:16 ` David Hildenbrand
2024-10-30 14:45 ` Chris Down
2024-10-30 15:04 ` Michal Hocko
2024-10-30 15:08 ` Johannes Weiner
2024-11-01 12:44 ` Stepanov Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyT7QebITxOKNi_c@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.kozhevnikov@huawei-partners.com \
--cc=artem.kuzin@huawei.com \
--cc=baohua@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=david@redhat.com \
--cc=guohanjun@huawei.com \
--cc=gutierrez.asier@huawei-partners.com \
--cc=hannes@cmpxchg.org \
--cc=hocko@kernel.org \
--cc=judy.chenhui@huawei.com \
--cc=kang.sun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=nikita.panov@huawei-partners.com \
--cc=peterx@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stepanov.anatoly@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox