From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7479D767D8 for ; Thu, 31 Oct 2024 16:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C43D6B007B; Thu, 31 Oct 2024 12:23:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 374A46B0083; Thu, 31 Oct 2024 12:23:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C366B0088; Thu, 31 Oct 2024 12:23:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06ED06B007B for ; Thu, 31 Oct 2024 12:23:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 783F11C6EC2 for ; Thu, 31 Oct 2024 16:23:20 +0000 (UTC) X-FDA: 82734416814.18.44E2A76 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf20.hostedemail.com (Postfix) with ESMTP id D3D0A1C0028 for ; Thu, 31 Oct 2024 16:22:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=XQfrlaIo; dmarc=none; spf=pass (imf20.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730391742; a=rsa-sha256; cv=none; b=tPnifbFo058/MO0Kd3dOeLA5uVyXvFJHVF4vs1AYdWo1iOjl0hqI6kXMxeyxUZsayU/Gmv 2E1/vcQHADC78Seo42vQB/vCOXMCir1GQPdEkn6nxWbezKs1aPxYdbQvPmGDBxxLOrVXxg Fomk35QPaKSMVSB6rmlm+tzlUFXUMbM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=XQfrlaIo; dmarc=none; spf=pass (imf20.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730391742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WrPPGPtF1r4JJPagnUAwxTz8GU4YzNxLE+E5DMVXteY=; b=QIUv/Pq8sOZ7rEKW3r3ged0UQejNxDQfWEHgcpX14vqPq+97CI0QIfKAp7DezlfnkkaxDI /PW9wRJNISIeSd5iYZcH4nPsZpg9/V0OoIjeO5ONITEmC6vFuqM3pJsR19CxmrS4yCgF3z nZhGcMyFLFFjay7ja7ysrZ+7NKq4OWg= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7b1467af9dbso76780685a.0 for ; Thu, 31 Oct 2024 09:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730391797; x=1730996597; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WrPPGPtF1r4JJPagnUAwxTz8GU4YzNxLE+E5DMVXteY=; b=XQfrlaIoSRD4wfbehhYEleIX1wbmd7czc0r6sAdw0M+NVXAj0tLQYXTq0DJlEhGIG6 6QC7GyN7bot3AxbKgEIznzAxPefd9T/VQJxKuC8Dc6LU9krEOkdMXdMAKGY4aWN1yFsf UpoEUWghRPDsH81nS9jtOykwPtUC3lyTN2uYOH3VWCrRUeVygQwVjzH0SAAMO6Ibpvt8 SeQtKy5ebyNmZ6mRjIoKX+cz42jA7qAbcW6Wrkg0vZo7PQDeZ6TLR5BNzmt89saQmjDR P7KkLTfYm9ixhQbQKehdEoLnLvACGtYlJEVjTub40HfQ4swO+MNzxdjYzpYEwsmGOnbg n9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730391798; x=1730996598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WrPPGPtF1r4JJPagnUAwxTz8GU4YzNxLE+E5DMVXteY=; b=m7gJFprMFkQNJ3K7DqCmLP/5M90uuO3nNzJ8YMGh+7gF8RLEfDHGoiLnF8tALRsksv WoObXbatpageoPdUTYuCn+T4XkED03iinKGrdg4qx1TKE+rPE5qAqKOJ+QIZd86Ta+3v Xeg8Ka2acveBgqGJijXPzjxDX1WwXYmXQUchATO9DBwavM/p6VrNh2NR8NeAHQD/MCMV l4nfDL3IZzf25TpJkmpRtwyR33vMfao4/Ej7z9r5FR8yq93tFo47Rkf3Hn3J5EMkqjFb 67xiiMRca7LIE69TfsxfRdsr030Js/GiV7hn5MY7bwdg7zmxK23NKuAY/h/NaIVV4/Ma 0/2w== X-Forwarded-Encrypted: i=1; AJvYcCUT8Yz6CkdlyBv3Qe+AdYg2EzIvZflIbtlzyDFp39zbBdRJOSU3h2zm5GAgfGR6M/jOArNgkbppfw==@kvack.org X-Gm-Message-State: AOJu0YwvALx+SikXtXGoXLL2AhVDT4IkHjWsR5oJxDIqM1n1jSeZxTs4 wmD9a7bwjeeruTcfIxQ+WmD1GvoLhDK/6l3zb1+/MFGEP+WXI4ukWqqKu5X/MfQ= X-Google-Smtp-Source: AGHT+IG0mJPHTCww3DZQuqv9nxseKwFokKX1MWnv7+XcE4NElcJk7zAVUMyfqkFKAZ8kX5Mw9dP5qg== X-Received: by 2002:a05:620a:318b:b0:7a4:d685:caa9 with SMTP id af79cd13be357-7b1aee2c038mr1047669385a.48.1730391797615; Thu, 31 Oct 2024 09:23:17 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b2f39ebab8sm83428485a.8.2024.10.31.09.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 09:23:17 -0700 (PDT) Date: Thu, 31 Oct 2024 12:23:23 -0400 From: Gregory Price To: Mike Rapoport Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org Subject: Re: [PATCH v4 1/3] memory: implement memory_block_advise/probe_max_size Message-ID: References: <20241029202041.25334-1-gourry@gourry.net> <20241029202041.25334-2-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: D3D0A1C0028 X-Rspamd-Server: rspam11 X-Stat-Signature: nfzsyue36tbgrdjfhhu14io64tjy8whb X-HE-Tag: 1730391764-756203 X-HE-Meta: U2FsdGVkX1/6bXkZ18WR7B5Ha0UCsWsnZcbgRLKXQgHv1vWcqfR0f3DLRBlIHwGZegkwN0HZBVFoGjJTk2qMC8e07O4Tircmww7unXQoWhgvT6jeOgQKVNH81rIAXkjz5x9brdXNNi1BlrPZWjNgVgMqlrpWw5EKfT3j4qCCrJVOQ77+nX/mm6mN909gIdMBu67CU5aLEOamLI6d5VqirCWUmXI9Go1gpIBuO07Uw4SrqFJsCsHmYP5AtgwJecdm7dei4hHoCxOfOYpkxfb2zSmxA/YPlhE+bctvUjd20TxB98HjCjWpRal+0OjniRY6y7ZMbxuz31JBloKHuRKSsiRZdfLOX6iy1mFrNCBU9e9EKYU94XM6+/UVmzFdLkqZxfjwyXGss9aIPVp4+/LSWOCRS7/AyS3E2af6cyz4grC/FB9nTcCytN55iAEzYHYF6W+NB6P8GR1KaaF1AYHpfluKRCCN4JTqdhxmwsrUQDd2Vi2SXErzPOwvqq9JnK3ZFtKJ7cft4u34Jp3PtGqi8Bvb8DiwzIewCOCsLMfpJYoFh7Lqa9pZC+AvSojSG6HCT2yEJwIA2OMf1oBmajiylCmTtRPRC+Kzfs9Q8HiUupJFlzwyZgCjN8fz7WNQWWOmdCc3TZ7TmwZ2CzzfexO39ztqy3xqwYDcAgLyEl+nD1IE7fmTIPLbcpuRhW+5oOZKzqGHJcpx5MfegqmjONMwS/XTQnbabf1bctsH/PvjHX0NELVEFRn9Cm8IjxEyUVbQPIqlk1kNcCtt71d/0ax5sS2FKBz45gjaanYkA/7Hjef2VkpTBZaD3je9lYbwEA/3PTIgsqvQ2CsKwzrPUagwC42tVo30NGyp8QQ3Zu2rjLzyYPArhdnLsTubyB1HGlNN3GnoRrx9zri1eLpJ2ExgMg7uBzmH/RY8WYhcFNFXrzupL4jD8jucleOoFIP3cuRcP2HKXmlGGsLJKz0ho8p l5ZEAIXA jTY1PYX7+ZKZfXiAoUI7+lsNk81WwzOa5lqWFv5Lwcl/HVb+se5fikTkcm7V2Ueb429DX636zWGhzfrBUZlOzQn5576TX1Nzcs6TEj5rtk2vmMp4h3G33QRcCCKBVlhPTa76EkP+mRThxi6vhgkG/cA4E9HPRmMPDzMdyVvkK8bN749D03lplyzDDz3YOHqjcnOil/CA2ZGAwpbN4ErLsNikxpvcgrY/vJmZ9hUWGJHVsEfKMcsx3f+ep/8FA59HdcGmdTuBpHZxYbhgzx63Rtj1id+gJNw7re1dXxE8uOLPf91Ge9bjI7C9yPaGDGN8/e1e3aPNVqIDQO9oLQtsvEW35bQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 04:31:03PM +0200, Mike Rapoport wrote: > On Tue, Oct 29, 2024 at 04:20:39PM -0400, Gregory Price wrote: > > + * Return: 0 on success > > + * -EINVAL if size is 0 or not pow2 aligned > > + * -EBUSY if value has already been probed > > + */ > > +static size_t memory_block_advised_sz; > > +static bool memory_block_advised_size_queried; > > kernel-doc will be unhappy about variable declarations between the doc > block and the function it describes > Yup, that was the warning I was waiting to clear KLP. Learning new things n.n;; - new version shortly ~Gregory