From: Gregory Price <gourry@gourry.net>
To: Mike Rapoport <rppt@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-mm@kvack.org,
linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com,
dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com,
dave.jiang@intel.com, ira.weiny@intel.com,
alison.schofield@intel.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org,
lenb@kernel.org, david@redhat.com, osalvador@suse.de,
gregkh@linuxfoundation.org, akpm@linux-foundation.org
Subject: Re: [PATCH v4 1/3] memory: implement memory_block_advise/probe_max_size
Date: Thu, 31 Oct 2024 12:23:23 -0400 [thread overview]
Message-ID: <ZyOu-7MeTYGa7tf9@PC2K9PVX.TheFacebook.com> (raw)
In-Reply-To: <ZyOUp5Juz5x3Ivrn@kernel.org>
On Thu, Oct 31, 2024 at 04:31:03PM +0200, Mike Rapoport wrote:
> On Tue, Oct 29, 2024 at 04:20:39PM -0400, Gregory Price wrote:
> > + * Return: 0 on success
> > + * -EINVAL if size is 0 or not pow2 aligned
> > + * -EBUSY if value has already been probed
> > + */
> > +static size_t memory_block_advised_sz;
> > +static bool memory_block_advised_size_queried;
>
> kernel-doc will be unhappy about variable declarations between the doc
> block and the function it describes
>
Yup, that was the warning I was waiting to clear KLP.
Learning new things n.n;; - new version shortly
~Gregory
next prev parent reply other threads:[~2024-10-31 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 20:20 [PATCH v4 0/3] memory,x86,acpi: hotplug memory alignment advisement Gregory Price
2024-10-29 20:20 ` [PATCH v4 1/3] memory: implement memory_block_advise/probe_max_size Gregory Price
2024-10-30 10:25 ` David Hildenbrand
2024-10-30 14:59 ` Gregory Price
2024-10-30 16:35 ` David Hildenbrand
2024-10-31 14:31 ` Mike Rapoport
2024-10-31 16:23 ` Gregory Price [this message]
2024-10-29 20:20 ` [PATCH v4 2/3] x86: probe memory block size advisement value during mm init Gregory Price
2024-10-30 10:26 ` David Hildenbrand
2024-10-29 20:20 ` [PATCH v4 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Gregory Price
2024-10-30 10:40 ` David Hildenbrand
2024-10-30 15:01 ` Gregory Price
2024-10-30 15:25 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyOu-7MeTYGa7tf9@PC2K9PVX.TheFacebook.com \
--to=gourry@gourry.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=Terry.Bowman@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox