From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3F5E68952 for ; Thu, 31 Oct 2024 03:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EEBA6B0096; Wed, 30 Oct 2024 23:56:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F946B0098; Wed, 30 Oct 2024 23:56:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88D906B0099; Wed, 30 Oct 2024 23:56:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BEFC6B0096 for ; Wed, 30 Oct 2024 23:56:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1D31E1611AA for ; Thu, 31 Oct 2024 03:56:57 +0000 (UTC) X-FDA: 82732534626.17.BD5D989 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id E1EE740012 for ; Thu, 31 Oct 2024 03:56:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Keq2akpR; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730346959; a=rsa-sha256; cv=none; b=3bIPIoxrRBXrpzEqZzzOffN5uTN/S/lAoAGtm5yojYRPWRzI76mHdkzyNEDACfZhCUba67 pPndQ3MGg1VwfblYwKH2yPB/4ZOV4lHWQBmfLsKb020zuOTxwzE2etxjMioWEk4/yYG+uN DnR3YNRp+7lAxtzzfIsExMZ5d9lGSsc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Keq2akpR; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730346959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqJ9jh64pPM8Qyg36I/QTxitIm8h1HrUf1S+E9Or9yU=; b=pobRONc4lQO1ZlC6vRR17MXXRVAbbN1WgD40DEg0URG5/zfUC9TSBsawMT4Urb2GuBXKHd pJRMfjOEVNlSqs5dM0aiIu5v68nB134dTsPZa3uvkMAhHOuxBqW9LeoYdU3Mt7JvKuv6x5 S5WnqFf/dt7k5bLKQtfNcQ/Q3HsEl+8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EqJ9jh64pPM8Qyg36I/QTxitIm8h1HrUf1S+E9Or9yU=; b=Keq2akpRHvVnvh8fXcYKV4XB4I ArivbGRWCw5PPatcDIuL2SbXDtgmLwd8ZDs2QcOJQ5O6Kvb3v0eeHmMV5kWw8onrxNKZLDdSKJMtA XkeqpmfM29NtRA5dX/+c8DI7CLr1/XfIjwkbQOywjZ/1feZeUej5RG8KH4WMZKy3QkIsQajutDz64 s5RaUfZFUbJWeqxZpKZnqkn4FvkSwIzPhlpElbTJaRmstOa0mnBqmsRb7LU5CcpflO2WUy4I+hVLI 02MDuG04rlpKgSAfhKFiJsOEpfju/L02RnYRvzXevXK7ccH3K2P2e3fErHDT+2A6sjv39ZGENXwKF XSl8UKAg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t6MIi-0000000EEJ7-0CBS; Thu, 31 Oct 2024 03:56:48 +0000 Date: Thu, 31 Oct 2024 03:56:47 +0000 From: Matthew Wilcox To: Kassey Li Cc: akpm@linux-foundation.org, vbabka@kernel.org, minchan@kernel.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event Message-ID: References: <20241031024222.505844-1-quic_yingangl@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031024222.505844-1-quic_yingangl@quicinc.com> X-Rspam-User: X-Rspamd-Queue-Id: E1EE740012 X-Rspamd-Server: rspam01 X-Stat-Signature: 7sm99oon517j3ubpfue8z6sns9pyoyjc X-HE-Tag: 1730347002-609470 X-HE-Meta: U2FsdGVkX1/O3oI29PuS47JRw/ForKUbMhBKw8i2fm6HhHsIKXN59Bvko2YJJ8RqU4q3LT6LLSoUdscscuQmk1bxHy1eaoTIgCsgLEC2Bo4/fQpI1J/S1M2tOibrStpyGssFSVCTiO0cq10f4+EL9GVha47raVHOqpFq2SJsMWYvNzbLr1yJD13jqwXqffgZyuex+w0TE3ZzqJs4TOxZ8S0knU4x6PvgCGI/oH5+Dh/frm3sZbHhLmCVjLBZkDnh1m+1oIqGWNpy49LOzQQ7sVMWe81+KOphaNG6nTYfw8hjISOlllTOphwMCaHc6JNU/ZY4rKmQWOoTp0ex2lReaSzDuZ3ofEauRn1Ay53yGp23JUztXDL8xi7rXsFDo2BE5xA0uLCZGmPZ3F/Ep0M7wT2t3RsXqLHceKVhNUm8sNz/XXrOUf0RIszxt05sDEfWHSGZ2PU1I86rrbPwS1gd0p1zfezlp2Wy9KB3cRUjJuPZsa8xw1yqwAaO10ztiJLl8X4RE4LrPd8soY511vhUlbXJlP14fM2N8cBjZxo1jt9kUFLcdwydgzaLkSfJBArzrewb/cbgl6yjlNGnRFguxSlWgF0SMdo9812rWzJNa4pGxh5NONqcc0fWfrdGHQ3XlAFN8cPpKoGWObr9LM2D2Zl0T3vVgcslZnFE5IVWUpBx9/P3mt0yU4eD9e4S2mFjiFHEUSy/BKDWmUxGMdaAjgp2ofRAYL80ar/5UqAk1BPs+TMn+1vUnUs6pu8OO8TsP/PBDv7v2+/FA0PSEotvkZ5C9a8cSWR/RxmHpJgI2fo9NrGSDF9qDBBEuV3UjMm1VCD1T3NSv1W82Kwc82gpyC8iQ+vocksnY3ZhExyHbmYJDS0DASgd602PZLetPIzKXhwfK1e2lJrpt+ncOx3KSBUUAEZ+tjnOMMO6OTQpCVt0Qke3KfvbQqksF/mDqQiJ+3dWpuF/MjABCBnjUWR ZsWcfToG nuosoSkQK1ARVCHLTI0eSqHgrc5yuOqd72GC+eP7sYETKSxnRgHk6d9dJ1d4t1+VqvlpmDZo9efmJ4ENyfoOA4imhPufPGzW2mlhMtkG3/7qxxLEa9h4m9WnvzPzhrpG5Ut+3eQEcPC4zNJn1awu9VWyL8FHxDLmZ2/mSG5oQ78Zvtltk2XWWYWErZ8C2ac+yIQ13qQe6kWAiY+I7LTUlo57XHrqfE9zXG6dkVJM94h0857sgtR6oIdDlHzWpeRje8P+OEDABsDUqaOs/Y13qzjfLXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 10:42:22AM +0800, Kassey Li wrote: > This followed > commit 53d884a6675b ("mm, tracing: unify PFN format strings") > to add page info. > > In many kernel code we are talking with page other than pfn, > here we added page algin with pfn. It's generally a bad idea to print pointers to kernel memory, so no I don't like this patch.