From: Matthew Wilcox <willy@infradead.org>
To: Kassey Li <quic_yingangl@quicinc.com>
Cc: akpm@linux-foundation.org, vbabka@kernel.org, minchan@kernel.org,
vbabka@suse.cz, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event
Date: Thu, 31 Oct 2024 03:56:47 +0000 [thread overview]
Message-ID: <ZyL__1ClDcInaen9@casper.infradead.org> (raw)
In-Reply-To: <20241031024222.505844-1-quic_yingangl@quicinc.com>
On Thu, Oct 31, 2024 at 10:42:22AM +0800, Kassey Li wrote:
> This followed
> commit 53d884a6675b ("mm, tracing: unify PFN format strings")
> to add page info.
>
> In many kernel code we are talking with page other than pfn,
> here we added page algin with pfn.
It's generally a bad idea to print pointers to kernel memory, so no I
don't like this patch.
next prev parent reply other threads:[~2024-10-31 3:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 2:42 Kassey Li
2024-10-31 3:56 ` Matthew Wilcox [this message]
2024-10-31 7:24 ` Vlastimil Babka (SUSE)
2024-11-04 7:35 ` Kassey Li quic
2024-11-04 13:39 ` Matthew Wilcox
2024-11-05 0:33 ` Kassey Li quic
2024-11-05 0:35 ` Kassey Li quic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyL__1ClDcInaen9@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=quic_yingangl@quicinc.com \
--cc=vbabka@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox