From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4CDD5CCB9 for ; Wed, 30 Oct 2024 15:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 701B98D0005; Wed, 30 Oct 2024 11:25:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B23E8D0002; Wed, 30 Oct 2024 11:25:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AE98D0005; Wed, 30 Oct 2024 11:25:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 326168D0002 for ; Wed, 30 Oct 2024 11:25:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0B3480B40 for ; Wed, 30 Oct 2024 15:25:12 +0000 (UTC) X-FDA: 82730641602.04.917C24E Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf03.hostedemail.com (Postfix) with ESMTP id E14FC20028 for ; Wed, 30 Oct 2024 15:24:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Z1X+cMsX; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.178 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730301750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7YLqxwpXuJNQygjoc5/hn+2+ADZpj/AHIhIEEnWpyXU=; b=rnCFswFaQeeXea3Ki12zQ/zHFC+cw+4FjO9GklbOCkColmSFDKuFR3CQ4tNMGGRMSOBl8D ZXp5xDL26Zunhn0OCgmcWtHI+IYcIKd5BP6VFbVqFBfVzIeQUz2I+IIu/zQYfzGMForNBQ W7AX9QERosvoXee3PsVPMkEvQwigO90= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730301750; a=rsa-sha256; cv=none; b=LCom3dXps/55SxDhfjPpCrEbgQGLm4C4B8Y3bpV4tcT1ihB0cxrUvuPzh0HcHvRl7ssbFV 3fxlGzwiokE3rE/cgat2s+mYTSkeb+4D2GdtexbB7FSUfY56DSiJaAPQMQ/G0r+g1qEgxs omD1sQLFJGI4PzP0t9j9byW4RCUeFeA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Z1X+cMsX; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.178 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-460b2e4c50fso104151cf.0 for ; Wed, 30 Oct 2024 08:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730301910; x=1730906710; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7YLqxwpXuJNQygjoc5/hn+2+ADZpj/AHIhIEEnWpyXU=; b=Z1X+cMsXHMG7E78qFdkPDRDJpTkr0RFYCsZ74HXdw1+UEn+V31gH2FgcYxJiWuSaGN giZuZFpEN8vP3G2nBnHWQln3Z7wI6sRFCteAEKHcv5Cq2PoPVkuE/o9JqwOcV5533tdn 64YSg5LA1bJqXoMj+rhlB09cJtzJVF7YrMCvm1sZjP1Jh/tsmRM7E3TFQ6jP/zO2HS9m qqQBBjGEy9sHw7O242birJIYxWYVuvNUGRHqCMwnYUst0N7qO/QCJN7FpwANTCbplhLY MrqguRFNdHifWPhOHZ98WuZMxX7XdOKvx2YWQ4z+ci+Erri7MlmvktcaoXfYWT+dY/dm B5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730301910; x=1730906710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7YLqxwpXuJNQygjoc5/hn+2+ADZpj/AHIhIEEnWpyXU=; b=w6m1wwcb/cyahDf7cJzRxdoxQMhXcP3+F1vWo51n0dr+zzDmIzHk0wiuuG7wbXhBBV 5mYHEHgBZcm+119p5Pxo9+0qhP0v1p3jLxhFtRYSls8FWkMGBLNF8ZnpXj3lCiOsSjt+ r68DxQqZl3ap/X6mzUIw/sWCrLOCO7tLASOwPKLZoN1BmCO5zrEbDJ+tdF0FqAZnO/iP 8fYqlMU3N/WjG+D/YDNDUWgqVFDptxnot80Yp9/N7V1zt/I1eQ5Dv91D6RCUjwLvoXDZ +uEkegOYGCDj4UcDWiVJvywGi7pn2iI3Ieq2NMzK1MHfmXe6mumf4HfefeBK10nRpdGn BoGw== X-Forwarded-Encrypted: i=1; AJvYcCXeHOV4+N0YdCPuIiRY4Lv9fK9rnWMa5+AS7aQmkT3QMSxUnxKEUrdKvoTb3th5DIinqCu4KYNGJQ==@kvack.org X-Gm-Message-State: AOJu0YwtgfcnfNpuC7Ekin/hsOzxFZ6nB+JgcIe5Bix2jPbjraOPLHsH HpZtwS2PHC/lP85VAHi2+WZ7jtewagrWSBddrUIBLp4P/gGmAQD0WpvhGrLeoo4= X-Google-Smtp-Source: AGHT+IFdUZSjkUbpmwREg45uzgHne+Gkj526u++YBcKniEz4ijMYyFG+sSVSPyJ6DJno6yiyLbeAAg== X-Received: by 2002:a05:622a:34a:b0:461:e77:d6be with SMTP id d75a77b69052e-4613bff1f08mr234444901cf.20.1730301908427; Wed, 30 Oct 2024 08:25:08 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46132297c39sm55537921cf.50.2024.10.30.08.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:25:08 -0700 (PDT) Date: Wed, 30 Oct 2024 11:25:13 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v4 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20241029202041.25334-1-gourry@gourry.net> <20241029202041.25334-4-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: wznn1ziarym69h7pixzj3huw6idisn7w X-Rspamd-Queue-Id: E14FC20028 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730301898-394949 X-HE-Meta: U2FsdGVkX1+9P2q6I7x8kTXvmyzwIq/dyMqiSWqbkxQaUKPnFu1eiavRxy97dF2OxlvYz9n3wGGD5O//W/qq2kofSJl2U1eap7fa3k3txICIdvnS1BbuxPaoIRXLvTfFmhpKHkqi92YnXkeMwBccaNcJZOH+KtMSFFd1RWznp8yhMftDpHkRQoAVjhjowrCfc37uE+s6TCjr49AxxODN/GiuLlzctJl2q1O2+v2lJOAdLF3XqS1oGRg3yefhMRfC2B3k8MmGCAfCfl/GQFTmqiX1Amn9K3SqxlOGpp244pTAX8MJElFHe8ACdoowvxGma9DfXMLXr5ZfgBxL677XDOL25NutNH/1uvLykvenXY+yxG/iwkFurNRSE9lNddRCtyJT+LuqaUFRGdEkixWZhXqkE8SmphCprKp2vVv2xtgy/+WysKUM9wk1kutoesOYB58jVa1D8ALqsusDuR6QGZaXME/veZobPYD8SIYMKphm5FmRPMjDwU2Iqa3r7B7Q1plJXrH4GfqoiVBVH9iuDG7ymWS5LatXqbuI6/TlNlq8Csgh17NISAeKZHMWZw5PBfrs/g1IUz5uiYWAHhtt6NykUwvvXaFvdlrT+cxHQa8cSc1mQH5dcrib3uXun2QF6kFkAhLf/R/rlmffAyntVUhgcFdyTeHsPlIiPpq/emv2JdMvaY1WJjK3Vfh59rFg/R6jKe3qhQjnrhCDfhl2gz+qVqlQvHxOaL08uN8xwZraEv1u47f5tF4E+fKsGbSnBiFmizXgPxHIGxcTu/XlqBZFrJJG9qg8ofTcVfYeqmPmFWIlXaWhS7h0+73SspGrLE1+DMWXBdLB9+0YMp9YGFvXRYthxE88SSZe/MnpOsW3EJajy7/KeQ3v2qf/gd1JgGoSq1WLGWw4AJwPqgCSLncrpBC/lA4NmK0/RTnEVB+OeNW1P4qXhSP6tvMFC0hH8+DyC3SmahkYApn4+Dv QdpjIQMe kD6AGP+Yj225+nuEOki6joFkKz35LnEiAYGFrUr7+VqucK6uWBbgvBPMKUrOSgNbLp/r2UUEQvSAPHKvV0KrLlbz9A3zKwwod+6iAAipJSZjyuu89UQ8GD7EQMp2m7+FtJTjfs95c+dIDmqJyhZlMb+rzFfg3LfEndL20+82FZl5qU/OPk7Nkz/T2pO7KMIu5Y0RMfkjZOJBwJNei93pLqFS8/LsHybbeboXJxx73IpvN6YA0OOIG8YRPjhiLcsMOQBwPDs/j715MDORhvrTYnVBVu1CVos4vCNP9AuSVD5BMcod4AEMgRQcaIPlaianLc+3h6LhODT3IfR1VLVTFxtw15s1w3YRgnUb0rcOsSGmRMoKNzNq/Y0mkiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 11:40:08AM +0100, David Hildenbrand wrote: > On 29.10.24 21:20, Gregory Price wrote: > > Capacity is stranded when CFMWS regions are not aligned to block size. > > On x86, block size increases with capacity (2G blocks @ 64G capacity). > > > > Use CFMWS base/size to report memory block size alignment advice. > > > > Suggested-by: Dan Williams > > Signed-off-by: Gregory Price > > --- > > drivers/acpi/numa/srat.c | 19 +++++++++++++++++-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > > index 44f91f2c6c5d..a24aff38c465 100644 > > --- a/drivers/acpi/numa/srat.c > > +++ b/drivers/acpi/numa/srat.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -338,12 +339,26 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > > { > > struct acpi_cedt_cfmws *cfmws; > > int *fake_pxm = arg; > > - u64 start, end; > > + u64 start, end, align, size; > > int node; > > cfmws = (struct acpi_cedt_cfmws *)header; > > start = cfmws->base_hpa; > > - end = cfmws->base_hpa + cfmws->window_size; > > + size = cfmws->window_size; > > + end = cfmws->base_hpa + size; > > + > > + /* Align memblock size to CFMW regions if possible */ > > + for (align = SZ_64T; align >= SZ_256M; align >>= 1) { > > + if (IS_ALIGNED(start, align) && IS_ALIGNED(size, align)) > > + break; > > + } > > Are there maybe some nice tricks bi-tricks to avoid the loop and these > hardcoded limits? :) > > align = 1UL << __ffs(start | end)); > > Assuming "unsigned long" is sufficient in this code (64bit) and "start | > end" will never be 0. > This will work, if start | end is < 256MB, the ACPI table is invalid by definition since either the block itself is <256MB or the size is 0 (which is nonsense). So yeah i can simplify here. Ack. will push v5 once i get KLP to clear another warning. > -- > Cheers, > > David / dhildenb >