From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B11D5CCB8 for ; Wed, 30 Oct 2024 15:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EB128D0008; Wed, 30 Oct 2024 11:01:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 399D88D0001; Wed, 30 Oct 2024 11:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C458D0008; Wed, 30 Oct 2024 11:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 021ED8D0001 for ; Wed, 30 Oct 2024 11:01:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7CF1312044D for ; Wed, 30 Oct 2024 15:01:36 +0000 (UTC) X-FDA: 82730581290.01.ED8383D Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf24.hostedemail.com (Postfix) with ESMTP id ED97B180054 for ; Wed, 30 Oct 2024 15:01:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=UIByIkws; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.42 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730300333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Q8Onf+m3kOOMRY7hbWMtGK0sJkECClNbY5UDCI4RFs=; b=OKnfDjHFp/GZFsGc7MndVNUcwridAtTgZIkkRr0umdPSkon3zxbPnt0HtQVP86ACMpNrOX DpvO46tIxgSeusEum4/FyFuEH69mDLpyQR5D5Sx8vE8QjEQz0HsoE+8+IFzqZftSPC/SI/ pMQy1oD/NvbKnJd2C5NGut7y2JGvlko= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730300333; a=rsa-sha256; cv=none; b=yMgCkGVBcfWtDi7nViRBRH1/P64Q5NSudu76uaHuTm8T3M3IZ+y1/VAS68M7cBU2o2koLH Yqm574krhiIak1RXFjQii4j71QXbdI+/Y7dHZR3W9Ipp/0+v3XacCbxP+M8AOPnjmQ/ow9 kaWAcsI1V8wOTPn4qrpr9JYPzNbD5PY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=UIByIkws; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.42 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6cc1b20ce54so53669986d6.0 for ; Wed, 30 Oct 2024 08:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730300492; x=1730905292; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2Q8Onf+m3kOOMRY7hbWMtGK0sJkECClNbY5UDCI4RFs=; b=UIByIkwsqm4JMWiOk5XR+xqAA0tk++PjLTkC/Jf1jeEV19Z8wiQbIQ/v8+bO9pD+O8 EkMAq2qS+0VpRAXdJMb3OSMzBkvvzTTpTzLptI6d34DBi3E/i5iKkb7Y+eOUDBgXDuDJ rENoHCkyrlQseYiJgDa2T0i1Csgm6p5Cu7EfjRrgzlMEd4xILTHxKAyM5sI7KRQWfdkE 5hHa9J1b9Jraqc3BL/AdMnXNeIPRv22W9ZdPQWZmmpNS9N+OOuIiIgKLixPEfJEA7lI0 TILlt06a2e6zxaZ0fA2w5zpwoDXZu46h/tDhmnx90kzoHY9HfATZUuRAJ3EqFuemmbIN SBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730300492; x=1730905292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Q8Onf+m3kOOMRY7hbWMtGK0sJkECClNbY5UDCI4RFs=; b=t36rJ8RX3vpRIQhDlorTzuXwWtoPZ5XWHveGZc56Tprhoy23YkY17FyZTIUOnO54TX NAqoX+xDzINJjd1FypOfscU9WPmA9696YkkK9XrRafWhdLIuaFYYcZ+pIaZDlIitmhGg E+DbqkwstymECkKNvh+iSuNr6QUw4PybEv4snsCVOsNWj1cijncKmQsWRBaiDiumcGaE WM+3xg75zPiYFV4mbkXIlHmVP+fOdoXVMsLRhAowDMPp1+1nINwPX10G9KyBonoQ+UU3 SCNp+Fk44zbuIWXLQdqbi7baU5r1028Nd4dok64C7zzIKwLEMXFtCTp5WUi0UrWy3Sri 3e8w== X-Forwarded-Encrypted: i=1; AJvYcCUABgwEqsgFyuOjj59M+14TIR+RiocVn/68FcSRFBSj3tIZoFWuXFwW14tfse8KNK9qh/DTlr/DNw==@kvack.org X-Gm-Message-State: AOJu0YxkteJ6TQ28klHcMJGI2PB1a7DoDlVP1u2CRV9NmLz9U94g43kf YLr28ipy/KEYzrTJaob1TUe1zYMQh3Gs9P8f0OaG9eHTXT//2s6BgmrB6oyJ3cGOh1KGtTaFMMQ S X-Google-Smtp-Source: AGHT+IHhuKpLShK8fctWjn/NG1FZnDN5PDqypx/YhKTIWg3COMyVpTWAl/pGdOiRoamvWFhjIhqKWQ== X-Received: by 2002:a05:6214:398c:b0:6ce:1011:60c1 with SMTP id 6a1803df08f44-6d185849638mr176475236d6.35.1730300491405; Wed, 30 Oct 2024 08:01:31 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d1798a8455sm52968066d6.32.2024.10.30.08.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:01:31 -0700 (PDT) Date: Wed, 30 Oct 2024 11:01:36 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v4 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20241029202041.25334-1-gourry@gourry.net> <20241029202041.25334-4-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ED97B180054 X-Stat-Signature: 43y9xrhrey883aujk1gqp4pyopanq36a X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1730300488-155860 X-HE-Meta: U2FsdGVkX19UwAopazOBejFIY4lNuwG379wFuBP2q3+OaNu76hpxOKEJsXlEvjzZjhR/u+JUXiKwzZJdvZ4R4ZrWYy6Ww6h+zr2R+AdgNRLlh7jUNIC+mRz/lea1QkIELJeJiHq7IIYPQIj+Sq5eyxOOOr4Q2OhZ+EoSkTjHjk3ah06wfFnbz56Ol1/CjXb368jB0lygiPnFds2CqUJ64gAIJ74F7/v2+JRhYcww4XcSkrISeyV7sY/irCsiAuto0BTNMo/M5zGjjZd/WIlRbUGE5jQWnvBLJp9hVF8wiWr/IpPfKSJJkuJLlxgt/PGyHtrfKbM/jV4Qkn97hLwTXlqHljqopXkMu4JHz+ZxurG/VgzdWLxL0jA8Jn9VbRYxIJlqc6S90YLe0AU+e0sEtAo8x+loU3woHgAOUiyHWfqva5DG+KEi3ylcNKhJu+T70mToM5JkwShPfUGFADs+/0bPfYXt0rLNWyb78s2kaE1JwHE3YQJNLHpojjHZtw1tO9ExrP2Ba7h2qpN9evdlTzijEvNP6sNpN7+pt9r4K6f3EnMXdeym43RSKL4d8A23QJHDQyLUF6XDiwXadpDNGNJmVCJhKzHMmFj6cICfdCyo01OnpYYszeNOyS0l0wn5jCilq4C7edZwHhyezxVk3jq9zNlH1iezi9/iRXcqN2t49XI9faMgVOawHR6DctOjqCXnp8RBfSf+N4NDhaD+FKQsOAancBUmVNOZ1+or1gmoRFeanp3QaMBj2bWNxSImjRwPtmMjA+WJAiDzfq9ydKgS/g1zvZKPqsK4hY88rrW79Oir2Gd8VHxxKqFpJtf34oUtqimV0/V7GTr2qHvmR93JXGrzwuwoBci6UO8jejs7WmLTdu6hKTtrJqbpIZjPpHX2/2PW+/u8mRsfnWqaJHl7kv+ZaUhwQfQMhHHBbT9o/mWm31IXj0sT0dNWRev0QbP9A4Ya1zekB3qWbeX 8g+84q/L iT9LokFstkCOmFU3mHMRksEqGW6xVkFmgJp85c3OyE5Oq4n4HNNKwPqY/mSya343hfXN9uHaDcjjNteWOGC3qnqk258Vz9cN0mPcsccmSRl0I49yZzNCZvk73Ovo7Sc9eJa83M0M5yVZssyCtGi++T6cKqMqn3XvnD5iCBATkCo0QYmh9WhiAfPmfaKZE7NZAcoTeIWSHknvbFkvS5Unl84VCq9GejYLA1aulTE6gIs5snsbkDYlEV6b84GRmBWG3t4/EIsk1Kot7c35NFZNDJCI4F0EhEtfr6zdoilfJplu3v1zQwtueqFA8xS8u1aROCmSORBk6QacAcwxxNnjmYjmfEyUK/80g0EeH7C2JfUaChuIjr/WMlNLfDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 11:40:08AM +0100, David Hildenbrand wrote: > On 29.10.24 21:20, Gregory Price wrote: > > Capacity is stranded when CFMWS regions are not aligned to block size. > > On x86, block size increases with capacity (2G blocks @ 64G capacity). > > > > Use CFMWS base/size to report memory block size alignment advice. > > > > Suggested-by: Dan Williams > > Signed-off-by: Gregory Price > > --- > > drivers/acpi/numa/srat.c | 19 +++++++++++++++++-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > > index 44f91f2c6c5d..a24aff38c465 100644 > > --- a/drivers/acpi/numa/srat.c > > +++ b/drivers/acpi/numa/srat.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -338,12 +339,26 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > > { > > struct acpi_cedt_cfmws *cfmws; > > int *fake_pxm = arg; > > - u64 start, end; > > + u64 start, end, align, size; > > int node; > > cfmws = (struct acpi_cedt_cfmws *)header; > > start = cfmws->base_hpa; > > - end = cfmws->base_hpa + cfmws->window_size; > > + size = cfmws->window_size; > > + end = cfmws->base_hpa + size; > > + > > + /* Align memblock size to CFMW regions if possible */ > > + for (align = SZ_64T; align >= SZ_256M; align >>= 1) { > > + if (IS_ALIGNED(start, align) && IS_ALIGNED(size, align)) > > + break; > > + } > > Are there maybe some nice tricks bi-tricks to avoid the loop and these > hardcoded limits? :) > > align = 1UL << __ffs(start | end)); > > Assuming "unsigned long" is sufficient in this code (64bit) and "start | > end" will never be 0. > I don't think 0 itself is necessarily invalid, but it would be strange. I can look a bit. > -- > Cheers, > > David / dhildenb >