From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5619BD5CCB3 for ; Wed, 30 Oct 2024 14:45:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE1296B0088; Wed, 30 Oct 2024 10:45:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A919D6B008C; Wed, 30 Oct 2024 10:45:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 958A06B0093; Wed, 30 Oct 2024 10:45:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7887E6B0088 for ; Wed, 30 Oct 2024 10:45:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1F192140D97 for ; Wed, 30 Oct 2024 14:45:29 +0000 (UTC) X-FDA: 82730541432.16.77074D3 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf08.hostedemail.com (Postfix) with ESMTP id E11D916002E for ; Wed, 30 Oct 2024 14:45:09 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=PoxLc78I; spf=pass (imf08.hostedemail.com: domain of chris@chrisdown.name designates 209.85.128.47 as permitted sender) smtp.mailfrom=chris@chrisdown.name; dmarc=pass (policy=quarantine) header.from=chrisdown.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730299368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RoDDm8JP2udkrNnIMKPZ0hp9VS+cBdfycpwS1j/FcSQ=; b=PF8tsTAkQvbpYMm9A4rbqBFgwng2UenPGDmoZG0tjKc4nW9/eK3GA+LIbGiONIGh7jGZT/ JF4qj31m84ccT1qyg8DweB6IiPgkyqyN2D1wUfzppVsXllF55uI8vZj/gRrEEN4AkqckmA xgioimzhDkCFxsvVfA6kcdd2pFJGegM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730299368; a=rsa-sha256; cv=none; b=ax7nbe+gGmXCPCAWNaXDYv7nzsdyMCZUHZHx9jiUGt6m96WdO+i4/OomYooKwSwBoX2NJ1 N7PlywEMjqSgveAif9pRnGv+mZZAgmoReme+F/Xjol2I4LWDFwBW985yTuoGf7woxe/YLd EwwywSfHPuSvs7e2nBJfhOksUCDV2Dw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=PoxLc78I; spf=pass (imf08.hostedemail.com: domain of chris@chrisdown.name designates 209.85.128.47 as permitted sender) smtp.mailfrom=chris@chrisdown.name; dmarc=pass (policy=quarantine) header.from=chrisdown.name Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-431ac30d379so27910455e9.1 for ; Wed, 30 Oct 2024 07:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1730299526; x=1730904326; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RoDDm8JP2udkrNnIMKPZ0hp9VS+cBdfycpwS1j/FcSQ=; b=PoxLc78IUayD0ufpJm5T52zPSM1ctQ2pMzSIzSMAIoAvtbsClQlepmnbM3YzBjIn3s HP7kKKq2LBSFP0OsvpjjjT/NoE2j8+IYmu7qmh6D9BdXs3h76vLD6rLqgAsADrDT00qn qjOCeiaiUtqgl4SlciAJblQKRijjK9VbARERE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730299526; x=1730904326; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RoDDm8JP2udkrNnIMKPZ0hp9VS+cBdfycpwS1j/FcSQ=; b=ryY77PXZNlM33Tv7IeDXeUcBut5vCTVdWXPTTzYTaje8TJG8nUbYdljM/7LLg1tPLq 72iJxxfnayMUeXBK1XOndwaixewegfLz+gp75xB22Q37Pm6Qsfqh9HqaohKL2VavKRmX pyuj/wyLFq4pSLRmCfZP+FWhQqhdn0SKfxPEYwkek+g7qlpz7dMvZcJg0sLaGh75d/cg Z60Bje+3iR1Fux7G3QAScLri8TzHKyRn8mAVypUSTpSEoYKHMluLz/D7R89zikGSNf8a zL1HBoUDp5Iwr0yqtRV0wz6K7rS+1wOYz5CbOVW6WeuusApB5E35P4QmopwZSH6a0sqr /cmA== X-Forwarded-Encrypted: i=1; AJvYcCXMLWgXwEECSVQvxz97eG+Ojf6tYJb1uipMZOkQRBk0/y4Fgyf7YriXZz7vNyBlr3noWSPUejy/Xg==@kvack.org X-Gm-Message-State: AOJu0YwkezH8+uBktZwqX6230NxM/QZuZTnjGCgHwLRb5fYPtXvfZ4// 2cTsOJRuwncOebxeUskSIqGH2NQk0yet2+oeBOwXcod6UdszAonjftUYGn8rELE= X-Google-Smtp-Source: AGHT+IEPjKO/h/MskOFjZ6ZLRebfzAiOStur116BnuhCa7N+oewBVmpTVB5mh8kB+XAVvtST6mt7RA== X-Received: by 2002:a05:600c:3c8c:b0:431:4fa0:2e0b with SMTP id 5b1f17b1804b1-4319ad146b1mr126147855e9.28.1730299525369; Wed, 30 Oct 2024 07:45:25 -0700 (PDT) Received: from localhost ([93.115.193.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd947b2bsm23699315e9.25.2024.10.30.07.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 07:45:24 -0700 (PDT) Date: Wed, 30 Oct 2024 14:45:24 +0000 From: Chris Down To: gutierrez.asier@huawei-partners.com Cc: akpm@linux-foundation.org, david@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, hannes@cmpxchg.org, hocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stepanov.anatoly@huawei.com, alexander.kozhevnikov@huawei-partners.com, guohanjun@huawei.com, weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, judy.chenhui@huawei.com, yusongping@huawei.com, artem.kuzin@huawei.com, kang.sun@huawei.com Subject: Re: [RFC PATCH 0/3] Cgroup-based THP control Message-ID: References: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> User-Agent: Mutt/2.2.13 (00d56288) (2024-03-09) X-Rspamd-Queue-Id: E11D916002E X-Stat-Signature: 94n9uhwh8p76ybnwrabhxotyhcdy1zmq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1730299509-265539 X-HE-Meta: U2FsdGVkX1/142WrZ1SKfgCdZHPjK0Xb9roa71bMY4sOm7N7xsjmcO+2KHBQbaOma3SZgKd7uvPp4bWjZb91ypytzGXMW6qwvZT/NcWV0UDS1BqZQ31Mg5eQZ6F18lz35ARDl1G63s8IB+ItA0cl5sodfYwMyfft0jrk33fzreuQiWnlEDvz+Cx6mWJtH9JivBaNovdLNZo+fBpPbPXQxGcVTWBssiu9cbjqfHNsfLOcDBZHgCHmBbH6wM0EloVzUkbhLW+ROcBoAEYZaoXRtuNKkxButDnplExBMeYTRvFC7bVxl9WIQlQ1kK1uZT0ze2hOVopa8XUGLxqujfEmOHtVH9lwLRKqL3ze4kqz5diy3cdcVpfPwA/ViqQN9RrmHiWa0DQvpG+N6fMhZ4k1oExepff5KlZFgWsCfvfh5lnhxsTQ836vVPhuw+bzOlRgMqkr4EasDi6H1SR7oHItnUv6QhlFfCN39MsJfCY0HwWgm2xvRIAHAMK4l1xwUrr8NWd+kXM4b1e0dZHRverZ3FL3Zc0NBi6m1cqaB+OXiotk8ggxdt3NaYVsxQ2UNwt4eA3YNMYUrthqkv6UnZaiov96xOLkQt89FNd9pBp5+3CxmyC1qI0ph53gFqyJDnEPSMLtERb0DJTHd1F5uLaVJnOFmli41QqJCHkW0ykf3DB565ShtW8GgcpDetOko1BqVyhW9K3VsBKp3HGz4lKz7ansjXXZ+RJQX2bC6Cxhz4TeroXZbKe7EYkaGBXS2RXbudWS54ipSzywG5HLK8yOqwNZU53zRQoVzZ3FNMsuq6HoE4UNWxle3wV439LYpHvbabcT+O17X2+rlwzcrOqDIIgV7ZxH9ZlqUcD3Gg7yebMDHRbaK0D44+pluw/OCVrJi6jyc0fPIqZg45vwqz3tYPDCZSMzH2zQ7Di0QXa2fRx2sJmh2fD1uQpWoUgHo53VHpsqjK3fo+Ok4jnv2u4 H6vQV3X6 JcHLGjwUvTAZLXqbH4p8/w9iUP+Wogr3xDiVTjG6eKju1GRXYOuNHGaIwb2U1W73KSDrsnOSFzHxAsML9vEP1CYMXqWEDRBqby9h/gmkouRViXgiPJwbcvGC+6Qp5GJMYMD1Dbmjj4J8jX4IIU7SBP5rIpvC/MRi2v+xhWo214RODrdD882NbaNwJL9UzxQU8aFgXjaZLHmtcg4/8timNL6iCa06Lca+/FDicsygyKbbUsMLdA+98zsdTfECBiBqsJIVOFAFrs8lgKAYGlTSe1aChj1dkk1ZKBBsOBjWpYJaP00cYU4eZ2OihfqZvrkUIhTZIu4D4YcgJp9fV05bARkflebuu6UN99xM+hUWPRcPQxXAMXurbrN9NMDbJpoa4vpVDUBIzorhPe464Olk5UqthHB1MDZHVzOyiy0RhvuTA1jg65nPHhSzp13Fa00FV7OYj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000739, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: gutierrez.asier@huawei-partners.com writes: >New memcg files are exposed: memory.thp_enabled and memory.thp_defrag, which >have completely the same format as global THP enabled/defrag. cgroup controls exist because there are things we want to do for an entire class of processes (group OOM, resource control, etc). Enabling or disabling some specific setting is generally not one of them, hence why we got rid of things like per-cgroup vm.swappiness. We know that these controls do not compose well and have caused a lot of pain in the past. So my immediate reaction is a nack on the general concept, unless there's some absolutely compelling case here. I talked a little at Kernel Recipes last year about moving away from sysctl and other global interfaces and making things more granular. Don't get me wrong, I think that is a good thing (although, of course, a very large undertaking) -- but it is a mistake to overload the amount of controls we expose as part of the cgroup interface. I am up for thinking overall about how we can improve the state of global tunables to make them more granular overall, but this can't set a precedent as the way to do it.