From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63863D5CC9A for ; Wed, 30 Oct 2024 11:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC2386B00BB; Wed, 30 Oct 2024 07:41:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71066B00BF; Wed, 30 Oct 2024 07:41:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B129D6B00BD; Wed, 30 Oct 2024 07:41:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 924046B00B5 for ; Wed, 30 Oct 2024 07:41:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0C8D680367 for ; Wed, 30 Oct 2024 11:41:16 +0000 (UTC) X-FDA: 82730077500.14.6938283 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf02.hostedemail.com (Postfix) with ESMTP id 4FC5880006 for ; Wed, 30 Oct 2024 11:40:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=bromS7Mt; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730288313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P6sR+aml3UxyTUx7NT7wVuDjaBfNaFGGHSlzNTNXs/8=; b=gsljq5l8IYgKOVMzcuwHKXKLbeGaE0jw4Dmzs+Hjqvj/aAmVGAsV90Rbk5qE2H79Z0ewa6 EmZg9NqSIKQJvzQrx9v2CRf2ZiXPY49LabrsAnP3uHLVqrFOIlvM+rXe0rb8kRwhmG3/0V WSHjU4aUZW5ze2vf9mHf3Z9xlPgKekw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730288313; a=rsa-sha256; cv=none; b=HieQzFxHIE/tkLs4edA4oSRDXKDnh8a34fxOvoU8i/YSZsNyEk8rQTXcPIy+RMfPzTugAR 6n+0vv9VfKuZyVAnyQ2UDLq9YWM9ECV/2O6Nd+3NjVLdBhzlMMCHEvhrmlffYnZk59mfGM xNwbYYCl/GAm3wLJgVCdaJ9WHnxe9Y4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=bromS7Mt; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43159c9f617so60889995e9.2 for ; Wed, 30 Oct 2024 04:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730288472; x=1730893272; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P6sR+aml3UxyTUx7NT7wVuDjaBfNaFGGHSlzNTNXs/8=; b=bromS7MtgIpShoHe8gLQcn6FMWRY4xgWvl7mJMRsesvLOYyW//BQKbATyudWGbr5op s/dUUoGLU0MqebsIek3J7AxLrEgirl8r4LUeOyrl8keVSbiYQHIVQvugVz6Rto81xMHs /+z8ub8RfaDyiqQxgtsB1/EIfHGrpDZBHNvkg0JnR0cCyVOeITKFr+XxffKWlWDODhfl VxLs+UBCDR/YV76VeADH/Lwfxvt+lK2auTjXmMEPGOZ4FOEQCM0s+Bhwr7+ZYAeQGZSW a/1LnyUIhfG4abu84ct8SlXbBz/9ve7CHfY/do2j5OtHc3niMTrgj6u6S3LO4CKBzfal oSRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730288472; x=1730893272; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P6sR+aml3UxyTUx7NT7wVuDjaBfNaFGGHSlzNTNXs/8=; b=nhEu1hrzt5+2mAuWXjIcO9GfOwdNSFNyiXRvCaYi4dlDUFJGWo6JMfIH8RAqS5usI6 5rTwp3MoWRxZgZJ7OT1pbMIaENiw1/qu62K8zTxjpNJ/nrhvdiAcsthAzJz2OtREmcgz KmR+R34cXZrDoVzj7iQWKnJaJJoj2zWMMbiwvL9jRR5ZQfaJaP+hcW+Q85gf4gSHCo4i OpDHk/zxb96vvGxeXTq4qDSxY+wTXO6UZPnPFCMOjmuMvFszJkqaShioHM58LjybEq4E xVUmUFLMOD0TKZ753YCGn1fNcXuhy1/ScUD58v4BnoUSD/lxo+B+/r8iXPECvmPME3h0 iU5w== X-Forwarded-Encrypted: i=1; AJvYcCU7xs1WKZtrQKsjucVnDPWOIzQEkeC6lX4X4NxRtUK+fUjnOQmSdl8AKpjJA8NOeIYz92iBYFOwCw==@kvack.org X-Gm-Message-State: AOJu0Yw1skRRaICHThwfp23FM0JmgUApLOA7tB6TAudSyDzZG+v98toa JtR7O5wxONLk/Gp40cvi11PSyKKb2TyyUgWbfyQHEScU78nktRtNAp2S0dwaxfst+ATcmq3c/Tn U X-Google-Smtp-Source: AGHT+IF1UTGG2OAepUDBUpyfkcQLgws5vfUoxVF55Jzoc7e5WgTf3wnHDi9okD0LZFzSuEMoKEAu+w== X-Received: by 2002:a17:906:f597:b0:a99:ebcc:bfbe with SMTP id a640c23a62f3a-a9de5d992f1mr1459936866b.27.1730288126292; Wed, 30 Oct 2024 04:35:26 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f298319sm556719966b.105.2024.10.30.04.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 04:35:26 -0700 (PDT) Date: Wed, 30 Oct 2024 12:35:25 +0100 From: Michal Hocko To: Joshua Hahn Cc: hannes@cmpxchg.org, nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg Message-ID: References: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241028210505.1950884-1-joshua.hahnjy@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4FC5880006 X-Stat-Signature: 5ijpjk3uousjzcxns3hjoti83ceaapgp X-HE-Tag: 1730288425-228716 X-HE-Meta: U2FsdGVkX19QYzIwBYUwLqLmRvpKuOqRjsPDaI8TtMtpbN9MoINhMRfG+WlccDEqinh1u1WA24V8t9khtuL7J2Dnm0WNMmAX4rn9kyzMxsywcezd7icifINMqRskIbWB/5BT6xV/yuy3OVt1hG1vf/EfHJraWLI0kxu0AYlHC5wpzQooaO+h+yC1nGMGeljnGWj4by185wolAoHS6XNJwvuSB5HcxwIx+c9iYEmdIzJlJBPNcsSl6rjJZqIPsvvHfM6Pz6MoUClog1eim5YJ49cfk0aN3rhwAaEAxKjO8pQYaCHcviVdXmPLgo114kMoniqqkH+KfLHwwqHax//Y9+UD9E2Ghcezue5W2puqPNjIkGDeDnduvZzoNEAwfgOJsXsECKtD4tjVnwCH0nJ2eVjU1WRhgMdUxtfWL1rvi5ZSC8aQ0N5QJE/jTHtovouLR0DZxtW2cWmumUp6dN+CmKgPN1fzwjlxO9nGlDjlgAWcGRw/ANAnMsSzWRyy9tdbWavjJdSrnqzsX/h2DLvd9d3v2yrsLosMoGZwKBo7Or1HipXDToPy/V3hJWdNk1315l9EOzXfB/DahVlmFZ5U0zealaoCI35f3bx2mFBIsK9zc5PXAWl8Nn30Ge9cs9470xHy6bm+x/ObXNeCAK1FZhcwP7DAFRVtAlX7A9hVBiU3igzgZxAgKi8rCxSDFSADjjibuVM3N7Dytm+rpdq9RArcKOYRcQMMAL3uu2X8hu/+NnJ42TnqB56Em07DbGN+VKv4aLGRN2URA97KVLVv7a3x+qowI9yjIppMlmeInUkF6mBaZCQCoPqk8SXJsMJFKdpmHyLFFhmDvR77bFaEicVmgaDF9p6xW5JB+LgIuQyxrQKIiYbUzaIiVzL6D6x1I9/iEXWs0+XUXmpOEVe0dj+elKdN4gCiIeJFZQTsPJIAtyxX4bN7KQkaWBMfyB/VVYIwHHNrovS1wIf1oet PNew4nJQ aWM5Yf82GzxkE3z3ohLGee5bY1B1NCsWvoHT+lBwDPeSTZHFicIQd86PoPJ44/xo0I+8qaqTrsNz9pVQS2Nz6PqyGKJhAi4KOBu9Sx8QfjjxOPU0V/2WbENMLSqvYPoPa9dURA1yrBH6AgjlTzzkWnOag/BmBoMMsLKdN3WMi6gCBpyFTvmvVcHRfhXvbRpgvx1XmW2UcNkRe3nSApyYT4YQ3LlOu4gpNJEN5tA72Z1ADQqkYJs5bcpws2Km+PLjaK99DEICHB62TVqynvlBAlvfChfPlwu0IAK00ckP9+/UB6cWcKGSbEhhAypo8AYNWf+20KwKP0LFUgeYm3yAJMv8vOztHy3Ri+EKTos46tSl4ZoZvMx/dpxpFfPmZiIuS4r+6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 28-10-24 14:05:05, Joshua Hahn wrote: [...] > Changelog > v3: > * Removed check for whether CGRP_ROOT_HUGETLB_ACCOUNTING is on, since > this check is already handled by lruvec_stat_mod (and doing the > check in hugetlb.c actually breaks the build if MEMCG is not > enabled. [...] > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 190fa05635f4..fbb10e52d7ea 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1925,6 +1925,7 @@ void free_huge_folio(struct folio *folio) > pages_per_huge_page(h), folio); > hugetlb_cgroup_uncharge_folio_rsvd(hstate_index(h), > pages_per_huge_page(h), folio); > + lruvec_stat_mod_folio(folio, NR_HUGETLB, -pages_per_huge_page(h)); > mem_cgroup_uncharge(folio); > if (restore_reserve) > h->resv_huge_pages++; > @@ -3093,6 +3094,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > > if (!memcg_charge_ret) > mem_cgroup_commit_charge(folio, memcg); > + lruvec_stat_mod_folio(folio, NR_HUGETLB, pages_per_huge_page(h)); > mem_cgroup_put(memcg); > > return folio; I do not see any specific checks for CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING in these paths. I guess you wanted to say that you rely on mem_cgroup_commit_charge setting memcg pointer which then __lruvec_stat_mod_folio relies on when updating stats. I suspect this all is done because you want a global counter to be updated as well, right? Changelog doesn't say anything about that though. Why is this needed when /proc/meminfo already describes the global hugetlb usage? -- Michal Hocko SUSE Labs