From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FC3D5CCAA for ; Wed, 30 Oct 2024 13:27:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B9966B008C; Wed, 30 Oct 2024 09:27:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 768016B0092; Wed, 30 Oct 2024 09:27:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1036B0098; Wed, 30 Oct 2024 09:27:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DEA06B008C for ; Wed, 30 Oct 2024 09:27:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AFA17160A33 for ; Wed, 30 Oct 2024 13:27:14 +0000 (UTC) X-FDA: 82730344200.15.8E17F13 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 98519C001E for ; Wed, 30 Oct 2024 13:26:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=G8BEh1w3; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730294672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9HtbxSjryw90OYXsSzx4HPo4i/eL/q8xZDQ/o/edBKU=; b=4+TN/QEVW+vuX93a4crOqfep9rHeAev9m1QpxqV39B+AsLbSulPtGj0YdNIjL6uWahgE11 mEPCrBqcMrrXwtnfYMAwCAhbNS171+WCLWJ1wv5J0e7GLMPT0pbe/zSm6pW+A+zR/S7IGk 4ZISP327NleE2WvGzL76XCfaFuTWHYw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730294672; a=rsa-sha256; cv=none; b=pE6V5sSXNJ3CN6T0cDxfIa8lzrlov/nFjf4l1ic7TlARLpxRovaOPHJLYv0Vm39ickSGNE D+/d67fveoN0I0Ejzu2SnAqez37qsGp3R9YW7rTp2ChyOuzaciBdhGZdtEBtgbMUZV4T1v y4PGWb8onJ/N5LRzqzr0p3nVumvIsn4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=G8BEh1w3; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a99f3a5a44cso809895866b.3 for ; Wed, 30 Oct 2024 06:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730294831; x=1730899631; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9HtbxSjryw90OYXsSzx4HPo4i/eL/q8xZDQ/o/edBKU=; b=G8BEh1w37IhnYDz4BeCG/p1YHwA5WByqD9VKEYwuWJIN8lTPAaJYUaICIXlvwS52YP Gt49l0knN6aDth23aCnW3phMHrfGgXFI6FOYPU39KRlFjD+Jf6KLcyJsTRSZFKKmBgV1 zGld/TxIk+zcwuSGOVHUdDNsQZoTMk4vnxxUyel0rLPa2SuYItwj8rbchsL0jpgUc6qV rljzqGHpWPOZUcwoY8snLkJVldUGGcP6+9oPvJqxuvvftOtVWqGfp9TlyUvglp02qUXI eda99DtoEtWaz6fcv/kaolcwh20Fnp2qe19KhPQK4ZIW9tlZnhz2yPIPUfMCDQFEUiTk qZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730294831; x=1730899631; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9HtbxSjryw90OYXsSzx4HPo4i/eL/q8xZDQ/o/edBKU=; b=g5LmgYaTFJX6A7BXtVxXDtnqCZlBxiPTRdgMmZNGTwXDgTulcY1vJgyJdu1stzKC07 SiGH+fURUJKG93nVAXvTLmBUnqWnHGwUFEwYxu0T+hcYTJB8KD264ArIUVOhtS5uUNOG tMLGdYLD2RxF8vc9LKx2hv1z9Nq87fhZmQnTEFvECST86q13OGL8JzM4Zf4z1n4ntjYi 8qgPqlfcTzsWUARyVPzJFED/26mAdIukw7dgFDBtjrkyTOlbVPo+UGVEy4G0ArbLaCS8 bSQ90Lu8T4mTSY4IduS7vSveV2sNogg/A7Z+5B9vs68VwsuS9ZyDWDDhHi2OGH0U+ipz zk1Q== X-Forwarded-Encrypted: i=1; AJvYcCW+XjTJ+FewQAVPyTPS+nzhCL4S6r5UUlDzPfsrj0gJvC4jhBJtoQgvXQCHRLLiojz03+V0upAHVA==@kvack.org X-Gm-Message-State: AOJu0YySssoxH1dTSMeeBn43UDycMH2g9sJhgJX5FRmAX1+GY5y34QxK NvbBxOYU3p9Nvrw8aBr+00YDVyUgZKxWF6YvuEUOvzOPqtfA1nDIGCFuT7lUeRc= X-Google-Smtp-Source: AGHT+IGNnCF/FyNFK8tuf24boPmjQ1iWz91QATCHGLGVRRgZ9UV9vllz/ZNEqKzDBnkV52IH5/GP6w== X-Received: by 2002:a17:906:c112:b0:a9a:26c9:ac14 with SMTP id a640c23a62f3a-a9de5d6ed92mr1556299966b.1.1730294831015; Wed, 30 Oct 2024 06:27:11 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1dfbde87sm566397766b.23.2024.10.30.06.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 06:27:10 -0700 (PDT) Date: Wed, 30 Oct 2024 14:27:09 +0100 From: Michal Hocko To: Gutierrez Asier Cc: akpm@linux-foundation.org, david@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, hannes@cmpxchg.org, hocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stepanov.anatoly@huawei.com, alexander.kozhevnikov@huawei-partners.com, guohanjun@huawei.com, weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, judy.chenhui@huawei.com, yusongping@huawei.com, artem.kuzin@huawei.com, kang.sun@huawei.com Subject: Re: [RFC PATCH 0/3] Cgroup-based THP control Message-ID: References: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> <770bf300-1dbb-42fc-8958-b9307486178e@huawei-partners.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <770bf300-1dbb-42fc-8958-b9307486178e@huawei-partners.com> X-Stat-Signature: mmrnn5m3cnc75zw9uoif95ks6ik3h9ed X-Rspamd-Queue-Id: 98519C001E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730294806-194091 X-HE-Meta: U2FsdGVkX19LdsVxyn8WJQBe7XSyaYV9kXJjpuazdrS9pNMz7Xf5RUjgLS5ebiXJM+y9uSFpEwt0Tdp9P7hd4rKZzs7hhb9epyIPDiDTcEhoLH42d3xPm4T+aamWGP3p42+GlJibDwob8LQnlcTJ6jhfluTxbocwGrLQh/VmB9KrZjhxKr6ARoF79TgeFbhuRe7TJ9jt3pbsvnjeVgJeXDShFO/fzIKus8VAXGOCLfgs2TAHf9QLgg9TtGj2W7c6GdCfD+p3wSupJ9EPq9tDDkdL/G7/IzraMpKxkvcexs0HcIHDILC0uISO1lB2ZxDod23pAq0/e0FyUJXHjRX5lpPLNVCNg4u/JW4mzmSZT8JPNkekcwcTmbzVvWIDH0CWU4LtfLOvrgz6zp8HmRedWAkhy9kYR0ojaBLbmV/whU/VN/HQphSO+XU6ODBQ8rYEAhQ+5A1SYGjBj5/2a8oIfMXLfIH3BYI7+RzZXaxGl7oBC5wf39JbUt3POHkoP1EWu7Jk0Cb6xRaLs2+3a/NMNcon0nJpqNgV2bzN9yM0BWd0Z6ZK1TnNehTgB5+4hXWZgL2vsyJAxivy6VveHeXeYNpbfSLyIfEdpQ7oPIWTwT+2coPTZ134v94WqjevpjMxuCAK5qvAcOkWVOW7qjtFPWhGqUHHOHIRTUxLHZGqusUTOqcmzvAUfG/6+yxhr8gGx6ElaCKuS99AM7jeLGFy2RvytXSwSg5L57ApEub6uNXSw1+phuKHtq26ptERgHySH3K+G3g4nuM2/+PKJ6tL9nKtkbXutCIQ3DXP6EWG8S6ZB7oUjgcDWgPDze5laqgjMd+cHJAzw/SfFcPUCiX8lXOPeZG0RkvtGzKGRE9Iuh4Zg78ZPmJsZUBPSQSvCjxqXZOq8/iVn+u5uf9tJy1Yxazt3E1tCyKZOmEUOETOxHxHxOXrhLAmBG4YiwQ2/HYzCzX/eeUQrzMpkd3kRvs 6k76uwxi kxxKaVei6kL8+jGS+oJfHUEn1c3hYZZyLo/bQPwf0V4NQk2VhTvq6yATejXNeQ9ChMLwcknXq7BSRJ+EQvzUdosliy5KQ1AVqZT6U7gTxYdPIzJv13fgdRdLC9ugOHa8lEYUur6FNmsCqNlWavzhPok6fwKRTPijL5hM9qa6+3yjUwtlL0EudMJ8nVljiZopGrWF6IKLTNek5SvQmNAXn42eQpHZO1bgK/ImupmXWh8tsxfwB3xp3FmJGtvnkJcuS20BaCxNELhPjJ7XJ6cf2LxLpARW0BGUaI9q9By9V3Jl+EbCyLK1pMZqLh77YqqpOZNYm547YRYAhjn3ZwWk89oNWhKMmtwJNK4N2P6QFbgIEyBIxl4n8J7om0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 30-10-24 15:51:00, Gutierrez Asier wrote: > > > On 10/30/2024 11:38 AM, Michal Hocko wrote: > > On Wed 30-10-24 16:33:08, gutierrez.asier@huawei-partners.com wrote: > >> From: Asier Gutierrez > >> > >> Currently THP modes are set globally. It can be an overkill if only some > >> specific app/set of apps need to get benefits from THP usage. Moreover, various > >> apps might need different THP settings. Here we propose a cgroup-based THP > >> control mechanism. > >> > >> THP interface is added to memory cgroup subsystem. Existing global THP control > >> semantics is supported for backward compatibility. When THP modes are set > >> globally all the changes are propagated to memory cgroups. However, when a > >> particular cgroup changes its THP policy, the global THP policy in sysfs remains > >> the same. > > > > Do you have any specific examples where this would be benefitial? > > Now we're mostly focused on database scenarios (MySQL, Redis). That seems to be more process than workload oriented. Why the existing per-process tuning doesn't work? [...] > >> Child cgroups inherit THP settings from parent cgroup upon creation. Particular > >> cgroup mode changes aren't propagated to child cgroups. > > > > So this breaks hierarchical property, doesn't it? In other words if a > > parent cgroup would like to enforce a certain policy to all descendants > > then this is not really possible. > > The first idea was to have some flexibility when changing THP policies. > > I will submit a new patch set which will enforce the cgroup hierarchy and change all > the children recursively. What is the expected semantics then? -- Michal Hocko SUSE Labs