From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57502D7497F for ; Wed, 30 Oct 2024 08:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE5428E0001; Wed, 30 Oct 2024 04:38:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94DF8D0007; Wed, 30 Oct 2024 04:38:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37368E0001; Wed, 30 Oct 2024 04:38:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F5028D0007 for ; Wed, 30 Oct 2024 04:38:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 00ED61A0572 for ; Wed, 30 Oct 2024 08:38:30 +0000 (UTC) X-FDA: 82729616130.27.7976861 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 9210980015 for ; Wed, 30 Oct 2024 08:37:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=V9DhAseo; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730277333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aftQ683jJAo4rXGMCxZZQX10YwNrjbmnKyIyZDaOAQ4=; b=YUa5IgCuhOmcUATJKs/eLKLTOrs7C44IblwItbKHeYFpizP199W7zNHNOsxMjkfAiYTZFt C2p3OSy0caiCgrSca0KwDJj0/YmrLS65R4XUb4FO6k3ZRC8zSMEATxtiSozGqY4vVLb0Sr W4tvYYjmVMWYQIAj9Sh7ZNOeA6i0DM8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730277333; a=rsa-sha256; cv=none; b=6aq61y2NCx+YZzIsppPKdtDeVxiGL2daaaKYjhBDvi40Sq6MufRmP+R93pEY0rw4GGiHvu vAOcaTGHJ1Yhi2JNtL6iWA24jYuab89Tcgf56RHAB5vebjxm42u16ud+F+vM75qP0KaRX/ GO8lW7MrY+fE3zJ8MZBCexOS2nR+Y9c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=V9DhAseo; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mhocko@suse.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5c94a7239cfso3447658a12.3 for ; Wed, 30 Oct 2024 01:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730277507; x=1730882307; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aftQ683jJAo4rXGMCxZZQX10YwNrjbmnKyIyZDaOAQ4=; b=V9DhAseo8CQ93pJReP57FJOeo5GNatoQqHQIFNpAzBbtMEJ/Z2dKNsYu54+QLt/kgZ HNNA4BgfWL3G8RtkB9B68/rhXLClbdrHXvgDuWUoLqgJVd8hfezraQvtg0Yc2hjcqNrO wAWxa2l2wnV97HwCrk8L3KhIwXRIzzeq/6Gh5lZWh0lf+wabY8rT43aHrneDLmoogeKq A0YHf7Mysl7FvibTOVyGuFZ1izmSs82kElbBAHMlLoAxJUbyWbIouMgbMc52DPg/xPXY fhiXNPakFyPCvWXqEwcwTlV7Ss4gjB4A1eybVDc4Me6caaEt3HaByu5yvqiHj7dzVaxl JTWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730277507; x=1730882307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aftQ683jJAo4rXGMCxZZQX10YwNrjbmnKyIyZDaOAQ4=; b=JPKwi5mX7t4tThavFwnv0MGAai94i/bobYytZDhb1g/bTEQ8G7IlQfuXJZdmsKgjC1 Uy21VSVrKI9Yl7xuUsDvgzEfjgh9+TvK/eSxccmaWFaH8LTqhEbMbsk4+AFazGCUgo/V 2EXVBV2zbrksSmrqKjLQxuiGmbLo3Ysl3tR/7/Pq4YPI3cF4376PB9fRoFIlRAWC8q5k QMHX/HHlYoDGLQtXw2fVbYr0tmSFuVdZCDwI+Ei7wSv3FwgUa3ps0zMNwRkyS4XvaMxt Fk/pBbRj+/lF1Yq6en062/3cK4y5ryWNB/ZflA7YS5XmMOssu6cFaB2M7XHu2p1ljDzA zIVw== X-Forwarded-Encrypted: i=1; AJvYcCV8MWeYicszkIZgXeGsFhLB/ETWWsZsHaRbHC/0eZDp8T9SdOovLSM9CTXbv7+V6Apq7VdTnJNrTA==@kvack.org X-Gm-Message-State: AOJu0Yw/GAST/NqOWBRx4L12+XouAe4lv1I3F/5U0dWp91G7HpFRf0yL aIQp5FU6V3zCUE3v2gUM16Y/rgKKdj8StAJsch/kDxb/STR6AEaHgt/wvTTcNa0= X-Google-Smtp-Source: AGHT+IElsJPhn7Xm/au0bXMmmlRZ2SlufTEmqVxr4t9O0CeASfSKuYaq79XRGxmkxuwFdHyeeoZCeA== X-Received: by 2002:a05:6402:2345:b0:5ca:1598:15ad with SMTP id 4fb4d7f45d1cf-5cbbf8899ccmr13639074a12.3.1730277507395; Wed, 30 Oct 2024 01:38:27 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb629f83fsm4605151a12.38.2024.10.30.01.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 01:38:27 -0700 (PDT) Date: Wed, 30 Oct 2024 09:38:26 +0100 From: Michal Hocko To: gutierrez.asier@huawei-partners.com Cc: akpm@linux-foundation.org, david@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, hannes@cmpxchg.org, hocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stepanov.anatoly@huawei.com, alexander.kozhevnikov@huawei-partners.com, guohanjun@huawei.com, weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, judy.chenhui@huawei.com, yusongping@huawei.com, artem.kuzin@huawei.com, kang.sun@huawei.com Subject: Re: [RFC PATCH 0/3] Cgroup-based THP control Message-ID: References: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241030083311.965933-1-gutierrez.asier@huawei-partners.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9210980015 X-Stat-Signature: x1hp6g8yrqzcmgyyr7ke5htbxd8ochw5 X-Rspam-User: X-HE-Tag: 1730277460-924808 X-HE-Meta: U2FsdGVkX18WoGnW31pvl9L8bDXPRwfsznBf/vECQdxZbgz/o9JgqFaZFnvCP2TsQiT4C3qt8AlCQnY56bKNUTmwhj4pm+J7VZo1TaU1OkSFmBi/7fRgdFRDGEFftRPS/cmeQCA/YSFB4gRwHS8NVh8JG/kZpAjqg7Pa0JtiizfuMv46B/vNlbrfnFtCo/aUYcj+KCBBOENuFO2RnvO6cVP8o0VdqysasVHghikkhUx3TTUMMlsB8BRc2OZiBnRGZMiA7MZWfEF/sndXDK7dLSsU+it6mem6Ai1zrAoqGIdwJq8IF3o1z3JOkXL55cSqpmiL1hMBZnDVXZqtq2MIWaIDrgeDOoYDjXVqUW6tS8TWgSCvhg4veolPZRM4yMLOCWTRbvSVQP8s/Xp0dBLsIHPEuKQyABnvL26YopJs2UGCC2V3HHWK2mBaY9syrJJw5DL0ZwzO7I8H4W999oq+pt3vJW1z7jNuBUow24CZr80cmh8E2jSapKuWbD8BdsoVzXeflqvXDyQVAE8oP8I+13V2qpF1KHFTPWUOtOikvyknl1NJCbt5F8kfnI5hS7EL5X8ex7dP5d+1UeNqNLidBpcuZhsFiOCueT4c8CrZU8uk7QRcChWQ9kzqVBhmQ3ZvSjlb7rHQ6APLobxTYwqjBk+GUxxYWfdTAMq8TBpfqYtDXXf63qYY3avSOIl2iEhMqvsocK4DKOWhy0O56v3w5+v7mSdV7jlD9qK/UXVosef1l10vV/+v6pxafWyQPX9KNbjLFEOwikic+81ckJPXOR/a7RfLjA1dceTer9sQA0ZIfgevx5ED+s6bjMlqcVhGXUuk27vDFi87y2bRbKr6LOj5bqsDS3yTsHM0XunQLerJ/PC+EMzX4p8h6xWPZguWyRN5VGeu1EF/vnspAgY9PFLBaG+bof4pFlKSw4Fko+5XCvNVDhBehiVKfDw8aabj1iQuKGbwOegZqfoedYD IV9Z7E55 5pE2utKRVaisNA4wBqkfYsNnesIVkmhSRuh17CipN/Ypia215EmGpCutjZKqUz2QucLTs5DfEaKUxY0eXrAnghJ19A6Fej2r41gYH+UG3OtWIU6dyqOzpd/F/R3R6au4TPwU0pXGFjvSdXqhhwNBCYNcKpJZ8AVAFo+oWLq4+G3CMWcl9R6wCsBBN0y8k1cnjLE8jt1Z1EL7B5B1CKa6D41IbhtZCcpH8AskTbuYZihGux77ZU/KlUpSc95lQ8ad9A1njvVsejViQ4RHhY1tk69MhC2EsnHOxO8zJN57BGgpXm12tNusjPb5FtwjMG+oc0ZPK6gkWxTVf/4JOzRq0TMG5Mq/maRnKkt63ghw0+sdvz8jmZ3OQVR4Jpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 30-10-24 16:33:08, gutierrez.asier@huawei-partners.com wrote: > From: Asier Gutierrez > > Currently THP modes are set globally. It can be an overkill if only some > specific app/set of apps need to get benefits from THP usage. Moreover, various > apps might need different THP settings. Here we propose a cgroup-based THP > control mechanism. > > THP interface is added to memory cgroup subsystem. Existing global THP control > semantics is supported for backward compatibility. When THP modes are set > globally all the changes are propagated to memory cgroups. However, when a > particular cgroup changes its THP policy, the global THP policy in sysfs remains > the same. Do you have any specific examples where this would be benefitial? > New memcg files are exposed: memory.thp_enabled and memory.thp_defrag, which > have completely the same format as global THP enabled/defrag. > > Child cgroups inherit THP settings from parent cgroup upon creation. Particular > cgroup mode changes aren't propagated to child cgroups. So this breaks hierarchical property, doesn't it? In other words if a parent cgroup would like to enforce a certain policy to all descendants then this is not really possible. -- Michal Hocko SUSE Labs