From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E5AD3A676 for ; Tue, 29 Oct 2024 17:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 286386B0099; Tue, 29 Oct 2024 13:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 234946B009A; Tue, 29 Oct 2024 13:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FCE66B009B; Tue, 29 Oct 2024 13:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E6B186B0099 for ; Tue, 29 Oct 2024 13:33:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89CF91602D6 for ; Tue, 29 Oct 2024 17:33:03 +0000 (UTC) X-FDA: 82727334690.23.88F60EE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 82FCC140011 for ; Tue, 29 Oct 2024 17:32:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730223006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V5/m98SCsuWyhGETBfSTsJ23RKI9RIUIQKPTQpndJ3w=; b=GrLDxmI/u0lkCSmH/YUu+sZCVgGn3yriWWFjB/lYkA1NJJHw+ursd7xNGAEnQtE4EnmHlq Z9QfPG2hkbOzkxpmqvKU4J0CQwpgZ79W9KtR+5IOikJzSJNWzgBN/cJan6/1qdSjSPtF2Y JnHsdz5x219OBcWT0/d9EeoznB2acXQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730223006; a=rsa-sha256; cv=none; b=blZnugdKZrKR2U09/E4YfxPB+QSWAv79w0G9GUNYQlh8LvBSaQB54lSWBbOo8v2xvnDzEy u++BWsUGClD3Q/FAvqun0q/O4SrmB3tFw3aJLvuTzpZeHGXunkvBC0HrvBagl1kRAlLO9U nj+x9tmJCx6sKfMnfPNzG4jsvB3bUMU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 239B0A43130; Tue, 29 Oct 2024 17:31:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76539C4CECD; Tue, 29 Oct 2024 17:32:58 +0000 (UTC) Date: Tue, 29 Oct 2024 17:32:56 +0000 From: Catalin Marinas To: Lorenzo Stoakes Cc: Vlastimil Babka , Linus Torvalds , "Liam R. Howlett" , Mark Brown , Andrew Morton , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: References: <0b64edb9-491e-4dcd-8dc1-d3c8a336a49b@suse.cz> <1608957a-d138-4401-98ef-7fbe5fb7c387@suse.cz> <2759d754-9bd7-4bc0-a4a3-42f733fb2596@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2759d754-9bd7-4bc0-a4a3-42f733fb2596@lucifer.local> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 82FCC140011 X-Stat-Signature: ako67wqf1hrfeeo7tkbqxpy9c3nqr7mw X-Rspam-User: X-HE-Tag: 1730223164-540365 X-HE-Meta: U2FsdGVkX1+9mHymEaAz6VqfknayDNOOmDRTeA0lygTkMwqIqHdzMUD5AMMi5tou4XqJ0cezmaRtisKOjUvWWGjxuCCDOqFkLayThNo7fSVqOcBeKEPRPlDHVKQjmY5gaphGzuuCibsY3dmYzwCskpAo/NAqg/LFXcAxt33FNAnWm290/k6Dan9/xcadyWCqNT5mt29kQHkNYFPvyJniKRMpGMOgXMqayZhVSLS2RP2NECgAr7hROPbHazWceiFf8/Bw3bnGB4RqdbKXCi9DWP+DVyD8FDqCcW8USUATCsuquJNP3Tk5hpGIPc36PFefKZB5MtFFB6GELi/+RlzSlA08nSqn42WBMtIZ9LLAdtsnuPrgPReIhr2ZczY8WILF4nthSmGwnI+QIFWr7LRhIPjRNEqbKJVJakieZ1gNexB/IGtGXT/puC22o1Ctc9BHoFK4l1MHO0nvXnR/229tdP78hPAliZR4RFQ4gnvp6GutV0TEOrzL9QaOQy2YUtB12Rg/p2vFq0+eM6TkTCYjBRRZYOdoqigoxzLCrwKyPn/Gy4JrqlcTZqwFSZfey614LRw6giWf5aGMC6X/mdkVvxzUL4abC+uf8IbSSCjEudgxxXsYX60k3NoGhDxBz54TNwQBEXB3iYt1KbVRotL7YDgov3maAMFCs8UmphaLoDpJiHf0E1Xla2YsJPNl7vTbmyDh82wwxHpYlwl+DdwUU+pAYHHH0zrYjY322oJa+tMgCBXl1pCajRFCY9MHDtbWeKpclulszXBwGq2dln/LXQgBouZ/63XMM5UL4caevW92E2bGRYjzgF+gunwMuzD7J1fC/vmMFCDJefMEy7VwiUORvBkKDPEqg3JBTMNPjXCQyN8rlRFc/lZ2VYm52qP9/ALtklEcy0oWRiVN7KInHeGFd+fnaO5wMZD/KOXAVfUdOJkI3J9TwJ//jqIbUbiHf9zpqpQr3B8/hbMWzuo +Rdl4EHk XsA2IKYyuYu2jc9j6bRq6Vcoz7PMtzvyHoXxMovbzeph5saJZtI+bbavhqwibAZ6QIDZNWMhiA4vp44G41UcvDxYAX4FB4VYM8UTZHWxcfyXJmwKcqYHFWd3Hxx89ANE9NxPONPFvRvm50OSo24rRjFpOWuAeggOIAcLt8dtobF5ek88W5uFrrBiI1rMWC59kalWzEoKuWpzNxujjZBGa9DCcxPJChqBESpfAH7kw1gCV/cmcEefo7ucp/bRjJR9VzzBIBFFepU4wlXcogLVaa+Y01zqvlpaVLCcJ9Vn3gty3GRWF8IkX31Tpq9jEV6qVa5FTLhntrf7cLJc1nqktzGW7LP7C+PT7389m7RRLBEG7OfAywyg2aAF+SEp0yCamPXs2E4CI+y2i8Es= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 29, 2024 at 05:28:49PM +0000, Lorenzo Stoakes wrote: > On Tue, Oct 29, 2024 at 05:02:23PM +0000, Catalin Marinas wrote: > > That's what I meant (untested, on top of -next as it has a MAP_HUGETLB > > check in there). I don't think it's much worse than your proposal, > > assuming that it works: > > Right sorry misread. Yeah this is better, let me do a quick -v4 then! Thanks! > Cheers, sorry pretty tired at this stage, was looking at this all last > night... No worries. The way we handle MTE is pretty convoluted. Happy to simplify it if we find a better way. -- Catalin