From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE74D2AB3D for ; Tue, 29 Oct 2024 13:20:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4142E6B0092; Tue, 29 Oct 2024 09:20:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4686B0093; Tue, 29 Oct 2024 09:20:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28BD26B0095; Tue, 29 Oct 2024 09:20:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 097A36B0092 for ; Tue, 29 Oct 2024 09:20:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 79EFC1A12CF for ; Tue, 29 Oct 2024 13:20:43 +0000 (UTC) X-FDA: 82726698978.15.C0E66D3 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf28.hostedemail.com (Postfix) with ESMTP id B8D71C000B for ; Tue, 29 Oct 2024 13:20:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=LgOsZ1vT; dmarc=none; spf=pass (imf28.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730207998; a=rsa-sha256; cv=none; b=W9L/UfgSlF/YndqUiAG+eqXn6UVkDABjv08ixM+DUtcp2cgpID1GKvn4BNiJOXwFEvuedT rGXfOM09XyrtUEFeBXgwXe69VXVemUj6PNynqJUmhSfhFOIxkibcovHfzOD/43HavY5Q4I R/wuKpcHXZTbMPXvOgReWadq00YK2aQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=LgOsZ1vT; dmarc=none; spf=pass (imf28.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730207998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X13QuMz4ULWUYaYEjbvcdDk+axoVrdNmaWAMXcQKv4E=; b=PeQP/nt+RmpxxQr2A7GSTenYJbpa8z7IafR5NwoQffuVWdh5G53BErUU95K2Ls9fS9lmYa by4YAKB025KTdPNnvvMjSFjSerygUSbi745QGzr7urVpEHsAGsnZd0xxac5cfwHml02c2+ odF6tw2+9qWDais7G012Dx2TCV4Hxmg= Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b13ff3141aso417160185a.1 for ; Tue, 29 Oct 2024 06:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1730208041; x=1730812841; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X13QuMz4ULWUYaYEjbvcdDk+axoVrdNmaWAMXcQKv4E=; b=LgOsZ1vTll9/MC4id13dz6mO+h3Px1nnvG7yP4jGEme3UnwjdsIlhLQ43Q6mHusj0z TTyJs2YglRHVuzHoPpCZ751PvSBbxa4ZeGP/lymTedCnywkQXLpE/y/JkKk3yB5cxZeZ A9Q+7lNEFPQMoehDrRvG3I8eI6tiiX921m1kmUcR5hIMZfWnLwMwhFJQprZLHWwBvwUz tAMEcOjv2nP1AMyd5mYv/dZlo3RjoxCXuyXy0wCQr2n1D7YK1NZVaO9EFr28tLJc8ijx aHMS5hMHgrU4JSm6qedTZgpLMgTP4MH4rAxkiFqYXr5xXhMuXpsQgc4N7yLeeC1YtnuE IxaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730208041; x=1730812841; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X13QuMz4ULWUYaYEjbvcdDk+axoVrdNmaWAMXcQKv4E=; b=jHmCeFpFGwFWo/7zHw3iByflrs0TmqvBtuwH/edOZvBA3Ijajx8F9l8hoDXhfP4CNc EfBXNg2lmAzeBk/gN4wtYr22xYC5ZZiyn57CDH1IBlfZmVGOvm7OS31VjEzdo8NOVoca +KLJjVUoQyOarrci06iDlx9l1f6SOBnKlAwRS2eGf11/xFhJuGL1oax/WV/3op/6lnsg BSmt3vNPiTiQohpJAgEE6wjom5V0AXhbcZWzDISc7ZDeZJUXXCNg0Z0ELUIJerSKfywH AP4GIgGh6vIlNn7RXW86MWR4evJtnqTfXqggi9wGrgq7FJECzJ+vjzSpGuIJRk+Lvq3Q nGPg== X-Forwarded-Encrypted: i=1; AJvYcCUXk3N/7hsGkUCx1QH+Kb+ebNey4azwucy9vQ8lRPupv0yNlevXnZdBJQ/6MSkfVSmZXdwDILFL4A==@kvack.org X-Gm-Message-State: AOJu0YxbSz/QniR/QvEcV5kjgAVMi+T6yOkW1jqQueq55XsNnof6TQjs rnMekfpR22P9X0LpBIA/TzkCK+OUpjTwkh6YTu08HMSlB/Iec2Fl7l1H7rWR580= X-Google-Smtp-Source: AGHT+IHhg5v3TWiRx6aq9mSkPnfzEXY2e0MobJKbVOXNsfSKLR6G02+D9thPPmKmqRlxnYDQq09kuw== X-Received: by 2002:a05:620a:1725:b0:7b1:4948:109f with SMTP id af79cd13be357-7b193f650abmr1528422385a.57.1730208040698; Tue, 29 Oct 2024 06:20:40 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b18d32c9e3sm413535685a.80.2024.10.29.06.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 06:20:40 -0700 (PDT) Date: Tue, 29 Oct 2024 09:20:44 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@kvack.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20241022213450.15041-1-gourry@gourry.net> <20241022213450.15041-4-gourry@gourry.net> <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> X-Rspam-User: X-Stat-Signature: ynbqbdy5uja1a9ag3tgohf8643p893i3 X-Rspamd-Queue-Id: B8D71C000B X-Rspamd-Server: rspam02 X-HE-Tag: 1730208016-318462 X-HE-Meta: U2FsdGVkX199I8U6Rj0V7J9yPDh1NT7yYaku7HW7GZnrWzrRguiMajg78pR/yktm/ZhBBZIn4rk1dqMuZ4AWQ9/jJgUcPxlHlsePUyrB3zrMBw3M+ajRJlMiezs+tP8BULjoq1Mg85VbKKgQ6cazRGcBxSOwfeGk83zg+KRyTVgan04FxFY/HSH0DMmQrwRT/JFir4G874q0B4NO34UlDo1rMkPKVSNQbjxNWtX0seUxinB5X3M3WyqatGskICezTiHdBa+IyFHteERv5oXpQL1D/+9cwIpona6yQCvB8gdemb3I7qeum1fNfHxM13afXdwHA47QK5KTV0Uo2yIrC0f6zmeLlLrK+MODl3FeNLyOAaunYDUnxnl02vQQ8UdTkaOpKPnFzY92XoZkI3PqiBInPR1JLygPAmy0Tbc8FHqJ9uDRf3Hze7HveqXCDXXMmVv1YD1yoPT0CiQmJgisCfU2IiPGnP0UNc0p9SswklgjWqfMeh2agwRLSSxa8appjYmXVCjl7FhqNMyzlWjnuxcgjrzYAxrbZ+DrphcJ5s8/ZxPRN53DQMmkmlup4/h/PQrg4OCs9Yg7/RlrynH5BMfnM2EkskB/gROU9HZSlVsW1t2dIXKetJQI98C7mBTLGhuhd9zBaYxvBWQKx7MKxes8w+AI9ImDAzQnrHLkNzizJisnu7e5rrgWnFuWD/IQbvZhECmssq5MRz1n2YUCx0uWS1hRaCzUKCm72bh0sTLKDGrFmIff+fqxsuWkzY55Bw6N2T/To3/NShHslwjhnQL5adkknKbN9RdZCmaRF/sIfFAxPnoMMqWdH6BFvEIFqC90moilk5vqZfKrEv1QqAtivR7IS1FLMxwX80iuzQQtBOwOeSSEDaOOHie8Nzpu0KNZ44fR86GKJuegRLC0+hTIZ9FSScO7sZx0Gj5woQgN1hwRNwspqCI6jneK6uOJRlJAdWGhZC3EM9cgleN grxHdiVR MNqVopATg6lqmlCl9ruSEw4KtsVsuJm2KStbBHWtJV4dSy3UvaDLqmBQ2xli67fZPHqbN+Jysimg1I4cKn9FeMPM2KLr8vSn/MoC25QaSH3MGKXd5vKwXnyie+2A8b86OenPmAYBDhRsetOFqpVyo1cJw1qkcG0GDA9Hu3qGhks3EDvOEC9gP2xGMxmz3mVRzU7Qc/y79Wsq8SIaj3FDea6awrLd7z9SvmlTM9qTCaiXxch/LW0ruvM4w/VONNoDthRQGGoIkuExWgv1av6zlkYs45/vYIw2fopB2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 29, 2024 at 01:42:12PM +0100, David Hildenbrand wrote: > > > static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > > void *arg, const unsigned long table_end) > > { > > @@ -545,6 +569,15 @@ int __init acpi_numa_init(void) > > * Initialize a fake_pxm as the first available PXM to emulate. > > */ > > + /* Align memblock size to CFMW regions if possible */ > > + acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL); > > + > > + /* > > + * Nodes start populating with blocks after this, so probe the max > > + * block size to prevent it from changing in the future. > > + */ > > + memory_block_probe_max_size(); > > + > > This looks odd. Why shouldn't we allow someone else to suggest/advise an > even smaller "max size" ? I'd drop that. > Ah, my reading of the numa_add_memblk path was mistaken. I thought the hotplug blocks would start being created immediately after this in the acpi_parse_cfmws path - but memblk != memory_block x_x. Will drop along with other recommended updates and submit v4. ~Gregory