From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AD5D64077 for ; Fri, 8 Nov 2024 18:46:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB846B00C5; Fri, 8 Nov 2024 13:46:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5A716B00CB; Fri, 8 Nov 2024 13:46:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A06BB6B00D9; Fri, 8 Nov 2024 13:46:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B8AF6B00C5 for ; Fri, 8 Nov 2024 13:46:54 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F36EF140F5C for ; Fri, 8 Nov 2024 18:46:53 +0000 (UTC) X-FDA: 82763808414.23.CD260E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id B8F2F1C0018 for ; Fri, 8 Nov 2024 18:45:41 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BUFkmd7u; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731091424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5PxtQy4+9CaX5UcMUWUwd0ZmKQR4r1a+EWCdYpyGruM=; b=s0u+GS7SLhSdXiNGuYF+MEyTgisVnvxexhraWLQmdT4OE5w3Ru4/coCJbvQ6B7nnpTI5G1 vdBENGK5OZOmKaWXVX4ilcRD92XcX/N6V8zWyniDeiSmlTQd2dX5kQstudhp59Xj3e63l1 Z9xvQvEX1/zIPCIs3M+bK3heYjaULbs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BUFkmd7u; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731091424; a=rsa-sha256; cv=none; b=GdXbqniN4e7Co/4BYjqZaIUYxpR5u0RGFD5qwzUi6sN6L/aTZ0IBYOQ5setszJIxVgth+Q DOvohS4FYQXk7uQyR+LUNMWCfWWwKjHb6duFlzY3/J4zQLpGrvCzywLpuZ9JmXIqW9/bgP IvgYCNlW4xD5Zs/DsNgoz87n61cGiks= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5PxtQy4+9CaX5UcMUWUwd0ZmKQR4r1a+EWCdYpyGruM=; b=BUFkmd7ux9lTNXQFCRiwXQN4S8 GU/GcvgkKqQzPXEnLiY4ziB6utj2JFxJAvFZRikrt4ECfX2C88vA5tULvQCfxNhvYRaprMgFjZAwy dtmin/sK6L9vitiSITimF3jIwEeBJqM4XPJy1+5oshRTmGXrTtklMutXbQncsWt4c22dawYh0whfs v4KT3uiFs67h7+CNbp4TNARHWzeiVQFZurXvL05qRu7gI48rqYtZb2PyQO+anLZB5BoUbvWKsJZoB FF8AQRHzvlsVAPEycm98fX9mTqJHxyAY5rwIOzeVKsdXfzhyIp1dA005y/Lru4sCxXABAcgwmmuSK 8daaCsVg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t9U0P-00000009BoK-2DOQ; Fri, 08 Nov 2024 18:46:49 +0000 Date: Fri, 8 Nov 2024 18:46:49 +0000 From: Matthew Wilcox To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] iomap: make buffered writes work with RWF_UNCACHED Message-ID: References: <20241108174505.1214230-1-axboe@kernel.dk> <20241108174505.1214230-12-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108174505.1214230-12-axboe@kernel.dk> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B8F2F1C0018 X-Stat-Signature: dihppim8gi1s3pr7me367ruswbha4c5s X-Rspam-User: X-HE-Tag: 1731091541-547726 X-HE-Meta: U2FsdGVkX1/rG+SqdAyCBiAfXEeHrobF7ymz8FBKy9+t3+CH+ifXCmplFTYC41OHPUFuOLMu8oghW2ETaGt/Vt3wRJN4NLHnH4qnif+CbeTyulv4r8BCd472fmzFxZbylZ1Lv+HTjqIpdH2aEfXyrh1GGrltmYgpbg7HEBjadU4lnH+gujfPwxK2yIV3ECYukD7rgpnUtO0Q4FvBw9g/WFAJlMUeKz5WFBtQDRggptmWtnyZR0dhr2O3vkuC0pcEdY4BZhGICQXwRct87Sj2Uj0gVVzDCRoAo9qXQlMWFmk0EpW3q1+W+tJWLMcR7GwXqlvQNl3TK25A1SV1hye8mmjO7UVm6L467cW28/vIoxF9d5xLMKnSHzqkCjjM81bFobelOVgbI74xDPum1oH1I1S/cWFTDAGhj6nGgq2TcLgOzBIM4HD8GOWcLKwayomQKggzjsd2Ro0SgnK3tO1Lr5IT2RdIovukE85Zds213OAWNvvw29s7F78oploFHryLoNahs7FB6L5FRPZxJJNQHqa9jNq/bW6ye3v8xwHKeqyL6dEYwj4/LcebM6QMti3ACkuwTY9aNRBzM4X/hfXWT2rezh88m9j3h/8T8KP7WYxixUGIEcH+wsnPlq7YQRQvDcSR4W0hYatkxGN2wI8bjk4tZUN1QY066l0bvmJIFvwapLQcvrdFtQ1Fkazf/chCdcD/TjJ0F6eqAooaO/JHKJEviupjh5ZQQGiXhMDVAtVdAdyKirrHRd0TUnkECNTRybK/dC7UJ3aPljboEIKqt97nurpvCZ4lEUpzVj5WD68xu9AJvU5UODpb8a31rT1XoysaA1LPwRQ9XrnhX7T3+pWaucyCFPNbkew9GB9G2kpI+3KZ/LJ1Xcf70J7M88GDjL3J2YSqMTh3s3JyI5R4IspThPqLKHaUQ4I4KChqCgK9Ithk+1KxzuQeLykv6yTRN0R95iIuBLzUWy+DbMs GlALHxzp kx1L/fkfox2+ToOnR0bpUuMCWUHnMPjBID7bEOmjXXvSaZZjBRe24y5lUrda5depVGvGPqDwZ1zUIKgmcsprItiuBspkZertnJCxCe+X7Oe5+mY+UIaTB4yKTihy4yG28yXaflRpU2SLczuL8ouF18WVP+Zs7IGQvmRdl01/s2Rox0RVAumL0I9zIBYgGMnCh20bCOzJkG92zpv2SU5LRTfaooNOrlONfKUY1p6RuSIUaBi0KfGR+XxVT1OZdaeI5m0TFGAfCzJGLxwLa5Jb46E3GMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 10:43:34AM -0700, Jens Axboe wrote: > +++ b/fs/iomap/buffered-io.c > @@ -959,6 +959,8 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i) > } > if (iter->iomap.flags & IOMAP_F_STALE) > break; > + if (iter->flags & IOMAP_UNCACHED) > + folio_set_uncached(folio); This seems like it'd convert an existing page cache folio into being uncached? Is this just leftover from a previous version or is that a design decision you made?