From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC11D64074 for ; Fri, 8 Nov 2024 18:21:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48EA46B00CF; Fri, 8 Nov 2024 13:21:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C9B6B00D0; Fri, 8 Nov 2024 13:21:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 305456B00D2; Fri, 8 Nov 2024 13:21:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 10A266B00CF for ; Fri, 8 Nov 2024 13:21:15 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BACDD40E6A for ; Fri, 8 Nov 2024 18:21:14 +0000 (UTC) X-FDA: 82763742852.09.322D9F4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id ED7BB1C000A for ; Fri, 8 Nov 2024 18:20:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TrbFCdKU; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731089934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qxYJJL9dEeR02JTSTOG4LkzvZWHrplSeeTctfqCEs4w=; b=8aVxp6tBYzPuqphtUjYz7p535b2AdOXKNVWdv0pXy/U3BbMbX2ixM8F3i3f3mRmwCjKkhR WvaqGN0OUiaEcNwB6N2pipLLSZyxnd+B/9K8abJYtw+v4SPmQKc/oMWEq7sMVRvgesU/0Z T1aoKgJooNAG8Gf0PCewoyfGEFDNYDo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731089934; a=rsa-sha256; cv=none; b=ES57w8BLYrQzqAGR3ACoBwE2dpUb+AK7F7B6WR90KObG3t1xpoFYJtqr4BWYxVm/j36Q9D YUYN6uxtiY/Hh9HrFNDLmq13ScFcBwFPAD+mpDHl5d/skuoffmSBwH2quIDPHhEWL05MnX yS/tbMlNH4x64vigaZT2FIxBI8OuZiw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TrbFCdKU; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qxYJJL9dEeR02JTSTOG4LkzvZWHrplSeeTctfqCEs4w=; b=TrbFCdKUxOYPxUvJcON7wLb/E4 2d7e7bE7FKrNVQDQd4sUdynyemW3KMe0F7cZFTIK/B7dAZnkd7Nts7NNhuhK5SHkO0uCj59/eWa+a Nm3kWmRho06zCAv934LSglP7vDbXiNEsDfHL3S9LUpVfsXUXD0jBd5tonkchmqjeGFfXNpymBZaX/ E/PKuhUENNIETKhWQMN21YHW8YIDbw/1Nf2q0exNbq55AiP+bny/ni75cVQr6OpjLyFqfmb3tOwEL tdx7/hzojSxwH5d0pqiaA64xb0tlsSpdX/jxk9Q5zT1JAXxXi7BWfbqPlyZrDfOxY/RvS6d/mo22Q pMs/D2Ww==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t9Tbb-00000009AVT-1mFZ; Fri, 08 Nov 2024 18:21:11 +0000 Date: Fri, 8 Nov 2024 18:21:11 +0000 From: Matthew Wilcox To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/13] mm/readahead: add readahead_control->uncached member Message-ID: References: <20241108174505.1214230-1-axboe@kernel.dk> <20241108174505.1214230-5-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108174505.1214230-5-axboe@kernel.dk> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED7BB1C000A X-Stat-Signature: 8ws8m149ytm5eaimd7io1uhqd93uwxhg X-HE-Tag: 1731090026-152241 X-HE-Meta: U2FsdGVkX18C9tst88QL79W1oliEKsYNFtguT7kx/m/4YdsN2/Wk7oj1n+qrbZ6FfgoVZf9YdJTL+u9JElMqaptsGR+iuGykaLozObu5cawmb9EEcp43hTtnqqITOSbzvFYeQaS9lCXXij5JBnsOyvnQ4UoEF0fMJ02YGapRIHOS+LkoJH1JhF6gk73Yu34rtRUfleP3qBjxUEHMMJH5nSmRu54Kr/IDKBCcdR54IIGha0tVbmle6Aj0y20ksXcJLDt0b47YpNp+53jcCUTyD6PBvGc7mPrOPyYaSbKItXFiuuMNxKPbUuGNOBgEgqS22LIWZmePmrp+Ri5/YQclmOyaKw7Osb+B5cWsK/KL+VHsqQSy9mQdlPdHYwHiL2fuj/Bk534MTh9EmchTMrWhZZ1LDxqdqPE5OGOBy178ZX/PrPvnAYi/rSs4rVM2o0K/MVUV1Wu2cGPAykC2Fsh01gDVJJzZzUqdw5T2iiP8I2wm0z4VZL7FIIsgMN8Lll+QyvMX8xTJL/aDRK4+rEWaDIO6v/bxaUS08BYG5zXKNh/S3PFtzJ6XJPjwIb5NhXSnNBalgMWV4/d7W8UJG9CHmc2UlrDE2pXEuSRkQeOrc/7ae6uWs0pGD/4uSR3gW07LbAMwCeTC0lvF5kt4M91lEhf8eosKq3SYs+Hn3Wm0Ty5Umao73HX2aRjx3gdS7Gqae0aCVEW7YrwBjePBsnFsD2J8cNE90oP7W4haNm8fBAMvtg4jMBm6wTVm7S+msSbui3Q/kyGUGnByYl6YIEWs2gd2HfPWVjQJ5w6MA6cuqrJKx5KOOq4OHqLLqQvIbw0j7Z97klFR108auszOjpJFGW4E56cyOsCCtD8AOAjn8NgvzogKB6bVeXy6+cdNIc3WrxJORyZiWT+pzTfVPQoqpX9AvjLZ+G5eMtFHufRlgkGyqOXiT5PijwhnllIVcnNkPvN7XIae2lTRj4kQF2z 51AZvpkJ owo2NeQSU0a36yQetjbur9IoJhZs4WIeeNq2vSiOKLpXbd2H7dLIGD669lpat/FYi15XzuvxdVeTxQj7h0fO50e5JtPtKz0241mpVGJ+Zo4vPnWcu6vZRDUzMbuVuMDhaMeRknv8iDXAh6OQzX3zLKo+/ga/b82YXd6OGpJAlFEnk5HjbwgrDA7gJwg2E9sL3fty3f2CJEcyfrgCdtnD1f2noWw5/EwJSaLQLeKs/SseksWqFfKpXIa1mq5QMPzUSuGmuDr7FeFOXC1QwKCjVBKeAlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 10:43:27AM -0700, Jens Axboe wrote: > +++ b/mm/readahead.c > @@ -191,7 +191,13 @@ static void read_pages(struct readahead_control *rac) > static struct folio *ractl_alloc_folio(struct readahead_control *ractl, > gfp_t gfp_mask, unsigned int order) > { > - return filemap_alloc_folio(gfp_mask, order); > + struct folio *folio; > + > + folio = filemap_alloc_folio(gfp_mask, order); > + if (folio && ractl->uncached) > + folio_set_uncached(folio); If we've just allocated it, it should be safe to use __folio_set_uncached() here, no? Not that I'm keen on using a folio flag here, but I'm reserving judgement on that unti I've got further through this series and see how it's used. I can see that it might be necessary.