From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC986D64074 for ; Fri, 8 Nov 2024 18:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48AEE6B00D1; Fri, 8 Nov 2024 13:18:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B2B6B00D2; Fri, 8 Nov 2024 13:18:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23E506B00D3; Fri, 8 Nov 2024 13:18:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F28EA6B00D1 for ; Fri, 8 Nov 2024 13:18:35 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A17FBC0945 for ; Fri, 8 Nov 2024 18:18:35 +0000 (UTC) X-FDA: 82763736552.19.BE08C05 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 6FB89120026 for ; Fri, 8 Nov 2024 18:17:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="LhtkU6/e"; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731089745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LP4RAM0qR/ytuVuwTD7htBAHrnyPxX123oRj1JPz/OQ=; b=bbe/XkXcrUQ4eVYzHnJmuat8015v+IKyr5LaDlY2TZt9S/+mIex1J1+ono/1++5Jg6G+cM 0mJU/a1wvU63KhV6rBvLY6/ineSMFPiaLrrxs0CUrnzoyHfa/oR4+iwryjj9wOaCdvACyl nVPjdo3ROHV5nyROMoPSbm+NIdd8HAo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="LhtkU6/e"; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731089745; a=rsa-sha256; cv=none; b=Qclx+SDVumsyrsjSev8zcSZyrjrHTqBqVmNINKXU8eTUE2xy1oAGyPEXUHb+Tw4twHRgIG cOoKKNtJLkB6qzF0dk4G3C0XqRBT7nPrDOR5A0TrmAL/3x9j1jIkPLwA1hgZFzMgy7ZQ84 jXIs1f/mdfY1p9KcDKdl59MbPwymSHo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LP4RAM0qR/ytuVuwTD7htBAHrnyPxX123oRj1JPz/OQ=; b=LhtkU6/ekHvmRvAnCjsFNmAeLw tpI/kQn+9L/nuY21XAz2GguZcDU0OOeqFqYKS+jUJG3xnEK9nuK+7zvl3qvadqG5xwuMRMtdlxPrL 1iJ5WFPtupZs77x2nRrZN3yfujegpl1MVEzUmuLT00+ZiJU6Y4TckgnJjrexEqp3Ag6MVc0c+6a92 myGNfqEkVJfM5ilwS7LrVgFvreH5nU6R0k2IVSmfTnZW2wxPdoJa7XRa7Hp/DyB/81HyJn4AKbPBm BWt3dAWooJfCckcXYKRLy7op8xLmvcGsGE0b6BvQfqNUEFmFWEuqAJw19/9SQYwhVwwYzobj904pn BUytuv1A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t9TYz-00000009AMP-2qiG; Fri, 08 Nov 2024 18:18:29 +0000 Date: Fri, 8 Nov 2024 18:18:29 +0000 From: Matthew Wilcox To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/13] mm/filemap: change filemap_create_folio() to take a struct kiocb Message-ID: References: <20241108174505.1214230-1-axboe@kernel.dk> <20241108174505.1214230-2-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108174505.1214230-2-axboe@kernel.dk> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6FB89120026 X-Stat-Signature: srfzyrkh8qdbecwemks9ofxkcusqfjx7 X-Rspam-User: X-HE-Tag: 1731089863-530454 X-HE-Meta: U2FsdGVkX1+m65157RYbupOkfVRkjrWTTfnhdvQJKjGFyC/JjJTBs1IYNiVDNFIAqKyWckZkfIVsScTw+2b31C+oApiMW3odNFzanQ8srgcDtOzispJhw1ZpIce+5RcSsU4h5sybk0HwyaCv0c/wbXRmCAI1iXmm5RT5GIk9bhDpxkh/+ONAjue8uLwNfbEevyU2SM/cvrht7r9i1HzBtQHaD/j8GH2zdiD57bv3TZkPYGXdhIlRSo5oh5blr6wCVH/TIOWu2kW9+lqzXNLC/Y0it1mUGe3D4RmeA6/XYs1kFPeSErz2yG+u418leKptOfIf/ggFDzuya1ZBR47Ocgi59B/fmqqNFrdoAoTQV1gYteC26nbVm4AsbLjqNEA49l5a7MTn+e08+92ia+t4fhdvZCQ7uzjtMSpmM9H6024aRZhg/kBM7yHNfCU/2/E88vZwM71nGfMVA4ofeu1QipUOX+D1l8KXINPcJkJGtoV1U5O7mBeqvbU8EimxO1zZ+kklV2TzMumk5nMFilmTqpX+dq0rTtD7GgOXZYTr2GJ5xkGhQGyVdNeQ/O1KuFd3rHX6eDBlsw3QQqb8gTznhf7M8BEAMvINM5F/GrpICsv/m1UYRlLDUXKGEXWFGUbd7n+8Mq+9z+ImHuvqrUvMPA6AXI/ndextxSeqV/DBQYHoxxzW9kkTl+9T3Pzl8WojPls8M8aYSMzGxZXt5Hssvf7YXdYMTgzmjexJL8ETPx12IWgxcxvVovM/y51Mgx4nk/fVbrtYO+vPgeS1vt7r2jCCr3aqyxj2EdUDzYOGSeg+1T6p4CMdCi0bExjkrHrieggJ7iI2IAUrV1U83WibcnyqBIlrmc0jvlJfjK9AaSQLdZgljrLHEZkdi+dDuD6fEKFHYmvV95LYsrW3jshKXLgl+bqxuuwZb1WJDHlkx/3MdRiGdUPBF9czELE6WgslHrALVPGj2dzd7B92O/F yM6sWHU4 AotUn+9Aof3Bm/UrLTMFLMJ7e1xZ+6FK1oNAfT6BvREjQSRIZnlJk0euu+M6a3C0zVNp2Ew6NF0R0Qk2gQiaN2+gOHwy9vWwVLp3zrtv6GxGk2q1kMOvLh81A+oROUNvAAgWpxHD77t0jB0VHftIobdJys2KFl91lvRPPiycSfhsmrnNN+k/DHnyiZiQggTLs2C/DRpRwAJ7EwmWhLaj2S6z45FL1ltbRzoDmaksuGuJ5D1RsPhzpyWCcQRVnEbmIbJE5KnRO6LmclPO8zkxCSZI2fA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006758, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 10:43:24AM -0700, Jens Axboe wrote: > Rather than pass in both the file and position directly from the kiocb, > just take a struct kiocb instead. In preparation for actually needing > the kiocb in the function. If you're undoing this part of f253e1854ce8, it's probably worth moving the IOCB flag checks back to where they were too.