From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E07D64074 for ; Fri, 8 Nov 2024 17:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C466B900007; Fri, 8 Nov 2024 12:46:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF53F8D0001; Fri, 8 Nov 2024 12:46:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A46F7900007; Fri, 8 Nov 2024 12:46:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7E3998D0001 for ; Fri, 8 Nov 2024 12:46:13 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39171A0EF0 for ; Fri, 8 Nov 2024 17:46:13 +0000 (UTC) X-FDA: 82763656248.14.C53EA50 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf20.hostedemail.com (Postfix) with ESMTP id DB6FA1C0012 for ; Fri, 8 Nov 2024 17:45:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IytxagMe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731087910; a=rsa-sha256; cv=none; b=cTVtpfOAv71zTUn8eJ+QakguxkBGqVuAsEmz5bBGWOkMO+7vEqBVuD9T2l+OTEOAr7bES5 HkEq/DeFkBtxXU2Np+M1SLcxGfLYpytVnK04yhHIbcAdQUViIHraGjilSN78YqYZkAGeJg G/kl2UuntjUELTi8LHYAjzlam9fEKV8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IytxagMe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731087910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HigXSvE1YCLW2Udt6TV+7TWMr4D2/j3S3P0/mBJY7SM=; b=M0oG7h6HM9oBfspbuv1s6pP1gGg9tIZT05SlHFycnvvoglL9thwR1KTL995CJJfpPyoKjJ nGZ0SsNnk8Avyh7G+tdufaSxTAOS4ZE+8WTVd2eoO8blWsn3RO44zGpEwlKDICeLcFI4aM lTTnHKZJQIm9PAIRNtl4L4x1RnKzSHE= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-46098928354so15293701cf.1 for ; Fri, 08 Nov 2024 09:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731087970; x=1731692770; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=HigXSvE1YCLW2Udt6TV+7TWMr4D2/j3S3P0/mBJY7SM=; b=IytxagMe21FtWPno30qW+PnESKy9dQPd9W6ioh8DcTGRvOXuDbN58ZZX7/sr59hIfL Rq/XvvZgItnKcxX8aMlB7dl3NPQr0kti18G3h1W+TidxVnktR/GMtV3gu95NBpQtEEJ0 gWkdYGcEqLzg2mcTJKTCU7APYVGERpwDNwsM7lIffmeSDIqjZUzy32FBrUclZ4baRbGd zLYnWjWhwRCGXFdo+ZTLSS46w8OFfuSWEnPwg7/hjx24iVvpnx368BW8NMzKvEQZ/O9H QXdWxqQHpjrPKo2hwNtRe43DPfiFkTMscWw0/eMYaFkR+KN03NMIdRb7MVXT6wgJFPuq BlUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731087970; x=1731692770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HigXSvE1YCLW2Udt6TV+7TWMr4D2/j3S3P0/mBJY7SM=; b=Q0Vjz0KwNAq4cW20aesbcCSixdSqqqyQHDFF6sOQMLxl1+GdCt1+9335abY1kreZST Fuwp7eLpQDIVVAUT/q6Ek8kJBzGEnFZolFRKVQm/KlkDYlivbzPwHouAetblWjiOnT0B hbs1uevcRApSNi3bl1MUoXhy2SF1RjoKto5YYLm4VgfPMn6XYxT6nX8BKt7xW/k0KB5Z v3opOK3jmU/ZWJX3mw+xiBc7OnA/SnJrspkubM5t2LewhNjfiRChW7UAd/ocfHXhUZsC K0t3H4x+J+epjG4SGPHDpDvYbUdtul/4ehktj66KnXVO0zDy5GEuQJNfYKdslHf2ozs0 gLhQ== X-Forwarded-Encrypted: i=1; AJvYcCX23MXUbi7wFfiLNrNS41CsnpTrOQRQ7bxKr+7ij2EdmOcFXcMHDDmSbH79nmV+c/jMMmdrIXGanw==@kvack.org X-Gm-Message-State: AOJu0YyYB06NG1sm439ZsHvg0GiRjxW+NsgO7dByMPF6UbQ6AZQMuUJa Ny5FhRAgNMwo+yWeJmRi5MmuoJlA6YTU+cCuRj2w89imPUL65aj6 X-Google-Smtp-Source: AGHT+IFiBP7IMsW9bRbs55teJzmd+G0ctbT9JOfNQV45daiH2b6XIJeTIikI0hQpgjCCY2hjwuXK8w== X-Received: by 2002:a05:6214:5885:b0:6d1:9724:80fa with SMTP id 6a1803df08f44-6d39e1a53a0mr49322616d6.32.1731087970039; Fri, 08 Nov 2024 09:46:10 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d39620d14asm21687576d6.67.2024.11.08.09.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 09:46:09 -0800 (PST) Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfauth.phl.internal (Postfix) with ESMTP id E22AF1200043; Fri, 8 Nov 2024 12:46:08 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 08 Nov 2024 12:46:08 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeigddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtuden ucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrd gtohhmqeenucggtffrrghtthgvrhhnpeevheetffdvffetkeeuudeuudektdfghedtudfg hedvgfdtgedufffhudduhfejueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmh grihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepudejpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegsihhgvggrshihsehlihhnuhhtrhhonhhigi druggvpdhrtghpthhtohepkhgrshgrnhdquggvvhesghhoohhglhgvghhrohhuphhsrdgt ohhmpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrd horhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthht ohepphgruhhlmhgtkheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepvghlvhgvrhesgh hoohhglhgvrdgtohhmpdhrtghpthhtohepphgvthgvrhiisehinhhfrhgruggvrggurdho rhhgpdhrtghpthhtohepthhglhigsehlihhnuhhtrhhonhhigidruggvpdhrtghpthhtoh epvhgsrggskhgrsehsuhhsvgdrtgii X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Nov 2024 12:46:08 -0500 (EST) Date: Fri, 8 Nov 2024 09:46:07 -0800 From: Boqun Feng To: Sebastian Andrzej Siewior Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Paul E. McKenney" , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au Subject: Re: [PATCH v3 0/4] scftorture: Avoid kfree from IRQ context. Message-ID: References: <20241108104217.3759904-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20241108104217.3759904-1-bigeasy@linutronix.de> X-Rspam-User: X-Rspamd-Queue-Id: DB6FA1C0012 X-Rspamd-Server: rspam01 X-Stat-Signature: 1hfo8twa6pu9ng8r3kyd73cw7gb1a13x X-HE-Tag: 1731087924-599474 X-HE-Meta: U2FsdGVkX18QJNGV9p3bELjuHH3U50yWSJxamF9oDBH2+N5q0t3AZR9xt7KQFEyZDIw4CqPs4MhfdXD7DJcNMXVluHSAqHvcVO6JUXxq7DMHCIP4v6kzq58bjMFChFvX+LQH0xbhXOIfrWki+UwkJrpMGqF//JTmbj8MIf4heYdx38ae6gjGkUdo8ir12Tx8Czs3VFYtvAsZvFJXZDG1kB5YJLuKDwDDdWrLqlgQ+6gVrEySkGOy/f5gAT40EKUoXIQ22+8C5qJ0tml+W5sugddNRRtO2D82EP7xxrRpP6i+WFqqFfClVlD9/HnQoJDxwexaDnnyRNt0k662O2Qga7yA/DPkqKYT9EpqkOM+mdx71o/Xki9SJNH73G5+aHxxiPIFF8HnkIBgo6kUK49vXwllEg9p19uhXavRVA7MadqnpWcoiTcEz04hbjF5YqsPGtNcN3THAX/20lM0Xza0JHEkUHto7n9llb0ayb7989AMaCjTqAY3OvayREDpLd2ZFsz9auX2ZtkikgXVocnw/3wbNzl5j3sdqYN7kU0nS4d4Y0aNKDc104AasDJVkQHJiFEYyXQw8TZrNWDZdc7X7o0vVTQkAowIMnlIRPCJbCHsDMrtvklb5zZ3Paz9vDiYql0HaLwZBkje115XnJ2s/RXezLyzTv7/qNAiK5GGOzG80/oorfQeV55WIdMMDlsn260SNlC5QtVGFcdn/nSTb/n3lcAyIWxK0aDv1UZxdnsx0VCJHmZpmyg4JhgirjyZtFrtIvnCPGz4JRx/kQwwaHT71T+ZUI08V1V79q4+08ZatSkAqj5YUT7X5i8SU49Nq49hhN3DBZ7qMzsq9zNcX0sBnWAtP7PRdImSfzYBMp9Uz/2pVpcYXJRu50NtYxvsi8E4zecXl2EE1gpqFS2SwIRWm5f5Rb9J6oYsfaKPyPns/I9n2gpBiWJExHa4lFyy//xbE4cqZYZmsVWtyyq RA/zn6qt F99VmBW+WYB4impPmvM9u8LsBcXFPXGSqSLgJn3Cp4uyTDhbqKlNnDqSmDkIJ1N0NYe911XfT7IH/FSbQllWq5PPQLKjPaYT94jY7g1QtOqXMBjSQsxGeuic3jBpTHjYeDdfLKhphtL3mB4cT+DT+TJsjtEqQKYMA0z61tGTUANLAboXuabMiYgI1LcUETqtJtJY0E1FF9htg0qJHRbKN4yBTe6prfOg3khCFFB0ciUUkrUIj1wZJMWLEe5zM4H0gNnwZK5V3YQ0ySUACfyauyTl+T7I3BN7p//zzJqtQ4R7VjI7PPF9eXWCOdl80sSc3qzscAaGq9xbue4rCDVM1oxlqk6srhg32hes8McMU0gD8ixnHjF2m/69JnCTx6styYGkzkgAD051LT7PMgMI/gV0WCOYi1eeuzt8e0JwG0F6wj1e0+mThwkZjsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001614, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 11:39:30AM +0100, Sebastian Andrzej Siewior wrote: > Hi, > > Paul reported kfree from IRQ context in scftorture which is noticed by > lockdep since the recent PROVE_RAW_LOCK_NESTING switch. > > The last patch in this series adresses the issues, the other things > happened on the way. > > v2...v3: > - The clean up on module exit must not be done with thread numbers. > Reported by Boqun Feng. > - Move the clean up on module exit prior to torture_cleanup_end(). > Reported by Paul. > > v1...v2: > - Remove kfree_bulk(). I get more invocations per report without it. > - Pass `cpu' to scf_cleanup_free_list in scftorture_invoker() instead > of scfp->cpu. The latter is the thread number which can be larger > than the number CPUs leading to a crash in such a case. Reported by > Boqun Feng. > - Clean up the per-CPU lists on module exit. Reported by Boqun Feng. > > Sebastian > For the whole series: Reviewed-by: Boqun Feng Tested-by: Boqun Feng Regards, Boqun