From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B5ED5C0DD for ; Fri, 8 Nov 2024 14:56:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AEF66B0098; Fri, 8 Nov 2024 09:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85E596B0099; Fri, 8 Nov 2024 09:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 774226B009A; Fri, 8 Nov 2024 09:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 59CFF6B0098 for ; Fri, 8 Nov 2024 09:56:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70DA8140D00 for ; Fri, 8 Nov 2024 14:56:46 +0000 (UTC) X-FDA: 82763228436.21.AD29907 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 6CA3FA0008 for ; Fri, 8 Nov 2024 14:56:06 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4DYkiTbJ; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+8cffc468e64dd8f439c5+7747+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cffc468e64dd8f439c5+7747+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731077744; a=rsa-sha256; cv=none; b=yOQLYddpqNJe6vp3X4EfrLmhv+P646mYC0f2sp4UudGUcSBMAJ/HEh0ZdlsB1vjJCyWDW0 8A8CwMAriB4A6eLvcqboQXqT0GHEdXYMjqZCpq3kKLlj6v9LwjUFBkUuOvATJrzzgI19Ut OcFkHwlKzDd4qpYSOwoWQZfznm0JC0M= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4DYkiTbJ; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+8cffc468e64dd8f439c5+7747+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cffc468e64dd8f439c5+7747+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731077744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z581WTidmOvp9xGspH41e/CE3NjTQFo7u02mmWOTdmM=; b=njq/TWVD/5dQZSosl67NE7l5Eeeb7uP2UH9bVC4bIbYwZdH385j9KNnAHcUX5ZSeKXGvdW fs7IJqsftNCn9kzeMDJI/fA6CeBkDEhVmXNHjAu+/UC4C+hnChpx8sKqVF9d0LkI1W9SJB PK5a/1hLKgQ49oHzVqvBfJrjpK4qIlM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z581WTidmOvp9xGspH41e/CE3NjTQFo7u02mmWOTdmM=; b=4DYkiTbJEH1U/mFI7iqA3ZbRxQ yHaZ74VbgEW33dnUy31i9RCRevzijgdBscQZIOLwzxebX7tuz3gQTOkr1ooLTNVi/O9vx94b29og0 5CJuMjzjeEwC2CPiTCNneIQRMKRpBn62gVKvCcOpZA8H2XitG/MPyCldG88X6klRrXh3ausyopBHk p2Cbxt85NwzW+hX4SruCKbnTqvdo09qyVKT8qiEZlBHVaBMKAt1tq+V3y/qG8mFEBqAQbavdw0Rux 7AKWNe1qWqovoTmgqAZl3BX07ChvEQDr/TnJWEC0Uvi0C2N5FM80hRIrTT+UT2pvfGSQJL201QaJF yc7SSyDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t9QPb-0000000AvWp-3IF4; Fri, 08 Nov 2024 14:56:35 +0000 Date: Fri, 8 Nov 2024 06:56:35 -0800 From: Christoph Hellwig To: Vlastimil Babka Cc: Mikulas Patocka , Dave Chinner , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Christoph Hellwig , Pedro Falcato , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , zkabelac@redhat.com, Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists Message-ID: References: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> <5a1e67c3-481e-4c6e-8507-5a8ea0bd9f28@suse.cz> <27ba7473-9255-2407-8e4e-e5c3cafc25c4@redhat.com> <58fce0d4-9074-3d98-5a1b-970371f0c23c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 6CA3FA0008 X-Rspamd-Server: rspam11 X-Stat-Signature: dhr5y5uiy3w7tdheiify7emj4i8u7se1 X-HE-Tag: 1731077766-590214 X-HE-Meta: U2FsdGVkX1+NzjVHqRsEl8wAnfo1/tWcNcMiIJJVFQi8R6erA1Pr4/QgZwpdC1CldZQB6Bpwe7pPKGobdIwsVWsHVFZPxjhOJOU3vKFktH90EzaRBTVHN2dk2kCU/Y45gMajN0m5QmRGjH7tv4F+nh8iLsbTajIlLQOep00GOOEk6NqiZXdmgPXRQbCSOSJQFQSKhbfxVirGdrsTAG/EjbXm5HvSmV152v02BWgKW1li/t9wwAfIEi2YwqtadmTZtGU00pW4OYKpVPzYClAfWlx1VcwU59G/dVwrO35mUJJ3jI3S0wuKzOn7Niy2feAveoCtgY+P6d8GTesnoGkPXUlJmiu6lTN+FnwXbQiCiN8S5pfCzuqtteQIIUyFsIfywYwLEuhCaaIsp8aT7aeY8DHgwD+9fuAuousjzSAxaFKOIHSTkvy//37Zpkz4HZvggphfAz00pvYKkcMgMgn9CWSSwYkOfG8FlUuy6keqxtZrvRzSHUabXOKoazPUbzv7JqcABDV72R161grrNEHSJtcueASVC/YAij8oC8cOhjoDjulvUII1WaIP0tgLVVMj5kDGYozqNJ5IFwjPAHsXG1O3inLRckZLrHL1h9o9MGn/y/K7n7oeRaqLSeaUp1bqMUSPIGT2OuFtS0DIE0B96Hg/7lkr3JKa9scpQK81DsP26IZoc1GDfAbz6vq9NmwkSgvFkAmcoCeyn9p02lF3AfZfBDZLQmD/9pMaWla3Gp4GEdVYLuCdBTM9nb/CIKCT5fET+zY1hQPe93tdPeJIX2IN1AaOLdxMXrNyAvtGeJbgRVXhkdrKpTj+s68FTRCqrkztXNzJXz3cLHrImuc2yeJZjDPGZGvdGYFJ2O0mdY3kkWblu4j8ZYdANM/IVJApbXnXcCBdQdczUa7vq5oetQEpQBQiFHiRIEy9J9Nz2f6bLBi5OzkibRyp6sFXQeu+P+QAYnzTQkQRPHeweNu f9lTbZyH EWOH/GrOHB3MonRk9/mbz6HgQKhm4qH6jS0P3LJ8rDU9nfiKMKhB1GR8qzv7jQXZECnFYoLxyY449j8nIOCkzt5SXcefCXR8K8xe8/zSaw3NLcUFr05Nm3O++/1Q5y5gRUZ/+z8K2WkKdu0DCPUvM6sE+jz3zHH3S5fBY0fYrzTxzNsk+eMA6EEeEpZtvYy1Q6T22AMIog6dFBSAH8wvblLQQ/KxM8MlV7RnDo3JUpsA/XOw0fd7jXKNeePK7q2AntH4fx4AlNrtjKAxIw/0jOexM4IQ9BEIc3d59FnPYVxFV5V5XPfpz64meVBgiaSo7vkE3PsMGAzfZMJ6k7ryvX8Zq9e2F5VYZfqLgnRma8sM0kpOjEQBCVnGw7hk5YOLrCIrTBd+rcnibOJc4RzJn8PVLBjy0pKsyCHcgPX2tZM2dSReQeUCeYNbKYEkNEIvVduhCl8HWEHgHAAqsU6bXvvqMF9+XlXnbeKk6O/HJiXwoc45VV1ix65B65TjD6tHyFRh2F0YVyn6vWZuj/2cMsVcYo8C/6iu+NHZM85tTj2jY5fwAvECbDmn4vfQydNVI7ONy9x82ml8GfBvCitlZH0We5Z7FVfdjiBei4r+CvUGFHiPSz45yDyMQ3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 11:08:40AM +0100, Vlastimil Babka wrote: > Right, IIRC xfs was one of the usecases that prompted us towards defining > the kmalloc alignment guarantees, which was around 2019. > So today, kmalloc() allocations will not cross a page boundary if the > requested size is lower than page size, and it's a power-of-two value. Even > if SLUB debugging is enabled (before the alignment became guaranteed, it > would happen naturally, and only be violated by either using SLOB, or > enabling SLUB debugging). > xfs_buf_alloc_kmem() could be thus simplified. I'm not sure we'll want to fully trust future allocator changes, but maybe switching the fallback logic to an assert or WARN_ON might be wortwhile.