From: Christoph Hellwig <hch@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Dave Chinner <david@fromorbit.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Pedro Falcato <pedro.falcato@gmail.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
zkabelac@redhat.com, Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org
Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists
Date: Fri, 8 Nov 2024 06:56:35 -0800 [thread overview]
Message-ID: <Zy4mo1X41yQU2i3-@infradead.org> (raw)
In-Reply-To: <dae2f548-cc2d-42ac-9a01-7382958001a7@suse.cz>
On Fri, Nov 08, 2024 at 11:08:40AM +0100, Vlastimil Babka wrote:
> Right, IIRC xfs was one of the usecases that prompted us towards defining
> the kmalloc alignment guarantees, which was around 2019.
> So today, kmalloc() allocations will not cross a page boundary if the
> requested size is lower than page size, and it's a power-of-two value. Even
> if SLUB debugging is enabled (before the alignment became guaranteed, it
> would happen naturally, and only be violated by either using SLOB, or
> enabling SLUB debugging).
> xfs_buf_alloc_kmem() could be thus simplified.
I'm not sure we'll want to fully trust future allocator changes, but
maybe switching the fallback logic to an assert or WARN_ON might be
wortwhile.
next prev parent reply other threads:[~2024-11-08 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 11:19 Mikulas Patocka
2024-11-06 11:34 ` Vlastimil Babka
2024-11-06 12:05 ` Mikulas Patocka
2024-11-06 16:28 ` Vlastimil Babka
2024-11-06 21:22 ` Mikulas Patocka
2024-11-08 9:56 ` Vlastimil Babka
2024-11-08 11:13 ` Hyeonggon Yoo
2024-11-08 11:21 ` Vlastimil Babka
2024-11-08 13:47 ` Pedro Falcato
2024-11-08 10:08 ` Vlastimil Babka
2024-11-08 14:56 ` Christoph Hellwig [this message]
2024-11-08 16:49 ` Yang Shi
2024-11-08 17:00 ` Vlastimil Babka
2024-11-08 17:43 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy4mo1X41yQU2i3-@infradead.org \
--to=hch@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=pedro.falcato@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox