From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8E6D5D699 for ; Fri, 8 Nov 2024 00:17:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66BD06B00B2; Thu, 7 Nov 2024 19:17:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 619FA6B00B3; Thu, 7 Nov 2024 19:17:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46DE16B00B4; Thu, 7 Nov 2024 19:17:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2643E6B00B2 for ; Thu, 7 Nov 2024 19:17:12 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C2369160647 for ; Fri, 8 Nov 2024 00:17:11 +0000 (UTC) X-FDA: 82761011256.01.09883A0 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf01.hostedemail.com (Postfix) with ESMTP id A455140002 for ; Fri, 8 Nov 2024 00:16:41 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZmPxJDaY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731024859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F+Do7zzo+KFbLuMYOM1790nmyhHrHI1nMAaNQb+68y4=; b=vUsAajUS407N7qF3RDLdyGe92JOGBSrpD21Qw7vV+MkijpQcuRLofKTcG0Sg9o2eigeQ2J MZgc6OytXR0bkR9KQf0arkcR+1FTm0bpmM94/K+b54LC5186790DrWi10+dM8tw78nYQE0 jH0v3vdzTCQGZADwQl/sbnelaBUsNek= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZmPxJDaY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731024859; a=rsa-sha256; cv=none; b=5rRWmBoySWR4Xw1mDYKKKqNXHi3y35OeOqgIRTQdVysK3srnmsh/NQasd/WnD3dbJYwccN KmnEOejautMj561pny/lNfK3PAkxq6Y/A2PbL1k3uawGk+ItB1RCGf2nYmg1KdO6HLIIIS nvk0kYPsQqiO4fSaOCZq3Qvl+c74IYk= Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2e91403950dso1227300a91.3 for ; Thu, 07 Nov 2024 16:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731025028; x=1731629828; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=F+Do7zzo+KFbLuMYOM1790nmyhHrHI1nMAaNQb+68y4=; b=ZmPxJDaYY+btbMcYfDvTm/Dz/vqM8/wDDPoG5bwAEd6uB36VUuQ7ULS3Ls28+FgRa/ SXIzTFo0+HmL0WR+XjMRB8o8Pq/G0PThV5pWM5pITLZreXLZKlXrT2NH/NCr86b1h8C2 vMsZal/aTl45fZLFc+tVHU7g+JH9cu3xcwUPUTgVzBzxL+xNqHogb0Su3sZy2b4IRKBU WWR31oIRH53kOsYvXCmdXH65c8/RjNpb3jvkXbDIrggR3cvfrA4wDAJXLO0lXLxo6LkQ PiySwdTmAbarMw3jhxZp1cjqK0c4Dzg1AOiuvIzn4e2gC//E7w4csRrqRNtZVkyl26m1 ACeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731025028; x=1731629828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F+Do7zzo+KFbLuMYOM1790nmyhHrHI1nMAaNQb+68y4=; b=u1syrd8mwmhlJeTL2RkTCypqtstaenpqGzTXO4zXGlFl/RuWA4oZS2Ub3hfA7BwP65 DHWvgqMs662pnwkwOofbh7e9XOfq1OlRzFP3ojpOJk6h64oDTxi/mx90+ljQAfUIMEar OspSQsPPL7qD2QYWEnZl1OJ1KnRnPRX1akBOh8Y99+xthgRqVgCAPXxgJFoZDOuuEwGk WkEsDW1YDx6wG2B+1q4QIfLHcdUMDhriY2qVdJ7Y8ZcdpL0qCrJi4IWaxoQh5SA6jom8 aags/0d7ib0q5lQOqGu4iqs7FuAcjFDuYJe64S7omp0mBUJNB2GsrD0KO+cqdqXbh0v5 xq0w== X-Forwarded-Encrypted: i=1; AJvYcCWvDOlRHTZyZP3xrItnt0JCTy0wYuPsdcFXU4nnYYLrepGkCOOtC0LRaG0uqHA/fopSsRpkVNBmrw==@kvack.org X-Gm-Message-State: AOJu0YwQQVW4ZI3VN4oYzBqzOLqLb4TRofXOBDmFpJFNY2f4i3E7n3Nj 9WbrQU+9U4G2sP8LFZoHRyznDagZUvXqJZbr+UsmRLGdP+X9bocq X-Google-Smtp-Source: AGHT+IHx1CO0T4w9TtTYGzXOtCQnF3M6HiVi4INvxoMblwadJozIaZRzoVFV6fbzFBdcXMIqlR4KGA== X-Received: by 2002:a17:90b:1f8e:b0:2e0:d957:1b9d with SMTP id 98e67ed59e1d1-2e9b17163cbmr1575389a91.13.1731025028446; Thu, 07 Nov 2024 16:17:08 -0800 (PST) Received: from fan ([2601:646:8f03:9fee:6ed1:b454:5fd2:3850]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e9a5fd180fsm2187666a91.33.2024.11.07.16.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 16:17:07 -0800 (PST) From: Fan Ni X-Google-Original-From: Fan Ni Date: Thu, 7 Nov 2024 16:17:03 -0800 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, gregkh@linuxfoundation.org, sudeep.holla@arm.com, jassisinghbrar@gmail.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v15 01/15] EDAC: Add support for EDAC device features control Message-ID: References: <20241101091735.1465-1-shiju.jose@huawei.com> <20241101091735.1465-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241101091735.1465-2-shiju.jose@huawei.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A455140002 X-Stat-Signature: 7kb7g948q1ghaqfqh83m9g6f85g949mq X-Rspam-User: X-HE-Tag: 1731025001-36714 X-HE-Meta: U2FsdGVkX1+xsuVugciZiKG3eeV4CE85MviKhJnyaubVb6OhIwY7297tzJD81bOUcS0/b/t0DCGBX4GspAVTF7hS55ObSNIufkIvwLQJ/koBEP+yimuYkmDb4vMelWBc64Q9SvVloXI7yIp1EFStI6974Tp4N9O7/iaQc/dwGrdwQi+ACFEsieKkf5Njzv5dDzgsCBUulijkbsirDTEk67cP/eLxCfMB7lMMtOJH/zmMW7VJLTMOJFgJw/v1OvV/7MEIQleOpmgSbfhvfpkwENCcFjvAUQ6PMkkkPhbLThkLLnv0I9K2H9zsnqnj2i/bTQWV1mEZc+Ho5DJCdwG/VOn04PKRm676T9rWKIU2NW6P6MtXTUhvC+TS18bGp5BrvfC3tuFr49pL9suOWxCG5em+Ku2UnvS9NdNiX4et/V/F4Ls4nrKK7zR1jIUkiIN6kmR2EVrovRa2K0pm49tQThbmS3o1opoOP06boR7dCuXo+y/F3aHTFyNTEW08ZH/pCJAaeGrqcbBu973BBHKpePEYKgdNfBLZkEB4RywcXPm6+hOz6N5RUdo/3SyztiMo2YVXO+iT5msT9S6FJE20Kyq4Kc5BJEXQuMmIRkSjHw6+hlneX4EI358D4GvS9yT2/OT2CALQ/MV0brRaz2qv6ve1OA8AnuZ3BRYsb7WxAfcYtdDac3WH6WYbtQ/YqYFJf+/fc3MS+n3L6XBeNexvgIat8y+OkhYA+PXCHbhhsqoDFp8tkjJcHAFm0WeytfTGwpM674HLztZGuME7WaNckqNHiEx//67SfRAyYD9ryfwW7V91u6EDeo43Hb2pPIFKk27+hHPVXfq3jl65ouTTRFfDqa0QzgI8/SUexUP96B3K23lMaqKdExjR5CKN6LO9ViIXorQn5WSsjGkfoNMrqhMbFD+ZhgRJzTDaq38t136j2A93xEWHfs7qebRygHrTl2X9zZ6+CLxL2tYjzPR 5mu1EJ7x lkcSw0NPzBF8J7rguzabYARw41taaJ3Pf8x/YtRkARiSLZAukAsJA+VGyLhKsxUa1vtAsoBSlOKkerD4vx4Dhn5IBBBLo4k/3qpRqcoIADUM8VvVDGOOmjdpLAWer176KgJVahrA6T1n0R3/xrNp9ogoqGkd1NmaF57uGOcA6qagtgsj1uCNbRQKG1RrrdYcBw9NrHUli+dnnACsH3wiE4qza5OdFupATTJKS9PtHsGHDuFgxA+xNwloe4ZqEA5F+7X3p+xfCf8iz4cR+8qr9Icnv+VLNkcxiXSuNCJcYmGFgV2qQ3GijURglfp0MhKsWhA3nZuG8vYIc+qI2k9MheQZk4YVvr37eh4Jva0yGGzwX/hAM58tkItUUpS0o/773JTMcADQJv/HUY1xOfSRwNqxu1vp2FiOzeUVqbC8KlCq56RPduIZxbQMEo3mZXqLth72uBDMu4lT4x7/UFsMZv7ol8gkElM5GmraZ6PAx0t6mbTNSxcnqBuf1M5r9cNqdLJtxsIdz9m6A00PGC7GLk8f3X3l7ZVYz83888JRdjXmcdD3CgV9HYl8Pdi0nUgmQ6ksxKsUXte4g5pGEXRK610Vj9hCde8b143WV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 01, 2024 at 09:17:19AM +0000, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add generic EDAC device feature controls supporting the registration > of RAS features available in the system. The driver exposes control > attributes for these features to userspace in > /sys/bus/edac/devices/// > > Co-developed-by: Jonathan Cameron > Signed-off-by: Jonathan Cameron > Signed-off-by: Shiju Jose > --- > drivers/edac/edac_device.c | 101 +++++++++++++++++++++++++++++++++++++ > include/linux/edac.h | 30 +++++++++++ > 2 files changed, 131 insertions(+) > > diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c > index 621dc2a5d034..e9229b5f8afe 100644 > --- a/drivers/edac/edac_device.c > +++ b/drivers/edac/edac_device.c > @@ -570,3 +570,104 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, > block ? block->name : "N/A", count, msg); > } > EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); > + > +/* EDAC device feature */ The comment is not very helpful to me, seems not quite relevant to what the function below does. Fan > +static void edac_dev_release(struct device *dev) > +{ > + struct edac_dev_feat_ctx *ctx = container_of(dev, struct edac_dev_feat_ctx, dev); > + > + kfree(ctx->dev.groups); > + kfree(ctx); > +} > + > +const struct device_type edac_dev_type = { > + .name = "edac_dev", > + .release = edac_dev_release, > +}; > + > +static void edac_dev_unreg(void *data) > +{ > + device_unregister(data); > +} > + > +/** > + * edac_dev_register - register device for RAS features with EDAC > + * @parent: parent device. > + * @name: parent device's name. > + * @private: parent driver's data to store in the context if any. > + * @num_features: number of RAS features to register. > + * @ras_features: list of RAS features to register. > + * > + * Return: > + * * %0 - Success. > + * * %-EINVAL - Invalid parameters passed. > + * * %-ENOMEM - Dynamic memory allocation failed. > + * > + */ > +int edac_dev_register(struct device *parent, char *name, > + void *private, int num_features, > + const struct edac_dev_feature *ras_features) > +{ > + const struct attribute_group **ras_attr_groups; > + struct edac_dev_feat_ctx *ctx; > + int attr_gcnt = 0; > + int ret, feat; > + > + if (!parent || !name || !num_features || !ras_features) > + return -EINVAL; > + > + /* Double parse to make space for attributes */ > + for (feat = 0; feat < num_features; feat++) { > + switch (ras_features[feat].ft_type) { > + /* Add feature specific code */ > + default: > + return -EINVAL; > + } > + } > + > + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); > + if (!ras_attr_groups) { > + ret = -ENOMEM; > + goto ctx_free; > + } > + > + attr_gcnt = 0; > + for (feat = 0; feat < num_features; feat++, ras_features++) { > + switch (ras_features->ft_type) { > + /* Add feature specific code */ > + default: > + ret = -EINVAL; > + goto groups_free; > + } > + } > + > + ctx->dev.parent = parent; > + ctx->dev.bus = edac_get_sysfs_subsys(); > + ctx->dev.type = &edac_dev_type; > + ctx->dev.groups = ras_attr_groups; > + ctx->private = private; > + dev_set_drvdata(&ctx->dev, ctx); > + > + ret = dev_set_name(&ctx->dev, name); > + if (ret) > + goto groups_free; > + > + ret = device_register(&ctx->dev); > + if (ret) { > + put_device(&ctx->dev); > + return ret; > + } > + > + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); > + > +groups_free: > + kfree(ras_attr_groups); > +ctx_free: > + kfree(ctx); > + return ret; > +} > +EXPORT_SYMBOL_GPL(edac_dev_register); > diff --git a/include/linux/edac.h b/include/linux/edac.h > index b4ee8961e623..e19706311ec0 100644 > --- a/include/linux/edac.h > +++ b/include/linux/edac.h > @@ -661,4 +661,34 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, > > return mci->dimms[index]; > } > + > +/* EDAC device features */ > + > +#define EDAC_FEAT_NAME_LEN 128 > + > +/* RAS feature type */ > +enum edac_dev_feat { > + RAS_FEAT_MAX > +}; > + > +/* EDAC device feature information structure */ > +struct edac_dev_data { > + u8 instance; > + void *private; > +}; > + > +struct edac_dev_feat_ctx { > + struct device dev; > + void *private; > +}; > + > +struct edac_dev_feature { > + enum edac_dev_feat ft_type; > + u8 instance; > + void *ctx; > +}; > + > +int edac_dev_register(struct device *parent, char *dev_name, > + void *parent_pvt_data, int num_features, > + const struct edac_dev_feature *ras_features); > #endif /* _LINUX_EDAC_H_ */ > -- > 2.34.1 > -- Fan Ni