From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302DCD0E3F3 for ; Thu, 24 Oct 2024 19:45:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A9E76B0083; Thu, 24 Oct 2024 15:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6328A6B0088; Thu, 24 Oct 2024 15:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACF46B008A; Thu, 24 Oct 2024 15:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C0306B0083 for ; Thu, 24 Oct 2024 15:45:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6F6B8ABFDB for ; Thu, 24 Oct 2024 19:45:18 +0000 (UTC) X-FDA: 82709525934.11.543EAF7 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf24.hostedemail.com (Postfix) with ESMTP id B8F0518001B for ; Thu, 24 Oct 2024 19:45:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Eu6mzOzo; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729799001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hPb8mKU+KzjeBNrDUNxSqXqnN5Ly29w8syBmz/sIRLU=; b=p2v7L9CtXXJNv/oQbFZin22DuiEeyqf5H9pAMpzcBC9OBZDNlGNaUdjzkdOGA7xOeGiil3 19SK+hq4M2kAok9lOjhSQqySwuepcGz5wkbZns7kC8DFIUCf8dOI5jpGbsKVrI+B4DQby7 V2HgWXbogssiUw+Z4lD13Sm0VdXSWxM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729799001; a=rsa-sha256; cv=none; b=yHoJd7l3wQK5UfGGA4yrq95knECEEfZIBflar0F/TNUKMWjY6nQzHN4kCc2hBlbIv2a9iJ nT4kSHchm0WWjUop8BHN8ThbTJhtToVWQCmNimyi0T/LTCYaJRLLOXJsZ5SCqVgPyjAeOR wyzo6z0RB1auo/8LKT2EjNIL/vTcQuw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Eu6mzOzo; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-37d51055097so909702f8f.3 for ; Thu, 24 Oct 2024 12:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729799152; x=1730403952; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hPb8mKU+KzjeBNrDUNxSqXqnN5Ly29w8syBmz/sIRLU=; b=Eu6mzOzo4RWz5vm12ffZJO6A7V9LV8SuZns2WvOIzzN5Nzn75BkVmcQ8UHKDuIGaGs wO/Y8Ru7szmIojNBcEMr3TxJpSwOajsMATBLd+S+DsO+4Wwj8n2MhP+rCcHSDO5vNTmw lVOGiHqOJwHYVc4hUY/Ih/UAtnr1FAoihZ+L2qd06SCPFqFOLQbLXlwt30D0CFvwvrcq yb/uiF7YWSTJkyCHoEo5iSmbrKXpWUoNKzQPHFflVuZ9MN1WofNEDq/1FWxFAo65jLRh q8/FGZC4C2f+8Yf4gYjq779nl8XVPQM08IXICCWn6zVHi+fM8Gj0dlznX+5CZpz4w5Ii c4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729799152; x=1730403952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hPb8mKU+KzjeBNrDUNxSqXqnN5Ly29w8syBmz/sIRLU=; b=huQmIT46C5+O52Mdx4FyeXygsCs9Esmp+Kd+Z+T8rT9Z+w07BeQ9QUMO+L19R/htga dpKdx69fVWrVt9XbeQ+RCxHqg4J8gJY1N2aCAlJP6Dp3Xey5VyBs7peTZ4nKDD+/y7eZ hoWF56dEXQmngrTOzymqppxYmPDFe93vGSj4B+VOXY5GCQ9B7svqQYSlt/84iVe5Xyg1 2K8pMeOTQfhFqQbst1FH6urRKH9M4ptPmf/sCweWKzZuXTuMm/eva5wMOxY0zecRlwFV lfE+3IhUpRBv6eDhYWlXXrjs6W8Ek9hT1qosTcRckcxZmJ1YcAn4MiQnX7TDHpkXg4qL Yo2Q== X-Forwarded-Encrypted: i=1; AJvYcCWYGTIPSGZrfCN37fnpxGYTzZX88z1xkrpETLxfUi4OuoAe1CcmIUcgKNXi0hPIX0gJP1TZldnj7A==@kvack.org X-Gm-Message-State: AOJu0YwtVcdcvgYs3z645vgP5fy4RYsI+qmPF5//iBso01HCJlTvRM9F J7/T5cTW2OsqRQ8hG68QiwHFK1LVZnGRzfhp0lh+u/5AzEaHx0SioAQgk/JElRw= X-Google-Smtp-Source: AGHT+IE1KNGuPkNPkWg4AR/AqGNEoAixnMnbilmy5HSq6ddD61ZBw/aVan4Y3rF9DyyvlVhbhsb4eA== X-Received: by 2002:adf:e848:0:b0:37d:4fe9:b6a4 with SMTP id ffacd0b85a97d-37efcf897aamr4839640f8f.50.1729799152197; Thu, 24 Oct 2024 12:45:52 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0ba79c8sm12008716f8f.117.2024.10.24.12.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 12:45:51 -0700 (PDT) Date: Thu, 24 Oct 2024 21:45:50 +0200 From: Michal Hocko To: Shakeel Butt Cc: Roman Gushchin , Andrew Morton , Johannes Weiner , Muchun Song , Hugh Dickins , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 3/3] memcg-v1: remove memcg move locking code Message-ID: References: <20241024065712.1274481-1-shakeel.butt@linux.dev> <20241024065712.1274481-4-shakeel.butt@linux.dev> <7w4xusjyyobyvacm6ogc3q2l26r2vema5rxlb5oqlhs4hpqiu3@dfbde5arh3rg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7w4xusjyyobyvacm6ogc3q2l26r2vema5rxlb5oqlhs4hpqiu3@dfbde5arh3rg> X-Rspamd-Queue-Id: B8F0518001B X-Stat-Signature: ttuy6dia1xrcon95q1uwrjxdsjfticsk X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729799150-703475 X-HE-Meta: U2FsdGVkX19e4wRZ3eH/LUUmk+50nxnj62pTDyz/8TUUw+lgfCs/dUltFwKn1nsgguQxfeosF/Kk1pKrwt/W1J3EWHq4W7SRoOA/XDHp1qB9dk5dYxPPZKrGtbkFdS6zqaRbuV5VJJWYPUbn/7f3n3la9o3aoD79BUdnQj3ZSW2BsX+Psb4GCZoSwrV6UQhxXIipwlhA6/3dbT4m5fRJSqV7RAtpsHwejUNvIFbBzi//R51ZzuOff9qhRdeKYptrq+OgauYCv+Zfv15vF2PKpw1y0FDVWM8ETADEakCYmdPXcog44u3yXzzAMstcD3BXi01F52W+vLJfEjvP7tdjLQ5WIZ+kODMrK85ufN88moaLQEZur9L6lsqcCNUMuQrik0pifOG1+3ob59NlRzE1xl8sOAFmSRI/SZgtrP8aFbrT78ppFclZoK/NdktdKgdnKO3139R+7wXuwkvamSFUf6+fFspi+LTgTkINgReEvtnREKjnMp2K/nSQSS+Sov99o2Lb1y99k8kvKGPUuTXUtFGqMefdY6vVzQ93i44k1XmIi6tWj5OScXUMcR5YHA5xhAYV3YTZ85I/s6Ahsd5Dn8Vfjkwt9RLbLmwfOYqKGaUvK8NDcuYPQgTb0h47MwTrVNfI4NCyAW446CsgoQiRPFYJ3aiVpahnQXO5Td/fiYFbj2LLfqfEZBxAdVvR+VIrbnBANuI2i0EvwbaOEpOjtBBpW0rBZrdzMoXtrvYyPnlujOK9fYIUCMkcZC3T6jeKsCKIdRp9JUkrduhWyoYAY6WUdIP6OIP/dmG6CE6gufxt8Qr9QLJCE9dWp5Ug+fiCg9iyuemK7fj5MkAI+nEVqOICnd71LlKuptALeqLQm+XjYff2zFTJ6rMWk27PmfOMcdnylLMsadicDuMgBv/iLX7osnR1qRRATln2KtrcJR8AOtOurbXYlRlPp26oAveGB1VXmgaZwV2aOwPOAM8 GS45UJ4L DrOVPPC8/Tw+XZWC/H8YCM0w8Ubefc1oV11VOGDobzEAyJ0ehkyM29qDkUizRWD4Jk1bsoGUwqpTUVkGhkiMoOOX5hpMpxeLKaox8+84z2qJKmqnpDCfXN12Zega22kZ1g7+HmLaEriA+LpOV1GNanxFsC6O/Fia4On/gUAu1OGlel7L8FSvuE8P9Yqf6PVAqYKwAzGsnlyYLV0OqzcXFFZgED0N1R55ShFnbMeShb9/jchTZjj6h0iKDeaHPphw121x4hTSUKFN7sLmFP/mdlldSkJdDBC8nf42IqyChuJS+4XIwCqWnJDJ/oA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 24-10-24 10:26:15, Shakeel Butt wrote: > On Thu, Oct 24, 2024 at 04:50:37PM GMT, Roman Gushchin wrote: > > On Wed, Oct 23, 2024 at 11:57:12PM -0700, Shakeel Butt wrote: > > > The memcg v1's charge move feature has been deprecated. There is no need > > > to have any locking or protection against the moving charge. Let's > > > proceed to remove all the locking code related to charge moving. > > > > > > Signed-off-by: Shakeel Butt > > > > Reviewed-by: Roman Gushchin > > Thanks Roman for the review. Based on Michal's question, I am planning > to keep the RCU locking in the next version of this patch and folowup > with clear understanding where we really need RCU and where we don't. I think it would be safer and easier to review if we drop each RCU separately or in smaller batches. Thanks! -- Michal Hocko SUSE Labs