From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4E0D10376 for ; Thu, 24 Oct 2024 21:08:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 398C46B007B; Thu, 24 Oct 2024 17:08:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 348F66B0082; Thu, 24 Oct 2024 17:08:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 210A06B0083; Thu, 24 Oct 2024 17:08:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 025E96B007B for ; Thu, 24 Oct 2024 17:08:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B3277141626 for ; Thu, 24 Oct 2024 21:08:08 +0000 (UTC) X-FDA: 82709733708.26.74250C9 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 71008C0029 for ; Thu, 24 Oct 2024 21:08:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=LGhPw5iq; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729804029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S4n63Mb1tGM1IatUclRz9ifPt5Kd2Kg/qSEOCtMtI4c=; b=eqZ8RkOwD4SfxgRyp1KqmIGVpaolHIP5QWn7W65L9o1Ekhk34ZCD1+9DzEn0gkx+SoUeLu 4d4OMDXVAv4vgKM6/szoONFcXbUe9Jl6gWAurww1FxuO/vY8Cq1YaC9+yXSkzQxUYl7Htq AAfR1XiWeSQX+iTvDQBmujuajlyiPSc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=LGhPw5iq; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729804029; a=rsa-sha256; cv=none; b=PKnsHfnP8C/yignD2wO/5JrI+C/C+vaLBdvfOTJQksir0CwU7QRFg6MPbIwyxtwkTTF2JP xWu1WjeNi9yRu8ZtbvQdRfeVKdLE1MfSL8d4HDJNPAzw5ZmqNe2ESOU35epGLf8XjiR4dD blxCB5KIoqt6t0ThYG01FzlPUdz5LI4= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4315c1c7392so14169265e9.1 for ; Thu, 24 Oct 2024 14:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729804105; x=1730408905; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=S4n63Mb1tGM1IatUclRz9ifPt5Kd2Kg/qSEOCtMtI4c=; b=LGhPw5iqtuVosy5EYeh4vIFIl/yhodpeNd58V2BnLMEEP4ecX2i0oR4Soq5/t4RNpK bsjnHCX2Z8c5qQZMR3UwclUEvnRPqKaK4EJ2CvKHyrxpOBYAQXSStsgnMN9V8IPm5nE2 WAhUPRje1zj5NbXTyQexi5jn80//NvrWHdt5KmRinX7/UsS1psM67EGvAEpJNgZWbx5f 0cHHuyuC0f+RGI8LCQzlxQW73d61ZdmEyELjIkGf+RiEv735jr2HM7+PNPWdeIjIofCk hte5I5AAziB/gh6Djfmebs9UtnzV3slS4d30DWNoMN9XkTa76zLosp3ceTucRHWUeYZ2 qoDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729804105; x=1730408905; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S4n63Mb1tGM1IatUclRz9ifPt5Kd2Kg/qSEOCtMtI4c=; b=VTh6cRxA9ss2g2qN9ORbg179dXY4y+i+1xUANGyoMQ8TOYk/nZAehei53MjCNtPLPw KiR007L0UYfJAkWoSOwZQqjD5Z6y/JH7Sy+II06g90+ensW5l628jkLwz3CmP0SUV4hW T1Gf/TpKx5cAkK+OtFji9tvjsUynmKxvIsa/2mb+n+pmfw5V5p95ZEcyrS/A3UjmUrUA 8YjH1A8fkAQlCDcflBrsBr29mFfuybm/3qp4Z9S6z9VsI6Gttf0va9nHgPbHW1KhQbXy 6Let+UzV2lRhleV6E0LhgJLsgDVUwJhLIvTJ4sg7MRTy+4KOX+vKyeC+u8kO6M0kNLib gASA== X-Forwarded-Encrypted: i=1; AJvYcCWy3gFH0Y1fLFjSqwnYx7kD4dSECUgJu5O80U5/bMB8UNznk6roSnIhMyKJHsVes5fbJEziaotdww==@kvack.org X-Gm-Message-State: AOJu0Ywjp2XxP2j8vqujrtueKURwYJZ0Lzc7JuL56GPc0chTgI1TnNbf IwPG8MCdP6QxyyHRFGVuE0BTIwX7DQuXT0xnXu/yVK40fI5/ngXxMR2tgKkUo1M= X-Google-Smtp-Source: AGHT+IGkLoUtU7fDoIxQFhiZArRp3INvQyAVYG/gF7NuR8gQG3bPft4cqk+7+GiGG1Y8PqFuf8HOsA== X-Received: by 2002:a05:600c:46c4:b0:42a:a6d2:3270 with SMTP id 5b1f17b1804b1-43184224094mr66088935e9.21.1729804104987; Thu, 24 Oct 2024 14:08:24 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a5b384sm12112309f8f.57.2024.10.24.14.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 14:08:24 -0700 (PDT) Date: Thu, 24 Oct 2024 23:08:23 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Shakeel Butt , Roman Gushchin , Andrew Morton , Johannes Weiner , Muchun Song , Hugh Dickins , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 3/3] memcg-v1: remove memcg move locking code Message-ID: References: <20241024065712.1274481-1-shakeel.butt@linux.dev> <20241024065712.1274481-4-shakeel.butt@linux.dev> <7w4xusjyyobyvacm6ogc3q2l26r2vema5rxlb5oqlhs4hpqiu3@dfbde5arh3rg> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 71008C0029 X-Stat-Signature: kq31mdkfrzrsdcq61pn96d3hz994zqjx X-HE-Tag: 1729804087-470579 X-HE-Meta: U2FsdGVkX1/iMDo4teWUVR6cipZmsJKPA4CBPDm+xJCkiAOATUIDCEzBah17ChGJ+Zg4tVoLGt8WbGLl82NhKISGjUNIRn/cTksVx8kNbWhatR6bfu4v/DM6I20D0atBq/UpA2igfqbmqBs9T597kCRLOt9cUZlC7QnFopP6yc+r5ZpJ5P02sA6sU0OBSXcZLPuwNhBHwiwwB4inye4wDHMDnePSZkD5CSN71J74Crcj1/Beu5GdNqOHO/x10iKheSEU9uta61GxNXVWQZ6wDwzpzuhI0dSFgfkZz+X0pY4qSirARZOzl0PBEN98Sm7EOGHdfQOxdQtmBJ6IRFbALU8rwpgbclaQYi8n8l2EtSA6JjzKnHtmY1b780E4zEGCv5/mIwkad6xQpHRB/MvY9Dq5bVOSWp9sk3fsG+lqjGeUFpoXQHJ+z4HtCawTpiXXlk61fsaJ9o98N3F9Wl2xFrTv+cupCF9bvy2LNoqSyeWZ9xiIi+9Lr6X5muggd+I5NRwh4vvbtr3u64aGU+DNzkdcZeNPTUsS8cl8tuVjOkGzZf7JJcgs8lmoLdalRVFAvv/rqqAag6kBOzj0jQKdZyuchYupeuDlxTT2cNv3tEkdq/kNIs6POm8TboTlaF1fQ066p9eAMld0HvEPap85nrq72VzSow+4CipN/cXHi9ejdrRZGjw593p8CUg14+1bjtj6gQXVsptFZd8sGOe+FMo55B716tlV8X2CL40k8XZyTgtojEPZVldy6oXGbPPU0pY5Xrp+2e4n9gd4uQjb6U0jpGRsbSFXdFcax4UvTyBavg3zD1C3a1r1y6HkoQCdYwQE4qZ/4Shn83uJjkxXj4fCPlNgIbW2uzylEtTluahxh3jhx035oCYxUSFOLVrdZusvzw3EhLL6BSj3lkWvO0Q3xalY2sDpQbOmVzLyPP7BdUeWBF+eKiPrd1kqkL4ugOgeXG/mUHRISJj24AG 3q1EGb1t t96Be/1+C8IvcXpL+NF2Tm1viCKIrfu1SZJkq06fpggp2hlrGXCN/S0oExwCMTnSq34O8Mi/0k2I3bsyhX1WqBNa2n5Zfz+kcO1uAQX977hQEkxna+dceqJw/oatAlr7TK0YCLdSwGO6cA/fOQ4YK0/buWLo7dLkHP9bnwXajJ57b2C7SmHHqRxqc3HTSoegxb572tA0RZArvT4jfmJXTYOses/ywsi5HEswee8jJ7KVHX0CHNEXgsvM/1YHf/5A1A0EQKeLtIMWgNStQ60Va9NbKfYhviu9RPIgdNbli0k1G4YRlb6jfjPuMtCQc14IjqUAc9wp+yWf5tE6Y76rHHyC71tzMUPlxvq4o68QM90pdqzk35ZA8N+LLWbfv4gV2yzW0HumYZ6D0+Og= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 24-10-24 13:32:53, Yosry Ahmed wrote: > On Thu, Oct 24, 2024 at 12:45 PM Michal Hocko wrote: > > > > On Thu 24-10-24 10:26:15, Shakeel Butt wrote: > > > On Thu, Oct 24, 2024 at 04:50:37PM GMT, Roman Gushchin wrote: > > > > On Wed, Oct 23, 2024 at 11:57:12PM -0700, Shakeel Butt wrote: > > > > > The memcg v1's charge move feature has been deprecated. There is no need > > > > > to have any locking or protection against the moving charge. Let's > > > > > proceed to remove all the locking code related to charge moving. > > > > > > > > > > Signed-off-by: Shakeel Butt > > > > > > > > Reviewed-by: Roman Gushchin > > > > > > Thanks Roman for the review. Based on Michal's question, I am planning > > > to keep the RCU locking in the next version of this patch and folowup > > > with clear understanding where we really need RCU and where we don't. > > > > I think it would be safer and easier to review if we drop each RCU > > separately or in smaller batches. > > FWIW if we go with this route, I agree with Roman's idea about > replacing folio_memcg_lock()/unlock() > with an explicit rcu_read_lock()/rcu_read_unlock(), and then having > separate patches/series that remove the RCU annotations. If done in a > separate series, we should comment the explicit RCU calls > appropriately to reflect the fact that they should mostly be removed > (or at least re-evaluated). Agreed! -- Michal Hocko SUSE Labs