From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2C5D0BB6F for ; Thu, 24 Oct 2024 08:25:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E41386B0085; Thu, 24 Oct 2024 04:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC1C6B0088; Thu, 24 Oct 2024 04:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6B046B0089; Thu, 24 Oct 2024 04:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A6FE96B0085 for ; Thu, 24 Oct 2024 04:25:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 69984411BE for ; Thu, 24 Oct 2024 08:24:51 +0000 (UTC) X-FDA: 82707809814.21.D48E0CF Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 25FD5160005 for ; Thu, 24 Oct 2024 08:24:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GERFUcyc; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729758096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CqiCsjxfc2P2m9O4T3RIYxyfddsRpc80UkRWd9InIdo=; b=xp6tOEpDE8L8MvJ/PfGRic+shOFMy2mL6VagrH/Rd1p9zhIJgnKt6N1T5gg7nkBDjVeKmf 0paGoj5e4QFs/8mzL+5gKWGLEsGhebe8Rl+hTOoW2OCgC+WrD5YxeImWNU+AIa95el0ZO+ ULlmmnP0ZEucO94xD3XWKE9qoG3lbxc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GERFUcyc; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729758096; a=rsa-sha256; cv=none; b=as2izPjBXn5pm6/2KMjfrcEZk75K0YpJk27XdFwp6wnZsrPoV+dxD5DJ3DosLo1IqrNivS lHa/FAjQ39mAwWzlMHNNd+K2Johe05JfFvBzTDZk53JK5GnVbG1Ws+PZQSRtJybOEiF9EZ ZoduBetUgAEjQJq7vur2jd5n8TO7R8Y= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37d4fd00574so403199f8f.0 for ; Thu, 24 Oct 2024 01:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729758298; x=1730363098; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=CqiCsjxfc2P2m9O4T3RIYxyfddsRpc80UkRWd9InIdo=; b=GERFUcyc2QnKXOyq1HGk7unkXcvTZhzPCZ1iQEaWdHpo3TnaH7vYCVTTGhn426U7ny 25oDwkWYrn6kWZCMKXr+UFeiUnkE5ymgfDvxQdD1B/grl8u+YYSfWOr4gi2zFemLF3fU gR0hH1U0JvDyPjxl4QAMFxpPP9Rzq7zaBy+2scJcytEZmv5qVLuLu7YXme9H1p3rQgvJ OHG1W23Wl3651MMPomaGV2R+y7xYtGzRfl/Q7EFzTlBnMoXHtdIg61opqPoiApFovivF voWDAJ+j1cR5WehxdshxmDjNGPP9yjeSejqHw+qdpaT2i66BDVg9eetNMJrImqFpsWAX F1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729758298; x=1730363098; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CqiCsjxfc2P2m9O4T3RIYxyfddsRpc80UkRWd9InIdo=; b=CZdMkgWn97ste4/t4t0rEqqEEt9P0XzaT8bhkBm7rfaPOZeyR7Hct+04gGZplkQ9de 2sm3NQtfKgrueoEWYiqTOfQb2GcUW6AgLufdDaLSKv2h7Ixb2ypmHvNR5mrurD/GWxD1 3CTtV0UUgFDvREOMdlbEKuPpMRmrzAbQzBvtnuHuTuQ/55a+RPvyg8fXkZo2MjYtoa3F dE8y79r8SoOhj34efU0bXMVgrIxB+HwQKd0zq/axJHg0cgzTaN579JcX75bJsWGk4FCN wlOOUz1j5VKJMIYREvwWdZ0mVBHZcksMe5Ixt+GvI1m3VrW9a66h19TDHxLk66x58Taq hDDQ== X-Forwarded-Encrypted: i=1; AJvYcCUzN4Nts9AB91ZiiuShImMQTJjZZ0lHQdAZPqmWcpMbHXKAh0q5EAMFx8wrnw2YYUaKEQnD1ag4SQ==@kvack.org X-Gm-Message-State: AOJu0YzP/7bk83gvcbKKFY45x6/UOHuWJiJwabafTgEhw5iDKbiBDsft eg3QBwQPin9Sb+vbIGjGF2ZBAiuVBHVG/l0wVwXvNDXbhT5RxxW2w2MTXzGcPe8= X-Google-Smtp-Source: AGHT+IESJKOMwf+RZiVBHWmX3AZR4ukV/miP9SpvfZ2ei9dwjNnTMG2G35izlIu7na0hR/suP4zpfw== X-Received: by 2002:a5d:4ac8:0:b0:374:b6e4:16a7 with SMTP id ffacd0b85a97d-3803abf0250mr681659f8f.8.1729758297877; Thu, 24 Oct 2024 01:24:57 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186bfaba0sm38007245e9.20.2024.10.24.01.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 01:24:57 -0700 (PDT) Date: Thu, 24 Oct 2024 10:24:56 +0200 From: Michal Hocko To: Dongjoo Seo Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, dan.j.williams@intel.com, nifan@outlook.com, a.manzanares@samsung.com Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes Message-ID: References: <20241023175037.9125-1-dongjoo.linux.dev@gmail.com> <20241023134121.68d4af59e2d9cc3e78a34cc8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 25FD5160005 X-Stat-Signature: puxih5g8kicfsxs8sw3oswwxs5iari1y X-Rspam-User: X-HE-Tag: 1729758286-514695 X-HE-Meta: U2FsdGVkX1+PTofzHOCfEbwri7MsV/TeHzScRExQKVynQE1NxrdtoGqXST9tgX92i2R6gjd/+okPquhxO5NBvSHdOWmMDQBlXbZWwmWRMNVkQMqrhYNnD16sTtQC4239cJmMhaAYkAAZYMTvpuK5IcbHnFBIc2Agx6qAkQQhArZS5RVkd/iFFcIo3VRwi90ZeF/UfOHB7H1vZVo/NYuiSZrM/coOXNrn+CYPvFm5X5OUMZfe8sEAijMXj6b0kBm1JVUGRba8Me6JrT+SgNr27YSHG84JdPfj/Pd1/efjBKZ8id5eNFj9qWkuUXmHJUtTvkGsA4gbK2p+Em8DqulzumhRXhPgRMxThRqlxe33a7nDuMFTCw/mm1BKqONRuZap9b64BsHBu7WnPjeW1tM9iG6s1BNl7TDmYyr+qdFQ6COb9Nw5Ko4G/B7hDpBIL+/3F75OYS3YBKv3K3of6zznH32L6uaQwylcGrLaxsimjeVrk96co65jX52byHFEg+NDnIzOxpzUSe6RaSTRWy/owqFfepSdyTmFWTuKWinTjCPraSsvtrglRCiMh5J/Qx3M0HDHs/FL0Gxb4wqKJ6Pbd+w9XE6VLc86ooIBG+kMJY5dGRtVfYECo6xdG2gJBXPPcOfSYVvQMPYeCrjy0CZSfcX+cPTKR5RmePLy4KaunnVOkw/QjUclurtogH7XVGe+dkiW4s1EcOrE0xwtCpG6uIQwGpbBV6jJOf30YzTPX7EMynrwoMy+FCEsDNtFOH7CsJFlouFLX2c45Zij/DG/iAnwb7hLXjq6gFoA+9L+eYKf4NjczS0ypEvGCeXV819WRnb/1iGyS8uafuWImYr2LMOE2O53gsxzQ+mIIeln/wSEZRsPYtSPfh/NWmmZMfQL7EzSsu4h8iaa8XC+b/7xpxyClOcxkco+s3QJG3cZ6PMOjHIBsp2RIGw92VLXrPAaUfyWoZui8mRLJd0cZ2x cBrSdxTL gEOpCAvRGzqt6gkrPMh2gynSkr75+S51Lw/NBMlmMhIMhQFiF4s3cMSHrPo9Cnm1aYffmVqCOD4XAqqaBwzTtiVldiCD/IAtFpagSPCcbGv48fXvmrDfzeO8xh59cHEk26zgvo4Vy9c1xN2qqL3j9fVMFwJLLJl1DU58D2dle4vI2gYj9CQPO7OnkwcVY6Tmyz5sUyDmpMY1AWhdCgvEwx4T9X1ti3PA5e14wJVqdMZGVK/Eah+f/ZWchWMdjQ02pPzHxD7OohOBJ4Vu8QjhRLDLA8wbQcQHo9apSHfS+EmLX7dPUHQGbxRKV84q0yPWKdhRh2sVZZK5ZcU3nlOQvJ8c/J69MvCTPBEpyBLFnK+rvALx3oqWV62AjFWhgyslPboeqtPmwHCXAOD+mjuGOyyhDLFxV3Sti3dYOGswDWkgYYMfM7ROJtgu6YPa+9o8Xu5vaTiDGRaijEBk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 23-10-24 21:54:37, Dongjoo Seo wrote: > On Thu, Oct 24, 2024 at 12:23:56AM +0200, Michal Hocko wrote: > > On Wed 23-10-24 15:15:20, Dongjoo Seo wrote: > > > Hi Andrew, Michal, > > > > > > Thanks for the feedback. > > > > > > The issue is that CPU-less nodes can lead to incorrect NUMA stats. > > > For example, NUMA_HIT may incorrectly increase for CPU-less nodes > > > because the current logic doesn't account for whether a node has CPUs. > > > > Define incorrect > > > > Current semantic doesn't really care about cpu less NUMA nodes because > > current means whatever is required AFIU. This is certainly a long term > > I agree that, in the long term, special logging for preferred_zone > and a separate counter might be necessary for CPU-less nodes. > > > semantic. Why does this need to change and why it makes sense to > > pre-existing users? > > This patch doesn't change existing logic; the additional logic only > applies when a CPU-less node is present, so there shouldn't be > concerns for pre-existing users. Currently, the NUMA stats for > configurations with CPU-less nodes are incorrect, as allocations > are not properly accounted for. > > I believe this approach improves logging accuracy with minimal impact > on the memory allocation path, but I'm open to alternative solutions. > This isn't the only way to address the issue—any suggestions? I still do not understand the actual problem. CPU-less nodes are nothing really special. They just never have local allocations for obvious reasons. NUMA_HIT which your patch is special casing has a very well defined meaning and that is that the memory allocated matches the preferred node. That doesn't have any notion of CPU at all. Say somebody explicitly requests to allocate from a CPU less node. Why should you consider thiat as NUMA_OTHER just because that node has no CPUs? That just seems completely wrong. -- Michal Hocko SUSE Labs