From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F44D0BB5B for ; Thu, 24 Oct 2024 04:54:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A54996B007B; Thu, 24 Oct 2024 00:54:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DD816B0082; Thu, 24 Oct 2024 00:54:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87D696B0083; Thu, 24 Oct 2024 00:54:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 67E456B007B for ; Thu, 24 Oct 2024 00:54:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA620A0F5A for ; Thu, 24 Oct 2024 04:54:10 +0000 (UTC) X-FDA: 82707280068.16.F529668 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf15.hostedemail.com (Postfix) with ESMTP id B9B6FA0003 for ; Thu, 24 Oct 2024 04:54:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VLOiPbF+; spf=pass (imf15.hostedemail.com: domain of dongjoo.linux.dev@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=dongjoo.linux.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729745630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YROL508pV/aVzcOA2vaUPlhPnKjiiTn09b259dUerBk=; b=VEaD985woJFLbkR7GVgfphp5at2Q/WBCxdowSubr5tkCLpan1Yrl5Be8FLZ96nJRr01b4u JZXdBch8BtTDF7WP2ew5HxhZzHvqVxgf4nYaHTiYrnd+iRA0xKaykwFgIcexKN/MeBOp4b 33FiRQkj/RnaKVlrHtIymA8clpMhze8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VLOiPbF+; spf=pass (imf15.hostedemail.com: domain of dongjoo.linux.dev@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=dongjoo.linux.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729745630; a=rsa-sha256; cv=none; b=Y3gpqnsD5SuT+6isvoRLBwYR76x+nkNvThiRNv7VHrwaHZVixQKIz2XnNsSDfsWeuL1z9T N5ky02QjfE84i04r29O9CIWelHa4EqcL0Fp0j+byjCwLoaf8Duehkwj4fWftal1afs3Abm UEwKag4Rss1aiwZVRgXU4D1kkC1Q/q4= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7ea9739647bso312600a12.0 for ; Wed, 23 Oct 2024 21:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729745681; x=1730350481; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YROL508pV/aVzcOA2vaUPlhPnKjiiTn09b259dUerBk=; b=VLOiPbF+MejOFOU0U0Sk07tCPXmRQuVxlCJ4eUJapNnCtxxlt5rr7GGstJsN3cvHEw 4mxSk3HgYbVHekVy3GZNHHyQxi50c9iN2gR6BSHyBXmfvSIsZk8xEEmhD8ThdxnG8ufl 6LcaBMvlHouUoJUmKH8GZHdP/rajjq3aNtKjdEI0dFujgsrrjnT/5jqsQWuDQKCIGCl/ L8iS6FBJ+HbbKhnvkheUeZQ2zBTQXCTQc9F4qxwuoV0L7WVh3cQetvlP5y9lQlgMny6t So17Rv5dX5rxsKQ3VFGwjbR56D7bPIbupeohtS0jZyYLzTms6GwrFnsj3b6eliU0az07 ityg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729745681; x=1730350481; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YROL508pV/aVzcOA2vaUPlhPnKjiiTn09b259dUerBk=; b=FDPD/ZMVVMtorAcZbKNtQyFI920n2OWlfcDtMuxz4whXtouLmmwrBhY6dwvXBVzEre FlI7NI4xzGKo9GB4n/z7XkWIzyT9wv9rwCXpyWy2ko0FHZx6FA8j8LwqQOdFFHM4xrgO 4nivUSGDTSkxFNyCtv3CzAN4Xr5ubd1VvRZFijRIyyAghbBlC45hh1oyqVSu2viRJEP7 +jY3fZ/K+DPjRnYkg7yzW0sdcnDTcu5dPEyT7js8US6F79eJ/OlRXM7LJwHgLyLgjYl+ rFFUml7kWZ9J0vKj1T0Lmj62cfKmaM880lBCt4mlWSuIioP2W41xa8K2QXiMOwc31isF /jAA== X-Forwarded-Encrypted: i=1; AJvYcCWs8Cm8kdfgoDmRtiqwwTLJ0Un6NTzKZDhV9Znz3GiXjLEQ9llc7dOapGSHEopXsxrSD93Kdfw/KA==@kvack.org X-Gm-Message-State: AOJu0YxKuTKtG+g0YtZH8cyajhicOyZkEJHtxHBCEEP/vLjYw8XxLq3d 22IbNF7fgAwYSgqtoSe13QEqMWNymiz/qGXPRSArrcsBcKXrhSSO X-Google-Smtp-Source: AGHT+IGGZOP07noPq3cIiBbd+28oI9FWwIKBaLJRIUE2kwp5Hj0XzDy8KQfPxtumYBKqzka9F+K0cw== X-Received: by 2002:a05:6a21:3416:b0:1d0:603b:bf76 with SMTP id adf61e73a8af0-1d989caa703mr681629637.34.1729745680569; Wed, 23 Oct 2024 21:54:40 -0700 (PDT) Received: from eqbm-smc020.dtc.local ([149.97.161.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec1356a24sm7297505b3a.96.2024.10.23.21.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 21:54:39 -0700 (PDT) Date: Wed, 23 Oct 2024 21:54:37 -0700 From: Dongjoo Seo To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, dan.j.williams@intel.com, nifan@outlook.com, a.manzanares@samsung.com Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes Message-ID: References: <20241023175037.9125-1-dongjoo.linux.dev@gmail.com> <20241023134121.68d4af59e2d9cc3e78a34cc8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: jwej3cmxgqzdzshbdoefdg88e59pwif6 X-Rspamd-Queue-Id: B9B6FA0003 X-Rspamd-Server: rspam11 X-HE-Tag: 1729745663-8736 X-HE-Meta: U2FsdGVkX19xlMwIuNsyH4mJbnQ4oPLxHx6uOgcI8o/Z71YhLuNA6S8M80VBV/vGB7Cj5fqlvgHgpRlAG9n0tdVHUehvydSnBNxiNpWy0Ze7BYIQNc8L0JUkNReQD0+aY2ZI/1V5Lp3xhYF1/VrBCFseM0C33vvESMFId32muGWkoBgSZqwkd4GKO2UQo0KffCPacTHpP/AQyzLBnQIIWPYskTrZJOxz8gW0mYPekb0sPblBa//02pbAXgWichf5ldHnbTrdRTsXjj0uwW/O3fCl9hK6F0JNIXjxfODdVFJKTbrHzLMbNYk1ojKJUBjP4hAXfF+CXwMxnXpG19cr7VgH4l3VqUv2pK14ZE7Cc767qSpZ1S37D75DG42z0Qfn7TDqJxosqfvoj7P+c3GqMlkdvDeCHIiDWFmI4Zr3io43iFSA2ay/96j3iMvXlwr6bPQuXRoVInDsZhaEyz+LhtUBG8qrI3nqtc8AgB7p06l3JEAD0uRIBLDQrim8En6ubyFk+KF3nETk2Qb8fWsfJzTKX5Lice1fut6T2wyYp++H8fOFTzdGPevd8QL7czqdW4bFUShqhjzQ+4fyRAxKwo2L64E7mwEG/qKAdpc6rlaX/F0/gXExDjTPr9GMRvYjJYx+cw34cuDt/chekzPkMsX9hyAQ5qlyysw/Mvutbi89luZ5AYgsGQ2nsEDHLr18s6oaRN6xoTp0BDFQH8vzqZiFU7TVY8Mev+6QUH3Tc1HkaYaUzhdB0obNry2V3EsuaZoMKD9W8xH/My+0g8otGctiD+JPPvj1XH8R+FOhoLWpxweeKyZEDpE9coIfohqTVucxKSVz00nLmc3X2MkdXEB7VKLzmcvL/zIwUy2+GHESHYy2XdnDGhi/BKLg+3+DE9RbxVOGHtbs9HGRtKOYVUMXQnFJ/4Hlm6Aurd+4A2p8fQwLm/rjlGDjXRRmKsYAwSnBrXXAwhImLqGjety hHOzA0Sf a4tX2L6hkpOb/incoOkiR9qtOIgupy/qOJMW9AOqd7+aad4DBvfsTXfSljKylw2EQQbQpOSRrWpy15ykcY0zO4WE9e/Ryb0f7gfak32uliRGyjaPxMZoHocn8CgLHWVCh24NnBIBujcyceN4SzX8wwncjdjnw7af5hEIO8CKhPakzi3OXDJK8SuW6+VFrruDVmg+9vYIbQp7r/Sa7LwdjvI/85nZ+xkXq2+mHHo726hpr9B8i6ed19iP1JU9q8IWAADX0EA+QiTXI2vctiR55KqkQr4fgsUcyQhreGnbxA9rg/A1qvoZKioExku7DyepEIsAFfF36x+sMmBhE3SeJ/+VhR2vWloYAiQ+zNBx5yR7yr05bSnhqy6mXWHMFrTyb9qB0A2Sm5DsQ2JwnAuGB9rEI24CVaIDUudJ4efrZ46579V5GW+zpUBrAcOLTCqSktU7oyykkoI+UBm4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 12:23:56AM +0200, Michal Hocko wrote: > On Wed 23-10-24 15:15:20, Dongjoo Seo wrote: > > Hi Andrew, Michal, > > > > Thanks for the feedback. > > > > The issue is that CPU-less nodes can lead to incorrect NUMA stats. > > For example, NUMA_HIT may incorrectly increase for CPU-less nodes > > because the current logic doesn't account for whether a node has CPUs. > > Define incorrect > > Current semantic doesn't really care about cpu less NUMA nodes because > current means whatever is required AFIU. This is certainly a long term I agree that, in the long term, special logging for preferred_zone and a separate counter might be necessary for CPU-less nodes. > semantic. Why does this need to change and why it makes sense to > pre-existing users? This patch doesn't change existing logic; the additional logic only applies when a CPU-less node is present, so there shouldn't be concerns for pre-existing users. Currently, the NUMA stats for configurations with CPU-less nodes are incorrect, as allocations are not properly accounted for. I believe this approach improves logging accuracy with minimal impact on the memory allocation path, but I'm open to alternative solutions. This isn't the only way to address the issue—any suggestions? > > -- > Michal Hocko > SUSE Labs