From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC53CFA47E for ; Wed, 23 Oct 2024 21:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF7B16B0088; Wed, 23 Oct 2024 17:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA7D56B009D; Wed, 23 Oct 2024 17:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F7E6B00A5; Wed, 23 Oct 2024 17:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 870566B0088 for ; Wed, 23 Oct 2024 17:38:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4ED061A0EC4 for ; Wed, 23 Oct 2024 21:38:13 +0000 (UTC) X-FDA: 82706181600.02.C2F3BD2 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf16.hostedemail.com (Postfix) with ESMTP id ABB2E180005 for ; Wed, 23 Oct 2024 21:38:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=bf5BP+3d; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729719445; a=rsa-sha256; cv=none; b=vIa9ya+1XZes3jkSGJeEGlMrP6VTahTKqX15oW7B79H5ITgX8xcp/vda4WkZAijldO/icN GV2fTexvTZtGQhCaSRlDmba2kwQtjxgruz9OC3pbbAtkU0ia12ss18v/HE9jowzIl25mcx 9EupuA5ec/xy/QHSeE7NXPCABPWDdBY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=bf5BP+3d; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729719445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3L+Mi6DCqfrLQhTJ9/me+xzacY5Zdwe6SV+TH0hXgAM=; b=sUqIeEowdKwq17eDGCWZkWaYmkU49Ba+E1nOGD8vY0NYMURPppMejSBdxDxVpYAdHQm5wD JER5ZZXSGNYvRTWNeYKHnUVn4EHlFxdHsJr58XH64bbHuHWhkJ9MjtXPNvywgH7RVUe5Ku Rm8uLoPbH9/D9s0YK2P2eZFziP0P4Nw= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-37d4c1b1455so102573f8f.3 for ; Wed, 23 Oct 2024 14:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729719522; x=1730324322; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3L+Mi6DCqfrLQhTJ9/me+xzacY5Zdwe6SV+TH0hXgAM=; b=bf5BP+3dtakhAbxe/HKCY6j4SL78DK8BS+pSqOpzlkj/NeR4hk6qwNfZfDQqkNwwRp PG6DtY7rh0N726LJFZIwkL/C8U2x8tBFXSVXr+Jb5df77dLXIovIMATSK3QejBW7ijn3 g9YvA+OQmTg9hDmqsOTmTDucAi5wrgjfA3HixJ5F80cfUB8a5ppFqDtm94OWd3V6P4iL vimNPc6HmSVss/Qzwz9p17kKDyCvAGEu4SVrAfwl51cjvA1K5Duh63PKZODKLd2XjL1R IT3xUywYaSuZl42ZYLeLmJgEw2mfKUiL0om8l7A1e4t3vv2lYxQvdwXUYQy6/YI7sAU4 8SxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729719522; x=1730324322; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3L+Mi6DCqfrLQhTJ9/me+xzacY5Zdwe6SV+TH0hXgAM=; b=D9uN7zVw8aqJ/HsXqS4PkNMCYt+iPvvdTiWivuoUgImF3e9iFxXXKMAmrTOF0WhcTH Ujjw+vchCnTjEcPUJjb/I9B8XQ+awxd8tja4NORucLqwMz4Ohh2opE/4QR7GDTQdrxM3 VO7n6BcUMI8iv1oXXzq6j6RJ+xgUcc4oTMVwVacA3mt6l+ikzeQ7qSeyY3e+Yg74qGwY eBoCh9AN7PEZkdQoa6Sr9aOWOuRGiF8qcerqBLnB58HQhnFZXaiz441ZygIxde0V3MDB j9wTrU2Cocl3jtK3ZJ7yiYmBIL0KknUpmJTJO/hivDhhSqQ+uvBfnTJaBY1BiwUHjSuY X/AQ== X-Forwarded-Encrypted: i=1; AJvYcCUDYpZdMJtiLhJdmI7ztKLUtjfobe32f34E3Tc9Q9myrKchOL/BlhzSZ05EWYBS8p3gLmuUzvZ+Xw==@kvack.org X-Gm-Message-State: AOJu0YxKYVFgWEEKukxQxwHc3gwMlUVi7+bU6Vh1ZCpWY6H4Gi6z5RTd 1Nw2jzisnwxlGWvMbwycxkpvUPfPEW3ZO0oDuNJZ0LidUAhOH3X+NUYaRNG5OFU= X-Google-Smtp-Source: AGHT+IFQIpR/FPx7yYotfITiaiDTqf+2At9gJKCIzm55AVfINq+xpgx0h7c8KFDVMRBdtt22f36MYQ== X-Received: by 2002:a5d:61d2:0:b0:37c:d2f3:b3af with SMTP id ffacd0b85a97d-37efcef116cmr2589164f8f.5.1729719521780; Wed, 23 Oct 2024 14:38:41 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a477d9sm9809215f8f.26.2024.10.23.14.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:38:41 -0700 (PDT) Date: Wed, 23 Oct 2024 23:38:40 +0200 From: Michal Hocko To: Andrew Morton Cc: Dongjoo Seo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, dan.j.williams@intel.com, nifan@outlook.com, a.manzanares@samsung.com Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes Message-ID: References: <20241023175037.9125-1-dongjoo.linux.dev@gmail.com> <20241023134121.68d4af59e2d9cc3e78a34cc8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241023134121.68d4af59e2d9cc3e78a34cc8@linux-foundation.org> X-Stat-Signature: csj5yocxwo7pdpaszrmmi3975qxcp9fa X-Rspamd-Queue-Id: ABB2E180005 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729719505-634529 X-HE-Meta: U2FsdGVkX1/kRENCzj+Y7GDHfQV2MAU1WDYdVF5znQd66eV4bHijONLYhCI0oj/zX48cL0wDuoR8YwIbawWg4Z+DLnqE6nhjkJJeMru+XhB5WTX4Mo/gtQ2cid/BwZG8Lh8aj+Mbn+WLNiajcGJnFPuV91F+1PmLDNfenWGkK6b4+wdOpF8RHy3GknHVwJp2oQX8721zuIXbee6zWJsJX0aqbFJURctI5JMwymfRNGCao4AuaunOWU4BvRle8yXP+u3RcA/0ZfiTwharq4qWblxRR+r/W4carVt0B5RyLkW1CLldnZU78ckoyhy5v5t/Lfexz3OJkrlVpkRJwfUMBab0ewfeKFpeATNgeDR4mhWU4xxnOMlviqDuJlDUt+d5XYoS7ldAsgmqEimn6azBQJY0IV30V4jezX0z10Pjfsq0/4NGZSKrVxWxOfQGZkW5xPiXuZ364TelP7860y/j8YnWA42WKwv5Ltj4zSDjMucufyTdpMeuz17T3JrruGL1CcLeeVihcIzulbUcnVYpgovqhDn1ca2433lBiCIOYRy91HKXlbAIITPn+4daPN1Kv37qo+7YxTDj357UVI9h9OgdgVtZDB5Ri4AJTIQgaaZdW6nsufXq1fFlPm1fbucApjtXqMWyR7it6h6Or8k70rC7GoSDMRyk+ZUD4jeaJwxbwdQD8y590fTkk6buYYsd8dptzeap6y6Q2+329hZbJciJL8U9oo7LfEmoqKuDS4Sgs7JtZ637pscEDMg1o+fSyLukTxQqA9wpLagA+tULfhnA8R8RCvs+/RbK19p/vgVWKkVx4DRNl4MFT/GrGWC4Tt0BqNBbrBNapqqVPr2/DzzDZDSF7sB36BHF5jiJNbBHGq6UCL1FIo2x6zMHz9jJGBVmKKpCOxrPI/A9ptfQ1e9/mopd9Gwr+21j6iArOt674Ijj5dk1Xnenho4HFEzsmsZiIqLA2hprwbijV1l WuL4QCkE nHvs1E5jHgMSyZgoKl/33ojoN0S7G1+Hdt73XT5D+FsYvrnDq2ezHIJUYJWdnAWXqUyL/AIgmqoDgqiw3jm3h5UXxxiW6xBS8SMPOYhXrw/azs5WvYE4pkd1It9MU+mC7vziRhauoKLtYbBYYwQlpUoufeaxYjmodQo6mLAy/1DXaOnO+fqPkIeU07R025op/aA9DZxfdJT+QSXgCIoPglXDxpBKNm3+lhI+5LpYp12wUIYHNjlQN/ojw7h3ZWSpfId5s/5rU2bNwVmWDh7cFutuogemBTMwh/11dtiWQJWfT7Qo6Gz8wt6aRLglnDFsPI2097PObqbPB8nOAMqrschvBzmYJGAB3WrQ1boFsIzzO1e0L2Cp0nG7m3QfimTwkYgtVOJTKj0UkBXaHjBzF4HhSI3GknM9F4oMX+zmVFgIvmGzM3SEYQEA7wlkrG61n6IRdYhERpf9YQp+eAPtBdrHwkwyfmxuH3BuC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 23-10-24 13:41:21, Andrew Morton wrote: > On Wed, 23 Oct 2024 20:03:24 +0200 Michal Hocko wrote: > > > On Wed 23-10-24 10:50:37, Dongjoo Seo wrote: > > > This patch corrects this issue by: > > > > What is this issue? Please describe the problem first, > > Actually, relocating the author's second-last paragraph to > top-of-changelog produced a decent result ;) > > > ideally describe > > the NUMA topology, workload and what kind of misaccounting happens > > (expected values vs. really reported values). > > I think the changelog covered this adequately? > > So with these changelog alterations I've queued this for 6.12-rcX with > a cc:stable. As far as I can tell this has been there since 2018. > > : In the case of memoryless node, when a process prefers a node with no > : memory(e.g., because it is running on a CPU local to that node), the > : kernel treats a nearby node with memory as the preferred node. As a > : result, such allocations do not increment the numa_foreign counter on the > : memoryless node, leading to skewed NUMA_HIT, NUMA_MISS, and NUMA_FOREIGN > : stats for the nearest node. I am sorry but I still do not underastand that. Especially when I do look at the patch which would like to treat cpuless nodes specially. Let me be more specific. Why ... > - if (zone_to_nid(z) != numa_node_id()) > + if (zone_to_nid(z) != numa_node_id() || z_is_cpuless) > local_stat = NUMA_OTHER; > > - if (zone_to_nid(z) == zone_to_nid(preferred_zone)) > + if (zone_to_nid(z) == zone_to_nid(preferred_zone) && !z_is_cpuless) > __count_numa_events(z, NUMA_HIT, nr_account); > else { > __count_numa_events(z, NUMA_MISS, nr_account); > - __count_numa_events(preferred_zone, NUMA_FOREIGN, nr_account); > + if (!pref_is_cpuless) > + __count_numa_events(preferred_zone, NUMA_FOREIGN, nr_account); ... a (well?) established meaning of local needs to be changed? Why prefrerred policy should have a different meaning for cpuless policies? Those are memory specific rather than cpu specific right? Quite some quiestions to have it in linux-next IMHO.... -- Michal Hocko SUSE Labs