From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26726CFA463 for ; Wed, 23 Oct 2024 19:40:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3F2D6B009F; Wed, 23 Oct 2024 15:40:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF006B00A0; Wed, 23 Oct 2024 15:40:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7546B00A1; Wed, 23 Oct 2024 15:40:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D7466B009F for ; Wed, 23 Oct 2024 15:40:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 650161A0E40 for ; Wed, 23 Oct 2024 19:40:01 +0000 (UTC) X-FDA: 82705883736.28.C1A827C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id D7AC5120016 for ; Wed, 23 Oct 2024 19:40:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CbCPwqep; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729712263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Et6ZsKeXIBFGO4NDX/pjakncj/XrWo073JcfVbMTrVw=; b=E2LSwfaQQ+dWr0P1amFWPCns2zSYnjzM2hiFGY6bf2/8s8p9dHhEUwCHTlubIa6jOgR94Z sBuwb2c2ORigFMYIdDRMAuI8163GSnPH+Kd2or6PrI2ZnhikCDFxrAK6/up+70+uClLrav +rRMDcjYhv1zUT9NLdRr0Qs26H/g4QQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729712263; a=rsa-sha256; cv=none; b=zgjIvD29GL0hAx/c5D3lGUAKu2HD4EGeJ6LHoUTdnwpYO/mcpYZN+tsStzGpRUAT056Vxm 9zEqZ2ePSC3sxr6drsIEOa+bVLe6LWaDG2v0BMlHK8jr/VqxiT8xfOg1Bu4eb+8nKvUyLb JaBrm1+/qjEonR7rHl1okrHubT4ipjU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CbCPwqep; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CA5A75C579A; Wed, 23 Oct 2024 19:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1CEBC4CEC6; Wed, 23 Oct 2024 19:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729712430; bh=EzbjkPV90UV6QSJhV+s0C5L6lHibDPt+fsO73VymlbQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CbCPwqepSOehGxvj4gxImQczmfNz6ssonAwXnbbgdnyvPL/xrQiub53FEqxdCV80o DkG/ZkcumVc7HGvXQg1oCnjbO0fWI1cd9oekU3fUc8kUzkzALUdJzLJ1xSKOLAx5Uy SWOtIgR5BVQfUCpaOvtXh1InOxF1+VyPK6f/2jal2UlIWa6sq9RBOIChEiAQRs+NDb 0rA3fu8lV6jjh/VEGsfd1lOoV3ucJvs4gS7seWhJ8SfPlRpA3LfeFhT8KchgCW/aOC NwZPM5I45elC7TC3Wy8ZnOueGG9M7xLkcJJc3flG57bViAFasvRZfxtIS1+cqq3BHO /S6imokpMEAkQ== Date: Wed, 23 Oct 2024 09:40:28 -1000 From: Tejun Heo To: Maarten Lankhorst Cc: intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Zefan Li , Johannes Weiner , Andrew Morton , Friedrich Vock , cgroups@vger.kernel.org, linux-mm@kvack.org, Maxime Ripard Subject: Re: [PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup. Message-ID: References: <20241023075302.27194-1-maarten.lankhorst@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241023075302.27194-1-maarten.lankhorst@linux.intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D7AC5120016 X-Stat-Signature: c5nh76gbiyc3m5wasaa4eb8o6j9inpyj X-Rspam-User: X-HE-Tag: 1729712407-876278 X-HE-Meta: U2FsdGVkX19KjB3DxSFZ7I1hqIrvBB8gAGIWT4xRjyToqf8JxgaJPsRisTAhavXXT0lQ2gVLtUP0339zZ6Ef0x2i5ERlohlqLZlZuEVf1YWjSn0pWdFBFqQvAXbZCfv1PFTW6X6DJZ34tcESnu+40v4iA5B1uVVb1/lB2xYw7VlRX2+lLU82/bDxKDtrrk+3A1p5ZiZfAkXyCWMxaw3SQ/QSSJ2mG8RdymNmD4rxSrcTe3zkeFLLbkY65QZWURHErH5vuXTHZaczDxE8S8oSIX7ptRZzfSg7I9ZheTyd/f+JnTFOgV7mzfLnojaX9tKXqosdGyX1WpPycq6GFWCuiPe25tRafKAUydh7V9qNf5uuuYCmy3KgBAlccTIAPn0nPEY7OlHBSidcoUGdl0E2THXaluZgj09kL/RyUdp55Xn367Q91tHiLZLDr7t208wEQfeqtdauOzLFJxPmTtNm7m3Nmhd57EZSOklan8BSkX/yn7rsFhT7MrgfX5buMuXBK/mgwgNkI+OrdNPJ6lBQaW8ibuJcgc9zzvJ5B8ew7vHHrphkoqqs63w/xOVSaP0tIiCtUtzapyLfTKMaNWC4bKOfNpcM4id+P4f1onMNnlJN4lPDKqKYyv/AyQicEbgqfBV4Fr/gYCh0AvNdJEEi8ZzIN1piBUBtzGma5IjMGgurdvr2azRdz6UFeGrTBw88Xec2GdODokl8MiiX6zfvYB85KFeA2boVQhXXyjAZrSA1uIaFB54+++RlJVrxSgXQVmF3Rf9KyqyuKbdsCOt775bTY5kP2dSreVbfm314jVKEVtl5RHYby2HhsqVXCVOBDtT1janzOLz+2f8yWVntEFYivUY9Vf3CbaUpIgjWLivxTpu0RXWxfGqXYtltPH//GQjDuwr/t1NSIpRsvEH8GhAKZ8GUGZlHuG0XVT52curo1DEUO7xjvETs7QEscEA42MRIC29AsG6w3Olf7NL eUYllQiu VmOMfQ7eKfkGHonegZQfH7nC28oB6+jnHkZK8XEOrz+uMU7OatY92T/8gz4gBAe+Lsnrpz109MxW9o26weuZ/UMLfQceYNdopHWgQbXGNmz65fKFq/bBEBGumzejvczljz16Av4yWG7fUgte0Vto6oi7cbJcWXt5k4WjP3sK1Q2cq/yzXQtPlEXE7IfQpv1y1uJf34Sd6JoEsZeAvARZroTD3Fv7zw/IyUlvXiKoPC9ZwTIQEVaR3qRAuGRAEGDOBRZZ5wvQY+EzOYws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Wed, Oct 23, 2024 at 09:52:53AM +0200, Maarten Lankhorst wrote: > New submission! > I've added documentation for each call, and integrated the renaming from > drm cgroup to dev cgroup, based on maxime ripard's work. > > Maxime has been testing this with dma-buf heaps and v4l2 too, and it seems to work. > In the initial submission, I've decided to only add the smallest enablement possible, > to have less chance of breaking things. > > The API has been changed slightly, from "$name region.$regionname=$limit" in a file called > dev.min/low/max to "$subsystem/$name $regionname=$limit" in a file called dev.region.min/low/max. > > This hopefully allows us to perhaps extend the API later on with the possibility to > set scheduler weights on the device, like in > > https://blogs.igalia.com/tursulin/drm-scheduling-cgroup-controller/ > > Maarten Lankhorst (5): > kernel/cgroup: Add "dev" memory accounting cgroup Yeah, let's not use "dev" name for this. As Waiman pointed out, it conflicts with the devices controller from cgroup1. While cgroup1 is mostly deprecated, the same features are provided through BPF in systemd using the same terminologies, so this is going to be really confusing. What happened with Tvrtko's weighted implementation? I've seen many proposed patchsets in this area but as far as I could see none could establish consensus among GPU crowd and that's one of the reasons why nothing ever landed. Is the aim of this patchset establishing such consensus? If reaching consensus doesn't seem feasible in a predictable timeframe, my suggesstion is just extending the misc controller. If the only way forward here is fragmented vendor(s)-specific implementations, let's throw them into the misc controller. Thanks. -- tejun