From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8769D0BB41 for ; Wed, 23 Oct 2024 22:24:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A5D46B0098; Wed, 23 Oct 2024 18:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 455046B0099; Wed, 23 Oct 2024 18:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31C636B009B; Wed, 23 Oct 2024 18:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 113886B0098 for ; Wed, 23 Oct 2024 18:24:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 19E2180F02 for ; Wed, 23 Oct 2024 22:23:46 +0000 (UTC) X-FDA: 82706295378.24.1718DFB Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 0BFB2180015 for ; Wed, 23 Oct 2024 22:23:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=MB1KFQGL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729722071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Af6qCHxnbOnQOn6gVkA7A18lj8phPdTBA+Y4XWjyTfg=; b=weWBJI1SzrsyJYPff7xWvyJJbRrXl+ViZ2HeWUW0XJZ/sl5hWbrbiTpe6LgTp/x4ZTnRfE F80/8EpeoMQYTHb0scr+WC0V9VYm4ams6TFWXGMLqiem9Y1c00p4Lk9hLz99PS9qGOpkEd 0M7YIaD0O2pf3D4MliHMyw+568ucSj0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729722071; a=rsa-sha256; cv=none; b=ozglTDGjG5QeEM+slJIWdqnAOQcC1V/uF0ViUL2ycs1N1ZNM6HX/WnQ5fBLr5gdRvVnICY 3ibtvlLAfRbfN4XcVrDVf4iHeumIqion11iQxYYVewHTccosOkL8xrbkIgWagPD/Fw5AdA npcGU3GO+epy+D9XT0VIQ/TeLV2cd7w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=MB1KFQGL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=mhocko@suse.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-431695fa98bso2406625e9.3 for ; Wed, 23 Oct 2024 15:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729722238; x=1730327038; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Af6qCHxnbOnQOn6gVkA7A18lj8phPdTBA+Y4XWjyTfg=; b=MB1KFQGLAnCPSLdmZ0/X/Al3KSmODviZJ9hmnuu0rtKttDyyq1iYTOijM4u1jiGCVk eYY1ivA3tPfnXBiBcZCRu06H+4ak6uQ04m8GPnwjfmSyRspH1ZM2luX+UMaBluhJDWia bfdxiDT6xSmt3xbFcQCeDisz4iChb4cd/H1THLhTDl7m7LnIDavjEBpnxDfujMNVTYuX l41sYuD9cskpdy+s5f2F6ey1aNNr4wj6wtyAboNvYCRVVseXoNyxMGdazImyYGHzcx3z FHezsrU0gOGt7zY4vAdGH21ubruFPE8yXmf9XYeyZEyjumOmgji8rtcLnNb9VQRCe2bc zdHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729722238; x=1730327038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Af6qCHxnbOnQOn6gVkA7A18lj8phPdTBA+Y4XWjyTfg=; b=HYC3DWI1WgPVnIe59jUiVlA+EUQC65bm8gIb3bw+8p+6Y8AprZR2RNEAGbdtjRljaq OkLkXizgOmrZmFHZRY2fMlACdj1YmIxVlrfMG9T9JIHbdhP5uGk4qQVPzZ4DMZ8ydnOH mBUXpKhruHRfqAfD2GFOibKLaHc81/JigGv7rj+pbSLqS2g9pDlqSUepeDuoJSURb/Lz 7E2ZNSle2LezP3fkfl1kn4gdBImZv56AmF2UG4Nzp7J69SuHZ4iRPsyI3+WP9NJBZVa0 iEkZRzQ0o+yK6yUuFksvmzYHvPwqZFTw3GJlsIJWs7gQVrKDnoC+idtfyi4+Gkr8ZEmb IfKQ== X-Forwarded-Encrypted: i=1; AJvYcCWvcY3V4YIfBDThlTR+xgF6dzLcLt/OK5NJJeOTW1KgDeizwxMXSMa6RbS8dHuJuKSXGtnuTp5tyg==@kvack.org X-Gm-Message-State: AOJu0YwF2iqD6XVP71VprynyX7sWLCJggE3yP3kQXgQCvV28Gy5+ym1r cKEsfcfGEK4TNTI7tqkG0mTtwzQ/4fV/jpJC5ZfBGx33y2E4rV+bg1rD52iKTzROO/W19rwN3Jc n X-Google-Smtp-Source: AGHT+IFWGGq6xOZkxdbVnpuoBguuE24zDjRO8+fSKst1oxYGTx8Vh022VMgoCs/98O4h3LAUg8mW7w== X-Received: by 2002:a05:600c:1d06:b0:426:8884:2c58 with SMTP id 5b1f17b1804b1-4318412acb5mr31194905e9.4.1729722238100; Wed, 23 Oct 2024 15:23:58 -0700 (PDT) Received: from localhost (109-81-81-105.rct.o2.cz. [109.81.81.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4317d03ee7asm47105805e9.0.2024.10.23.15.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 15:23:57 -0700 (PDT) Date: Thu, 24 Oct 2024 00:23:56 +0200 From: Michal Hocko To: Dongjoo Seo Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, dan.j.williams@intel.com, nifan@outlook.com, a.manzanares@samsung.com Subject: Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes Message-ID: References: <20241023175037.9125-1-dongjoo.linux.dev@gmail.com> <20241023134121.68d4af59e2d9cc3e78a34cc8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0BFB2180015 X-Stat-Signature: ak1e64z89snwohwa7x3o1ikutsrh8swn X-Rspam-User: X-HE-Tag: 1729722221-761249 X-HE-Meta: U2FsdGVkX18c8B5Wg0oNPVQYaKi37hz1PJeRv4k6Bpz7Lo6Ui8S10BUiisB5tsRYGrb1ubKuNPfW60BUwGExR34P98lw5zjxU+8dfF2BGlcZHHEBKpLeddQHD9+0xvL7POzOA39OeXO7fH0wKQpsvXdS5ulGJsN40+GRTG1VdNEJqB2+SLjN1Op2uGQfPYeQKBkrqFfJ1GB+HM0sLLS+p3oh9kRXn8z30/qlYK/XLOJttguOE/KXgMJH1C40v6GwNds0ehseaAzPPlVUtYzrZWUADquS67fBd4VUwyk4FSbcF0J6robgHriEyWH6ZXnpw9wjfuD+RLWlxU01oKhT9kaODTYExWLUsIB1seIKEi44x5k4bYsDUrlzigYnvJ5QljfcD+TLTwNuUb2FIhPIkcB0gP2PQElah/yxXz11CM9905Zisfdd4lQWwgtyrOWAu+0PpWaK9Cw16MsXA2j/QM7fFZGHRGA4kbULwJ11QnXom16WAOwyOAGy6/HiuUOUioahQccfMyDYKSdOscfnrdQ/afKedRwjer+HX8b93pm4bvpCSbIhHVZKlXCFge59+HKhtU83Yxbpv0phKvAcKg30KGAFaDDsGNY/emr0ulVdv7DJL/dcNW9gwLimy2qqt66ne/2JwFRzCd1mz7ahGae78jAjgGXfGeICnS7naXuPKTRdmwQDcmxEXo/QhbsI4llvWB35jCuD7skfMTl4/k/VSluoOR1X/UoxrZgqE7W+efrHvYUsNWeuJ7QWa/CqNZa8pG3WPC/Sy1vtV9Z8stoYb2R8RnleZxhwPz9wH1Ltmhnz8VCc6dLMSGU9RzXmywMLROhuhRopzo+l+rmd/mbVD/2bYDnZMlQIvQLva/++rAWdjpsK6oHhEpEWw2UE539zVCSej5kEatbH3tlMO017AO189NmUxY+XUnYfPdykPKsOyToaH82movCmRB/082pbmct1Squbrwa4BQy iBv6u5uD QD+Y1jigF/RmoJDLcC/t+sylJMDkDWOPZury/EDI/cN+o/gFv8epByFnvELyE865N9c3dYyEv7EaXGgJ2ctrh9UqU7ojlFLQ2WNSYbcmSbIuiiL1pDJFQ888tH0SGM3EQOocmrD+3dsYFfV4fa1sbFpph0cEsNyoobhZTbEOYVIIertJvBdaFo0f1YaI8mjsh41Inejwe1y6bQftA1vP2Bqbp17PETs1Ix2vAWy2FyiMYsDcvvwPhUbsZgONshxWtm8CtIvOsHdOO4xP3Q5dHgq+xdfjsKdQ3DrmPv6cbVHwybnLIN2jv9k+sAE/Oxl9JAOr7l3Fo3eS8+6RvcdeU8SVVb9AW/Ic4XDuM+DYzYrNp/K/g+t6sDFJd0DT4rP/AOaMbbEE+KcJKAM970r6aG1mURT5+e3usjgYkyzjIs/4XXcnpPkTdSf78x+vYCRwXZkE8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 23-10-24 15:15:20, Dongjoo Seo wrote: > Hi Andrew, Michal, > > Thanks for the feedback. > > The issue is that CPU-less nodes can lead to incorrect NUMA stats. > For example, NUMA_HIT may incorrectly increase for CPU-less nodes > because the current logic doesn't account for whether a node has CPUs. Define incorrect Current semantic doesn't really care about cpu less NUMA nodes because current means whatever is required AFIU. This is certainly a long term semantic. Why does this need to change and why it makes sense to pre-existing users? -- Michal Hocko SUSE Labs