From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DE5D2E01B for ; Wed, 23 Oct 2024 07:05:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF846B0083; Wed, 23 Oct 2024 03:05:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C708B6B0085; Wed, 23 Oct 2024 03:05:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37966B0088; Wed, 23 Oct 2024 03:05:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 959776B0083 for ; Wed, 23 Oct 2024 03:05:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B61E5120765 for ; Wed, 23 Oct 2024 07:05:25 +0000 (UTC) X-FDA: 82703981346.11.6A7B3EC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 0A54620029 for ; Wed, 23 Oct 2024 07:05:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=axsJdf++; spf=none (imf13.hostedemail.com: domain of BATV+16051c3a8dabb1c72812+7731+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16051c3a8dabb1c72812+7731+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729667062; a=rsa-sha256; cv=none; b=3A9E/i9Npbsr4WqvoSo4nzH/EyNrZbgOJIQgqHUWd6ex1GJ1dslf9DB1Mfy3uTsTndPsC1 FMkJDUvk23hkgu2o69YzBIdrhW04MODLQQea2zenBDqxF8CEcjz8RzKazv8CeAmhFbJB6x J8pNhj/jvLuBaOFPj7WPNaVyqkeZBT4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=axsJdf++; spf=none (imf13.hostedemail.com: domain of BATV+16051c3a8dabb1c72812+7731+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16051c3a8dabb1c72812+7731+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729667062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsniFanEL3Dgve+4KzzT7EAoH3kZ5d6NkRqH3plnZ1Q=; b=zqa0WF860kN01RXmoAD3OxqFRUd+B/Sz6D0YKaW8cb1RYxKYcTlTNgV32+Ue6DESQRUwdA 0klQdqF+qe3mhUe0EBnJ61Fj9bRCn45O3Mq/RNu5pZib/MllXJalqssrDH8OkDJfkrNGDN Dm71/Nm+QXHeQsUfwNFKA5hsyP2jnKk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OsniFanEL3Dgve+4KzzT7EAoH3kZ5d6NkRqH3plnZ1Q=; b=axsJdf++TYblxJFfvZHsCQtSTp MFJ5Gxp14AVOdhtYdxkRFm8vryrPFsEi3fIjHT96PlIJtkZZioF2nlRsYPK5tVbpctQnbtaOlqZ0n iuBk1H1nBxYpBi8GHn6YHvYiC0ac5s+OeIZFdRkO9q67e2ToXiuIXTjGQQfOpGk/VSJLgMA6aVcjW hippYP3b54zou+kYzX2BvcC6en3rF9Ax2G2GpjLirInZQj2jS9XtoKny7UditWXN6NpYI5h8nEDfA U+9nQ6JI++Ssg8+4agqW7i1VR7UzGbkv9gkpr+Cxrrspa17xCup7qUO1PpgCJZM/Xy8oDDDdFVlS/ PRI3LnGg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t3VR2-0000000DJkM-4A3y; Wed, 23 Oct 2024 07:05:36 +0000 Date: Wed, 23 Oct 2024 00:05:36 -0700 From: Christoph Hellwig To: Marco Elver Cc: Christoph Hellwig , Arnd Bergmann , Andrew Morton , Sabyrzhan Tasbolatov , Andrey Konovalov , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: export copy_to_kernel_nofault Message-ID: References: <20241018151112.3533820-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: hgxfnwnyh64w9f6dmgjq7yn9x5wt7ik4 X-Rspamd-Queue-Id: 0A54620029 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729667121-676988 X-HE-Meta: U2FsdGVkX1/Y7mGXlHa6dhejcU9tGRpt54KTl8ZPKFG5T61sJvBFdxNhvTp3lXf7vJVnikrv21zhelTfwPxE72+vPWSBHFCG9WDaw4vjVvHHPIu+zUg8lSRg36Or4ovpQ4DP9LzfyID5NbSkQORks+8qCZhMhVbRqoM7GNPU7oOVakaSylqbxeoVD7yCwpfhNrWityythcMx0Aia2zPrM0BGkj04iycC6kq5psKhV10PHQrioOJYDQIW6IokwMd+ZGyUyPCfoPU4wtA4kiVqMAu9wA5WfnZFyMMG8L2r2B0UHMNdDoOiZoxIfuzgnxl1p1+AcqMpox7i076R0xlHES4kf4uoXakJcmhfvhPW95o5uG5tlhGzpgC/oiIBSXpegR76cvhf4d7bz9kOGQpqcvlpgwGjXWvWDbY3Xf0RgcDACGMtifSdX/cwUReK/4CIjnuELKfSkDgc+v6+DfHbQcUqkYF1cT0GNZtIB0x1i2Yrf2993bYRTGypV3EwrBNFOayd08Wh6ZJwXX9DgWs1iNy5Q4VmCIL8zFP27L9JPUac42i1nSDtv9ImirpoZ4FF61Uj2beqND0caZvygLtSXUgwP3j4DfVn1eeb8U+LCrVUdMSLKDH6c5ep/IGafMrjghlSgej8YO02WoquPCu9ebUXhdwZfuAWhQsKKo0LR3hVr6UpP/ElAvAZvC9PURN//J20P/Bx1RhVErXwgyRebwpcvgItwTi7pUl3VqOOx4oVWMY56a05h0IJZC51kxg9yhmE486BdiMN9JqUZ1rGBiPCvR0ib608oM07HavthQFQKO//Tl+4z8HYD4DxuPLY5ID1sD1Upnfw2nnCrVFOlYj0RVyIBgDWSUVCZWB0sXWbliriQ3D2sYJmp6xP06r9CqdABS9/tXUMATMjJNQ+MuRBnnQLLrsG6uBJ5pb+AV5lGRpzll27zxJUi1785Iv8cf9N/kh8SkGmNrSgHB2 uvXeTAZ6 OEW3svGZdyq0AYp51GhGoR8xBU8MNLlM4f4fWtD6aTm/w8OaNybYZK3LSYvy+QwLSrsXQA9Pc8qLYZgZeefsVBGkbgDQMLgat0VfP5EFPtRCNobZIT2GCN+ZV72Xk1CmsiYM+ncRq/gIODh9Nd+O+qh+k/GuyG0JRuW3gX6yFIRdmJHmLGR14jHeJz9Vm3X0u4CrB9meifFdY1GVQzrVJlHqT7o4JEyO4S8nbj4GlWvZ8u0cqHRLD2YWz2Lt2uTTDVod/PtD+BEepR5qJGvpYNHMWzXgcTsKJh0prny65yQXGp1tXzKwAIP9Ytb0FLsyfM8Uybf/Gi3YBi0noxY+WNjxD1OgSNxpbps9KiqhCbbIltu3bmdB9lgeh+6pIh/+euUPqiG2SyikW8VJIXDWl8ZdZaYkM/H3bytsnjHINS0Nj8+yDN9tXn4MJbzGjMxwli5c2MXmUZdv1j/mem+Xzbh6VEenFziVwCTMpN/0gbqkwsNKM3WocMRGuKmUL9+YICx8ZfyWdYrzgmeDbhxwu9LgBhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 09:02:23AM +0200, Marco Elver wrote: > Another alternative is to just #ifndef MODULE the offending test case, > so it's only available if built-in. No need to just make the whole > test built-in only. I know there are users of this particular test > that rely on it being a module. That sounds good to me.