From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B206D2E00A for ; Wed, 23 Oct 2024 02:58:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A00C88D0003; Tue, 22 Oct 2024 22:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0AB8D0001; Tue, 22 Oct 2024 22:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 850968D0003; Tue, 22 Oct 2024 22:58:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 63F6F8D0001 for ; Tue, 22 Oct 2024 22:58:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B7DAD1C5007 for ; Wed, 23 Oct 2024 02:58:20 +0000 (UTC) X-FDA: 82703358402.13.0AAC3B9 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf10.hostedemail.com (Postfix) with ESMTP id 2CDDFC000C for ; Wed, 23 Oct 2024 02:58:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=AqAoz48d; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729652241; a=rsa-sha256; cv=none; b=QTqjy0V0gflecPXLdehcSunVIOfgSUBzBraYkbUqlMy17P/3CR2neK5y3UcbXchrqdOe6V g7Y9j1ff2cVxaFAqf7YRSK+IH17Ke3py5eChZHGSQW7Crx7dx8H0YAU/4YYMXd5CxUmi/o KrweBuaWUxDrZNbQI1yHec6rm5JPxy0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=AqAoz48d; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729652241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TTzAK06IbzaCuf3+XhM9A1yRCGYdNF1dw+CfbxtWmj0=; b=oZ/S3UTrCvQNxBBeVepTvxWZbmAsVssQKYDWqCCNKvPrO4Uz/ytCsPF61i5Ye3nB/H1wkY 57Ile00JK4quuMACx7ITv+PrZMdgcl9d3kOmxmAUXzB2Pu6vAJ2QpwXn1RQ5jFQi2tmArJ Ivi26ujU2/Usz94iHm0whWWh7Cvhf+0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TTzAK06IbzaCuf3+XhM9A1yRCGYdNF1dw+CfbxtWmj0=; b=AqAoz48dnl4qMLA5c+GW30jmF/ y4XwN6rToUpPoOuXrfezhXcBaUp4e8SgEAxdFC//acHZzu9U+CMWwwejKcp5G0SSrqX1eGP3fAKmA JX1oYUYrjJ6of8CsE8yCsS3HSsIcuq9LX1vIHQsj2Lvq1QbuwzGy4uMnhE7Xuxl2J9uVIiZico/dC ISbDAjOFbyowABYQV1jjs2udJg53tIFHbmFqKLqMqexQ0c1bn7NPw9qXUw+35FuVo+YP6JPdKk7Ui xcMvD3516AchJaLeUispoM8VbvqvYKkh4/V3FGel7Uh2pCYQ0p/6in/27NWAxlVShDKevZyphd03+ VhbZnvng==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1t3RZm-00BPDm-1e; Wed, 23 Oct 2024 10:58:23 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 23 Oct 2024 10:58:22 +0800 Date: Wed, 23 Oct 2024 10:58:22 +0800 From: Herbert Xu To: "Sridhar, Kanchana P" Cc: Yosry Ahmed , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "zanussi@kernel.org" , "viro@zeniv.linux.org.uk" , "brauner@kernel.org" , "jack@suse.cz" , "mcgrof@kernel.org" , "kees@kernel.org" , "joel.granados@kernel.org" , "bfoster@redhat.com" , "willy@infradead.org" , "linux-fsdevel@vger.kernel.org" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [RFC PATCH v1 09/13] mm: zswap: Config variable to enable compress batching in zswap_store(). Message-ID: References: <20241018064101.336232-1-kanchana.p.sridhar@intel.com> <20241018064101.336232-10-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8i8ihmep7pyfkim4kap8ioep6s499qk1 X-Rspamd-Queue-Id: 2CDDFC000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729652309-843677 X-HE-Meta: U2FsdGVkX1/P4Hbf9+MhplZDxPaO0bqTmrSEFC8PoBORt4waxLuIop/KfnjpimggdSoXG2VyiP9n6KLImc5fszHQJB/p4WQzt0mnBAknNx7Pa35wWtc0V+HlW7lM7fWjRYmFJ4cTwEu4ZqKI8sLSwTZYuwFsDmR7Wj4OI8YDvXnYrUdhk5XdfRSJlVenMcy0NmdrU+VccJrF8SH1Ej8MOB5uNYWBk2EmKJX9dfCt5a0KOGaghDsCduhL4aGMLhlYpqj7SgYa8A8xLbgYCYTUu+djjuooDR8TDGDAkfJkBAzQUKAp8bhcOxJEt8ONB33nqmNFbVA1dt9NqNYtxL6VSqPRLAAt/hPFF1Hf6rMIAWk70egi0ErApcyn4/uEVGNJWhEZwCWW6iNOMSmlZYD+BqlEwtUgfj/fEO1g7OXGhBIQRtABEIXJpu03E6fD4HuuE8PSrZX3OD+GYh185sDH1pSu3yh7MRQtv/wFkY8wMVl2hAEwDeBD+lnasXqLDCx18TLiJj+pHSGqnuwnuxLxuCPHC4LhooIR6purK0DQqCzzWw1UT4D6Q9CjBSYh186qtKyUq6Wye9KNog9tvSJqBeE6rOKydTrJujVpcMzUzfCpShlbRr+wrFexPfenC+Cc3Q0dtpgwAKKHDZ8peuIP/G19wkIgc8f7XozuEHuw5dDLB28pHx6Vq+d/d3yDRbDOMpBXxp9v/E2ubDmA7GRUrxzOpdalVfLrmgccunCgcNYGH71mIG6N6PvfsVAi+gwFM7ZayJrPmqy4dWR05v0RYgaRV9HV/rMSnf7oD4wK2wT2yKO6cf/ErVJ7CmpiE8NRvGUyNxfh1n/r2MLrey0V1PDaQQGPu9A/+ifHhliPR45Cwp70tUTZQ/kMvlncSeMoeeG+yzYfapVA2txeFgkgcijQw2YS/V7GD/rGLGQHTij/Ov0+B6c1gmLp4YlD1x4cNav6AHedYWzyYLvt1tg qiFHY5FJ CmeM1Gozi5s//gT/njVdOx0NEQYt13xv3wZE6oP76IXW40xJcavcxqY6t2qH3GwgbGDMO0QyspIMqPJq4zyn3IshkyBPydQe4yUxcoqAyp3Tf/Rryo60cQ1n778A/Cmg/4jFujU1tlylTGAFBYaOncEZ8VfmqbRf5D5yXKzR3afpMmtPo2ykPHAbN/Uqh8XqwtH24/kCsWqGT9QwS+jEJuLLSWrEUv8YNAQwdbAXnJz6XeSI/IbGSP/N6HgISaAIfc6Xv00MmULCnREhrmVLkgJT5zTul2LOQUvLIYMKsRgYGfq+J+PBSJi+sr11aK2aVPPe9EvBOePWdTikxRwUdj6QUgulFRAhiF6cr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 02:17:06AM +0000, Sridhar, Kanchana P wrote: > > Thanks Yosry, for the code review comments! This is a good point. The main > consideration here was not to impact software compressors run on non-Intel > platforms, and only incur the memory footprint cost of multiple > acomp_req/buffers in "struct crypto_acomp_ctx" if there is IAA to reduce > latency with parallel compressions. I'm working on a batching mechanism for crypto_ahash interface, where the requests are simply chained together and then submitted. The same mechanism should work for crypto_acomp as well: + for (i = 0; i < num_mb; ++i) { + if (testmgr_alloc_buf(data[i].xbuf)) + goto out; + + crypto_init_wait(&data[i].wait); + + data[i].req = ahash_request_alloc(tfm, GFP_KERNEL); + if (!data[i].req) { + pr_err("alg: hash: Failed to allocate request for %s\n", + algo); + goto out; + } + + if (i) + ahash_request_chain(data[i].req, data[0].req); + else + ahash_reqchain_init(data[i].req, 0, crypto_req_done, + &data[i].wait); + + sg_init_table(data[i].sg, XBUFSIZE); + for (j = 0; j < XBUFSIZE; j++) { + sg_set_buf(data[i].sg + j, data[i].xbuf[j], PAGE_SIZE); + memset(data[i].xbuf[j], 0xff, PAGE_SIZE); + } + } Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt