From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84833D17159 for ; Tue, 22 Oct 2024 02:14:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12996B00AB; Mon, 21 Oct 2024 22:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC24D6B00AC; Mon, 21 Oct 2024 22:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB0C86B00AD; Mon, 21 Oct 2024 22:14:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD2C76B00AB for ; Mon, 21 Oct 2024 22:14:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 413B5A1C4C for ; Tue, 22 Oct 2024 02:14:18 +0000 (UTC) X-FDA: 82699619142.08.2B66AE3 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf02.hostedemail.com (Postfix) with ESMTP id DF95080009 for ; Tue, 22 Oct 2024 02:14:15 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Y6HKmPWK; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729563234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lLWQY5iRq3tw5HyDjHCxYRkbP33kVvxx/p8GuY2FTmE=; b=XFO6JVKc65x/fnz8LZqdfXFZZxUZjWSKhv/3FpxPUgn8aM/Mms4yTNo3NWne6D7BHaRZ8A s0sAHXbyzl1zRZAjebXXAY5HeqQbr2FTfLsp6g+v4Uf4Kk2WlQMrR1GBF5WcMCAhzfyQ4E 1xjAPxIdZ/NkKf2mkDYSvuI9xZtbDGU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Y6HKmPWK; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729563234; a=rsa-sha256; cv=none; b=ChEZsmBeqdo/2r7PDVquHL/uFvCYxOr4OCarRQPdH2q6gimyF2PImNan84GaiCThL7qRaB oHlEcYRDHSitZuDRFNJhJoyqT7iF1kYq1vDqUM+BeGm02KAddV/RRMO2nu8tILUrO4V8rl jiUvL5pIomnCSjRIdPuCfcD9xm8U4TE= Date: Tue, 22 Oct 2024 02:14:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729563283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lLWQY5iRq3tw5HyDjHCxYRkbP33kVvxx/p8GuY2FTmE=; b=Y6HKmPWKU2KkRgCLRXbWeSjzoT6zajeNhMF4IgPSPFZPvHNnUAh3mL6JkUEG/+bQHDJWLF zbek8/VTkR8iBpoR4wJ/GffP/GP8JZu4JEWRJe0PiJWPjFVCa1wiz4zuWGBZ4RO79dBKo8 HIu+4jXASzZnNIDX1U+mNG0JJNd2Z48= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: spthg7ujnf1ih7if6k77p63mh3s5qdac X-Rspamd-Queue-Id: DF95080009 X-Rspamd-Server: rspam11 X-HE-Tag: 1729563255-691305 X-HE-Meta: U2FsdGVkX18wOHTa0DbftXULCG8UdQEZ7eC772EeTf4x16sUdKpc59wz9iiM+v30GeNgR3e07Jein2Qi9NaX2HuyiJoEIbYbkuHlYSnOg6XYkTtgTDuiK/7oekUCb09qH735s1HFaVGUXBatw466qMx9qdOjckjVTkgpHHQAaN+E87JT89aLzoAqy3yo83DVvrexkJCaRnOx3dKQzxKpKzpSEmgxAGeQCFQhysNNm5S9iDyLOBRedgSS8crqeh2V4KlaXRVDjGSRII6XVvwDwT16ZWNaO2rTHMv/SwWA5beIoIfF1/dL4M9G+1m/mdxFWlpXe8K7rP73P94ptXsKPe5LehI6+KOv6j/pOSRAhAE2mrIZRbLe2eIrI43AfqKOtBN3vMqciUKf4iW+dhy1JX7/FWYMx0tocsgYtKTVdBy99oPgYTPglstNQKbUdgdmH6It1lYF5A9d6IKlvSP0ZOjhWXmU8z+/ufdoljwoVET1ZXUHmFk/eVfpRP6bUvNDDy1UGoH3v9zpdJs3VkrOxOwoRvUBhx3VYy4BpoZFaKarVIc8gse+b1kkfRmxIIwR2awSBrZI3Qx5Z/X3L/1cASsxM8RiAuyzwAfjpr0TuirDO5kWz6RoqI+cXtEZTDPCCs2gYDaVLoicfsPpWPQ8HeMNf+W/9mtBM87PFx4Htu/f6i8ASn9X3xzkB7onxGQuyK7hFH5mJo9zUqsW4FCsylact/eQxU5Coz37fGuqoxIxwIQjjqntM0uP91f6xdBonshbAWkSblpp4PSuVbTCj9aOBHEAlvphCI9KI97RP/STsvMbw8cG4Dd/ivO8JH/z+ienXv8hf3jM3YnFuYwACOuyZQGM8ZVkLlVmjX0HMf0geJTUK4JUJXe7Bp79YnijWSkNwQ+L8yP3l9rC9PL0hPFanBi6H+02qHfTv1T7UD3srSisXUlcyDPSJW0kva/BihEWRtvNrcdlikOln+v 20i+T7MZ F9gMBNewPjfM7LtN6Z0Ovx5wADWfs7OoCLUjsQbaV4Ec2VcsTB6JUwsJ61RVs7e1CCsqlO85IxAMNvv470SVkbKh0G2edWO4RR34Q/OUghP0FMqUrBdPH8AXRvkySIpZO0A4Wh6kPTqe45O4mey3NE49d2gvqpTuEAG8NBZEddLTf48F/o6bc3VFOjQG3fvFVAFwL7htGSkBy+X+jETgezrtN0W7T8AJ6oufq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 09:34:24PM +0100, Matthew Wilcox wrote: > On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote: > > Fix it by moving the mlocked flag clearance down to > > free_page_prepare(). > > Urgh, I don't like this new reference to folio in free_pages_prepare(). > It feels like a layering violation. I'll think about where else we > could put this. I agree, but it feels like it needs quite some work to do it in a nicer way, no way it can be backported to older kernels. As for this fix, I don't have better ideas...