From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BDDD17159 for ; Tue, 22 Oct 2024 02:16:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E866B00A7; Mon, 21 Oct 2024 22:16:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE6F6B00A9; Mon, 21 Oct 2024 22:16:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E406B00AA; Mon, 21 Oct 2024 22:16:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 34C2B6B00A7 for ; Mon, 21 Oct 2024 22:16:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AB28741C46 for ; Tue, 22 Oct 2024 02:16:27 +0000 (UTC) X-FDA: 82699623762.27.23F0575 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf22.hostedemail.com (Postfix) with ESMTP id E9328C0012 for ; Tue, 22 Oct 2024 02:16:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cKGXCrBb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729563229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PABLEHqBbAv1qMkTJjeTZTBdgWmacrEo5Nko1BqIF7g=; b=1Pco7ffWTrtsl8G1tyZl0WFkPcHP7TCZKW/BQIOWUa/AKPhlswAsLh/J0oW+fPheseCpH3 Hr9E6fyfGmJZMXizG3FO11Icpm2JxHFrKyl4BG+bmWjN7kCFLdKvhU2MSyLgDKm4bNHDoz E/7PYtMiJi8VIV6DiTkU5/nizFJ0cVk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729563229; a=rsa-sha256; cv=none; b=flgOS/vMW5LLfofx8QJPmWb/J9V4pPIYpm50FrmMfNL3ahXE8fF27Hyq7YA0hPyanQCSSX sGbtq1crvSCfvbTH85HQB8ZK/weQVbGIRj+MvqLxdSnwqUImuYEYJ/TLR8c4mOgIY6tSQt psow8mBKgewfNVZ0ikYA289tJqzVzG8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cKGXCrBb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev Date: Tue, 22 Oct 2024 02:16:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729563392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PABLEHqBbAv1qMkTJjeTZTBdgWmacrEo5Nko1BqIF7g=; b=cKGXCrBbe7avH8stOZa0m3hcV2m3v5VtvuUVlDbRpzzJP/zprBM1TZ4J98IephmMqZZAdT Ca1mUUAC7DnmWDhLPTgmp6GkYWO3553X7ClvIUaoGEpv8l/26d43hncbDMviQQy7uk1DHE tQanb2y8UP0dpEQrFFpdQcov6WZ57Rw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Hugh Dickins Cc: Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Matthew Wilcox , Shakeel Butt Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E9328C0012 X-Stat-Signature: ntsrko9xqe6tc73tbmj6bwsb4d4gpimb X-Rspam-User: X-HE-Tag: 1729563375-684941 X-HE-Meta: U2FsdGVkX18EgxwFR/8tYshvgO4x8Q5WtAisJjwjoH+T32VZSepz/bq6gmjx/IXSYC+gX/p3rPafLEl0H3r56v6JbcYD1NngJPySzcoOsxKhKM5tZBpa2S1BgCCVlPp+xRNEBAQSWB+YDIWcqpMTM2ISdMFiNX8I7XbgEIxP3byicLJ279gRNNMPOiGX8Muv0jObJKkZCMe8IX4Q2XJeICpKRhPB2+bNu1bVK3EoyzcxclS9ePbTJQj8cP13sEas26f1CxmoKQzOn/FubXqF7KzF9Lr/FgPEViB6AJXM6pB8HFjYzHTFvwBbbOxo4UIUqoLRiN30Rl2Vsv5KPL1koPgzTMshnkYC43tipFMoM+ZiO6kXFCrCTg8peCbCgd5Obc/p5jvWcmTN4gg+i0w6bWk1hDPJp5GlSFAuEwxnJ2GP1o7ucUkLVcYhNv+Y3VaWQoVgIzAuHuDqF4pYvTII+aNDfDWwJUWKKvRTs8KFbvmXNeLs0Ui+g4jB2QaBYFAeivyhW52+NhrxDcMriupigN0Hdv4eyD6dwl3zeTdzOboOuSidtTG3s/Oy0uKzBu1dMcyfWAkZmaXE3rWB0Ns3KaBvvLZKQJf4d+oZuFx2nceXGuDiPWGL/KKPoe1lcKhWTwxjOIC4MbKPVh4VAgoFF5kNLRsLYNcr1ZInrQwYdqsS9fQDZFfd6qYN5iuYf/QcfBzjThHFzsJVIP1d9qiX0eMKFGntCVeHoXye49DAT2U4BUXIXOESOzrTtY1tGOzy1lLVPuFGaSXJeK8Bfk8oKUeo22wXHnSdiRpHFWuVliz1oraFAh3zCAONfC0BUqhUUElJttT6nviz/52i7X3vRSwvNFBIXIJfnoteFk+Ws6TEjfSRp0hFkkYymRQSCpkhveyQFE8n7vRpymXZm6lsxu3yvskXG1WC2xtX0KHBEdPQG3oLax5q/IQJyTGMkZc86dMm5WYQGtoMsn7T4B+ JUZa+eZE QENHh5Q4aWUWqFLlLszysIyf35lrihOC/VUGmeiHslXKEtKP7TYZV9QzhNoVHY6WLEIT+acoMpJtgwKi1TQQPq8JJSt0ZASCtaJOv+9vpk95uRl6rXcIZ6CtzzwrSb03S++Z9ffcOuZkzD6wCcwI2DOCL22uoZNnWoL3sNTxeCMpB1g/nUPMJXexA272GoL3HFdPHL2WTNoiWDHF/4kZCF9mWEpcefWSqt85aYZWT2+tfHXU1wdUszGd1U+jjVk5QagomOKcp1sRa15hqBIZsmCnIpWK3DdudKHzIygWFHcTjbovcsQP+hYC/8PXm2kB3Hvgy093kBJnds4QQO6I3M4rpmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 12:49:28PM -0700, Hugh Dickins wrote: > On Mon, 21 Oct 2024, Roman Gushchin wrote: > > > Syzbot reported a bad page state problem caused by a page > > being freed using free_page() still having a mlocked flag at > > free_pages_prepare() stage: > > > > BUG: Bad page state in process syz.0.15 pfn:1137bb > > page: refcount:0 mapcount:0 mapping:0000000000000000 index:0xffff8881137bb870 pfn:0x1137bb > > flags: 0x400000000080000(mlocked|node=0|zone=1) > > raw: 0400000000080000 0000000000000000 dead000000000122 0000000000000000 > > raw: ffff8881137bb870 0000000000000000 00000000ffffffff 0000000000000000 > > page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set > > page_owner tracks the page as allocated > > page last allocated via order 0, migratetype Unmovable, gfp_mask > > 0x400dc0(GFP_KERNEL_ACCOUNT|__GFP_ZERO), pid 3005, tgid > > 3004 (syz.0.15), ts 61546 608067, free_ts 61390082085 > > set_page_owner include/linux/page_owner.h:32 [inline] > > post_alloc_hook+0x1f3/0x230 mm/page_alloc.c:1537 > > prep_new_page mm/page_alloc.c:1545 [inline] > > get_page_from_freelist+0x3008/0x31f0 mm/page_alloc.c:3457 > > __alloc_pages_noprof+0x292/0x7b0 mm/page_alloc.c:4733 > > alloc_pages_mpol_noprof+0x3e8/0x630 mm/mempolicy.c:2265 > > kvm_coalesced_mmio_init+0x1f/0xf0 virt/kvm/coalesced_mmio.c:99 > > kvm_create_vm virt/kvm/kvm_main.c:1235 [inline] > > kvm_dev_ioctl_create_vm virt/kvm/kvm_main.c:5500 [inline] > > kvm_dev_ioctl+0x13bb/0x2320 virt/kvm/kvm_main.c:5542 > > vfs_ioctl fs/ioctl.c:51 [inline] > > __do_sys_ioctl fs/ioctl.c:907 [inline] > > __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 > > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > > do_syscall_64+0x69/0x110 arch/x86/entry/common.c:83 > > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > page last free pid 951 tgid 951 stack trace: > > reset_page_owner include/linux/page_owner.h:25 [inline] > > free_pages_prepare mm/page_alloc.c:1108 [inline] > > free_unref_page+0xcb1/0xf00 mm/page_alloc.c:2638 > > vfree+0x181/0x2e0 mm/vmalloc.c:3361 > > delayed_vfree_work+0x56/0x80 mm/vmalloc.c:3282 > > process_one_work kernel/workqueue.c:3229 [inline] > > process_scheduled_works+0xa5c/0x17a0 kernel/workqueue.c:3310 > > worker_thread+0xa2b/0xf70 kernel/workqueue.c:3391 > > kthread+0x2df/0x370 kernel/kthread.c:389 > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > A reproducer is available here: > > https://syzkaller.appspot.com/x/repro.c?x=1437939f980000 > > > > The problem was originally introduced by > > commit b109b87050df ("mm/munlock: replace clear_page_mlock() by final > > clearance"): it was handling focused on handling pagecache > > and anonymous memory and wasn't suitable for lower level > > get_page()/free_page() API's used for example by KVM, as with > > this reproducer. > > > > Fix it by moving the mlocked flag clearance down to > > free_page_prepare(). > > > > The bug itself if fairly old and harmless (aside from generating these > > warnings). > > > > Closes: https://syzkaller.appspot.com/x/report.txt?x=169a47d0580000 > > Fixes: b109b87050df ("mm/munlock: replace clear_page_mlock() by final clearance") > > Signed-off-by: Roman Gushchin > > Cc: > > Cc: Hugh Dickins > > Acked-by: Hugh Dickins > > Thanks Roman - I'd been preparing a similar patch, so agree that this is > the right fix. Thank you! > I don't think there's any need to change your text, but > let me remind us that any "Bad page" report stops that page from being > allocated again (because it's in an undefined, potentially dangerous > state): so does amount to a small memory leak even if otherwise harmless. It looks like I need to post v3 as soon as I get a publicly available syzkaller report, so I'll add this to the commit log. Thanks!