From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB689D17159 for ; Tue, 22 Oct 2024 02:11:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44B916B00A7; Mon, 21 Oct 2024 22:11:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FBC46B00A9; Mon, 21 Oct 2024 22:11:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EACE6B00AA; Mon, 21 Oct 2024 22:11:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B2436B00A7 for ; Mon, 21 Oct 2024 22:11:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8A12CA1C34 for ; Tue, 22 Oct 2024 02:10:49 +0000 (UTC) X-FDA: 82699610364.08.8F6130A Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf02.hostedemail.com (Postfix) with ESMTP id 1C13A80006 for ; Tue, 22 Oct 2024 02:10:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gArLKNrC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729563039; a=rsa-sha256; cv=none; b=h48XZUChhkZMnBoX5ge2HvD+eAbEqLYUSslPvcW6cv2+ESAa5MVdzXNA1Rw/yScPvGT/jf 9NkbQsRwBQnGPC7l0db8D3I/ycrXbgiMlJVwvMKsbpvrtjHwh5QKcjUu5SGXZbuKFytpZI cP/aM8gbK91cK5txNAFSPOliJsOy8WA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gArLKNrC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729563039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=33cM6FKw0K/vjsCwdtJ9HyCY2bf6tJBVkKFfDfvbkfE=; b=AJN8HXxgxETESNVQQ0DsZAPwxPONjzTusnC3eMHDd3YTcjNQ1vbood8LHI0e1j+lU8ijhb ajgSs9pLrDuWHEj2KxwHZAu2m6ku7dRZYFzZTlbQ7BHEm9jUBkl62Mw2A20JSlZlI+VNMl KnlVQoMkyO3ocpwMU3hb87aPL+9bHdY= Date: Tue, 22 Oct 2024 02:11:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729563072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33cM6FKw0K/vjsCwdtJ9HyCY2bf6tJBVkKFfDfvbkfE=; b=gArLKNrC0peponoFd/AB6hdq3NsUyCWm8XfgN5deXJeCl36mCchZXTFvevtmIzr2is3Ave y3AZax/TI0TD09FzLEh0ZdU75cT3MfiYzp76FNwhMa3WTzRzsn4lTf+7Xwj6AOjfK/R+n+ jSzORoOk32bGGA53vv+AhLGnaqMAwQk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hugh Dickins , Matthew Wilcox Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: mxdwao3q78n3g16jnkuzbqtt6fsghwgk X-Rspamd-Queue-Id: 1C13A80006 X-Rspamd-Server: rspam02 X-HE-Tag: 1729563046-345084 X-HE-Meta: U2FsdGVkX1+JdxgVodpcK1AlJBqD9UDqs3nDbK2wPMUBUJzwL3ra7iANpW2f8+cMCbK1E1Dds9Eg3JPh83zmDOfqxTeHjVQIz4T2TPttgZd+KfDaNqbt7Q414QvojHNRMZLFRB501hlMOAPEuTDJMGRrejk9LzJPJRTg8K8jEG0BtiW8FL1nsblJxxiSDpfFg8N0FwNfK4KPfkwPByEFmDMI7R+NIP5W9lkPv8I5w0Nr4Y7OpeaVHHPw/ppivsLUjxQpysGtVgA9xmEypMOKpYuodXFzmc5kMjsLLm7xAlxoSu0namU9Ode4a9wYWEcU7L0aqJTSgjK/RzEzzUclUUUO5SpLvFG4+Ewik2lc3NnzMfjd5TPFTPnn/O61kLrg92ZZ7awo/tKGNDR5cFWQWQ9RsGGB+mOwpuTHeIWo5LGHH27O8hmJC+3lQkzprBZ7vnnF2kECbNPF0zMKGOYplZDniS/SxDrQONQyPxNnaqZXvOpXuRsdtEiT2gsFiQPtE9T+FElnVHKfTm5P4NQVzfzwRaPjStqKsYd90CAn6DqRxV7Ekaa6Avg7au0NtaEStuVHHPU77VdNE1e7pQJRNintaRNzEk4pkPu/5SbYUsmMcDuGBCK7+xBIDlWmp1Un0QJd1yMdD+Tdssy+756HqkdQNRStxZewr5TovZi3TAWD+EC9iDZHtc9Ip1sD59WXjYQyRnttjhm3K96KHbRI5fHjnfKiRP21tgF9zdQUPfBx1Cyb2pPs5C2b1CyqspZA4zyNzOyy8vDlz3TCMGzEupc6waH1Rh9SG0KwiJtJkRfFxlVZE8bugrb2hEd/Xez7E3nax2Ap72BrBVEn4Q1X1WTe/lYXjg7v183M8Cb1yzMzMiXX2wHFuREJ92Nql85SwNKZQBPVPcmDEvaUs3+Xha4BJaPn6ikNVtD4RE687ZOrHb2Q0G0alMEbBJP3m98Dy0S1eF4Ly2KSyXp/ndB prfGVZE9 4EOp8s/nIsQcdl7wYkngfOyXey8+r5gWWc/qlqDqEa+2qBJ76LVZTZkX/9eiyHsVa4373WVdTvjvJEIdjOWyf6ORKng4NO2kxL4wJfReKvq2nCJZ8MpK2W/HIA9fcGB3cwSgIGsQiBwuzgu0V6srH52g5XnyTKXXniPw60hf3dX1WwcaK200fl86TvbcJBFTtx635lh36p3FV41t7f7R55N01IdIRM3fTtcczi0yyLsZpXFav3R1mihUKMnObtvyFmRrtz/PssAjvlTiGD9PC+6ZzXo7BZnH400Wh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 10:57:35AM -0700, Shakeel Butt wrote: > On Mon, Oct 21, 2024 at 05:34:55PM GMT, Roman Gushchin wrote: > > Syzbot reported a bad page state problem caused by a page > > being freed using free_page() still having a mlocked flag at > > free_pages_prepare() stage: > > > > BUG: Bad page state in process syz.0.15 pfn:1137bb > > page: refcount:0 mapcount:0 mapping:0000000000000000 index:0xffff8881137bb870 pfn:0x1137bb > > flags: 0x400000000080000(mlocked|node=0|zone=1) > > raw: 0400000000080000 0000000000000000 dead000000000122 0000000000000000 > > raw: ffff8881137bb870 0000000000000000 00000000ffffffff 0000000000000000 > > page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set > > page_owner tracks the page as allocated > > page last allocated via order 0, migratetype Unmovable, gfp_mask > > 0x400dc0(GFP_KERNEL_ACCOUNT|__GFP_ZERO), pid 3005, tgid > > 3004 (syz.0.15), ts 61546 608067, free_ts 61390082085 > > set_page_owner include/linux/page_owner.h:32 [inline] > > post_alloc_hook+0x1f3/0x230 mm/page_alloc.c:1537 > > prep_new_page mm/page_alloc.c:1545 [inline] > > get_page_from_freelist+0x3008/0x31f0 mm/page_alloc.c:3457 > > __alloc_pages_noprof+0x292/0x7b0 mm/page_alloc.c:4733 > > alloc_pages_mpol_noprof+0x3e8/0x630 mm/mempolicy.c:2265 > > kvm_coalesced_mmio_init+0x1f/0xf0 virt/kvm/coalesced_mmio.c:99 > > kvm_create_vm virt/kvm/kvm_main.c:1235 [inline] > > kvm_dev_ioctl_create_vm virt/kvm/kvm_main.c:5500 [inline] > > kvm_dev_ioctl+0x13bb/0x2320 virt/kvm/kvm_main.c:5542 > > vfs_ioctl fs/ioctl.c:51 [inline] > > __do_sys_ioctl fs/ioctl.c:907 [inline] > > __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 > > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > > do_syscall_64+0x69/0x110 arch/x86/entry/common.c:83 > > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > page last free pid 951 tgid 951 stack trace: > > reset_page_owner include/linux/page_owner.h:25 [inline] > > free_pages_prepare mm/page_alloc.c:1108 [inline] > > free_unref_page+0xcb1/0xf00 mm/page_alloc.c:2638 > > vfree+0x181/0x2e0 mm/vmalloc.c:3361 > > delayed_vfree_work+0x56/0x80 mm/vmalloc.c:3282 > > process_one_work kernel/workqueue.c:3229 [inline] > > process_scheduled_works+0xa5c/0x17a0 kernel/workqueue.c:3310 > > worker_thread+0xa2b/0xf70 kernel/workqueue.c:3391 > > kthread+0x2df/0x370 kernel/kthread.c:389 > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > A reproducer is available here: > > https://syzkaller.appspot.com/x/repro.c?x=1437939f980000 > > > > The problem was originally introduced by > > commit b109b87050df ("mm/munlock: replace clear_page_mlock() by final > > clearance"): it was handling focused on handling pagecache > > and anonymous memory and wasn't suitable for lower level > > get_page()/free_page() API's used for example by KVM, as with > > this reproducer. > > > > Fix it by moving the mlocked flag clearance down to > > free_page_prepare(). > > > > The bug itself if fairly old and harmless (aside from generating these > > warnings). > > > > Closes: https://syzkaller.appspot.com/x/report.txt?x=169a47d0580000 > > Can you open the access to the syzbot report? > Unfortunately I can't, but I asked the syzkaller team to run the reproducer against upsteam again and generate a publicly available report.