From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE108D3C935 for ; Mon, 21 Oct 2024 17:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 698696B0088; Mon, 21 Oct 2024 13:26:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 648AD6B0092; Mon, 21 Oct 2024 13:26:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 510066B0093; Mon, 21 Oct 2024 13:26:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31A186B0088 for ; Mon, 21 Oct 2024 13:26:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4CA901C754B for ; Mon, 21 Oct 2024 17:25:42 +0000 (UTC) X-FDA: 82698286272.20.0349520 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf29.hostedemail.com (Postfix) with ESMTP id D271A120006 for ; Mon, 21 Oct 2024 17:25:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PUqSkJYb; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729531407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RFxEseBMRL9TJroZfrqPEG15hgUXenLAoHO1VI1TokI=; b=ksDQnOtmDRkgNlBHtKqx76OyJtWkomzNLzJrONPzsfuyDZ14E6Vlvnb/UCNnj0TB/LpwCE UedAaVmznm8xNg9fvs7sCUq1Wrpcln2wHdPK1LVZuuqhMt8MTrpYr659Pb6SYYgbLSBXHh TXKiA6bdMloSRwfRZx+yvN5YHtD0qbc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729531407; a=rsa-sha256; cv=none; b=Hyo5LWoemzzkc1x7+ckYCfiZiOkfeKr7zFGr6n1h89QZRJE9lRUVCc5jKmlbN3amgrQG4u cNTRcK87j2P/0YfWPjpNx1ZiKKJL5bz9Rxv6AwoBrPKSwYqeI/Ijl8cDrqgoSO+WqF5z5j lz/S8AGeYLs/aJ+ZN25h9ydqEbi2bEI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PUqSkJYb; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso704169566b.1 for ; Mon, 21 Oct 2024 10:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729531556; x=1730136356; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RFxEseBMRL9TJroZfrqPEG15hgUXenLAoHO1VI1TokI=; b=PUqSkJYbKspMLbA4a4mREiPeO47pMOHtgko6Z8+0lvP4jzdQqg73jXfsV6QVBHHZ+I fUl45Lv7G2uecwdoU2pkIIKxsbLeGl7ykjemZN1IpgJfK5JUdtlYXkXnCUaZpGqky5Df zW446HVlrsjb76kbVWaU4kgwWv1t1iqbb1NOKIQGa4gmipC4Cy1Fwu9KxvOqz/0ahsiF 2UOKXZr/s92TgmS7FaNBV2AlAYq6EaoApKYYsumn+nb0yEY7Z93xGN87E9TBjM69MXjz itMZX8IywaU/1UOgTbM24Uuugz+6EKQG+YMt3hjHGbODk+B4fDdijiGPmDwh09c8SBEJ rIXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729531556; x=1730136356; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RFxEseBMRL9TJroZfrqPEG15hgUXenLAoHO1VI1TokI=; b=JpVJ5Qgg5jeV9IfnlZ4gNP6LI2WFwOIXpK8MbshbvQMMj8KU/df/X0JpNgvlLaygWu 62+IGzgpltratojMJ4H8POwMlPkABP4rall5RuOcUnULCPRbG3ZXO2n5ehceWdNYPxfM CtmjOsQfJ1piE9ATswt/Fmc6l+B893R6Su/BMvmDiaRnqcNKt5nkbw/e5Z/7uUU8GaLM 62kbeSGALVUab4bWOCNC/USf8RMev32lpZwpVqRoRhAnRJpWvmf4chx/aeWJkSaJHEy+ F5U1v1fCIVZjTGYGCLKMgPY9KMg+6I/kVl1ZhwzxEkjDVUT1vr1tVy2x8DOprVc959KR KZMA== X-Forwarded-Encrypted: i=1; AJvYcCV0EMZfh8YYVp2jys0Qk9//zTZeoPcuilG8fjxb91kIMoIgwHnKMxi8u9d9ueXGLATkLzIZQecAWQ==@kvack.org X-Gm-Message-State: AOJu0YzLDYyZXTZ382x9fa2/W642gg+qgQuBBh4q92hfGmgg1u8lcYXC zoZQfVF6s+S2W3QCbZ1pNEGTImUuCkW9EdIOKXyMnum5vO+1arCec068GJZcgOw= X-Google-Smtp-Source: AGHT+IH4n4wPePD3+2JbCmoNPK4uvGmV017SEx6TMLsnKOM7T6k4IpmtJaKQsslH7wxKKLfXYiWQMg== X-Received: by 2002:a17:907:3ea1:b0:a99:529d:81ae with SMTP id a640c23a62f3a-a9a69ca14b7mr1332721566b.55.1729531556506; Mon, 21 Oct 2024 10:25:56 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91370723sm230139066b.100.2024.10.21.10.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 10:25:56 -0700 (PDT) Date: Mon, 21 Oct 2024 19:25:55 +0200 From: Michal Hocko To: Yu Zhao Cc: Andrew Morton , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Link Lin Subject: Re: [PATCH mm-unstable v1] mm/page_alloc: try not to overestimate free highatomic Message-ID: References: <20241020051315.356103-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D271A120006 X-Stat-Signature: xigaicm51kgyxs14r1t7xrpa539at4rr X-HE-Tag: 1729531537-189529 X-HE-Meta: U2FsdGVkX19vfKTQFPuTdoFRXm7keFHNZjjaPEJ7ffLwkjj7aYCvOV5hLnILpLAlaNzhWoIs80ERC7tNxY4VR3Jmhf2qOTNREeJpmTwbryYziE1Wkq5lmPXfpp8ilyozgATZ2sPoMb1TRrp+9hdExV71BNz2VxkdfP/ZqqmWEh+DTwRtyP99K3KqUmsOkIkY/wlSGC5CLEivsSFzGwFhG6rJts+PdtD57Q19o9NUFsDvfRR2QcDQ3OF9bmd9ozcm7JKYPsdXp/0akdqSW7VMIoc48hqupG2bG5aeQnDL1ET7QONkEnrzPy9Rw887OHEkgaoBb6I5I3LHXfFc9HtF/ez6oT9rDCvaY5btTQpIGWQSqmCJ2cxqyTXB+sb0ggjSRPkaXRXxar51NYtgb1ldkc5a+DkesQaN4Ysu4RJN/YzanJTKHZWzcCLpvvP4vOpzy1QIw6+J0kIfYd6T5AnK7djEridsFGs4M6uLUzfdAUlxepU49Sl3+ks2+BM+1Kbieq1jiq+gPILeoF0IQIFsZunH91FTQ16Bzm5z8ZZ1MC/3UWazXNXMkZr1tnUlHXFvbQ+hRxO43+t8rlhcerlJDLNUy2FiER8gTGDUaTGWt2pzByBVankzY6zmhMTgkBmIXz52b9+tJ4EfA4s9vFNZo0gs/kD0X+HJBKwByJPv/027YNnuv7Mp8SHSl8G80TW5FFXZG/tq1LKLCSY2bLpEtB9RnWG+3hDEFNf3bVvECFzx+2TbXo7M+s/p0TasRa3mm08pvG3mIZdphxjW1EfG+fNInfpmM7k+9At6pRvOtZvQWS9hDRraIVFVse6oz9z6Z5G0CmY9l3yih0+TePLljZx94BfTKOy6sG8lQ/HU/OFPG+MJaWYsxJwXhVNFTYfg35UmRossfXKlqSc+wnuBuHsIA9lKp7LEPzSpd4EZot5VAT3bSn/qrjZ4PQMpeMcoWtDoEugj225FR0iURt0 mXg5Agl8 WCsks51HdUuJN08pGRCr4y8of4eour6/9+bRNX7E6wj2ndN6BLo6t+qNtkOU5gb2/f0YstdRm8hcC94IqyuwUQzqkLWhb/MMZgSS/wtKlqM7uNXzx2bbqO+8b5+k+Pj2PLs0g20X1cZDh+Z6Bz0Xb/GBnzwpQwcYiIaSlB9TU7o7SFeHhdnY57ddYmYLGenaBAbFe3q6GoLCKdITfmdZUoBV7WmXWCOzFiLtYdglR+zV1KQ2YZk2XD3WVnNmnA5hTy7LzOSJXVd+s1AvGqMcr9kmusTyVQbILVbVLHARGwhHcFHlFtzBGotYY6GJPzbe7o3Zn9OGbCKQk7OsH2UM7fXEKRuyaf/JyhaBjq1ueFrN9dDMMsgLbmGIDhLovlvcKbOgiToJ3KquFvhxXtqIIrsFLhs9TjBGc8MLxafFeb6WcmJrMmHpC3vR+cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000139, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 21-10-24 11:10:50, Yu Zhao wrote: > On Mon, Oct 21, 2024 at 2:13 AM Michal Hocko wrote: > > > > On Sat 19-10-24 23:13:15, Yu Zhao wrote: > > > OOM kills due to vastly overestimated free highatomic reserves were > > > observed: > > > > > > ... invoked oom-killer: gfp_mask=0x100cca(GFP_HIGHUSER_MOVABLE), order=0 ... > > > Node 0 Normal free:1482936kB boost:0kB min:410416kB low:739404kB high:1068392kB reserved_highatomic:1073152KB ... > > > Node 0 Normal: 1292*4kB (ME) 1920*8kB (E) 383*16kB (UE) 220*32kB (ME) 340*64kB (E) 2155*128kB (UE) 3243*256kB (UE) 615*512kB (U) 1*1024kB (M) 0*2048kB 0*4096kB = 1477408kB > > > > > > The second line above shows that the OOM kill was due to the following > > > condition: > > > > > > free (1482936kB) - reserved_highatomic (1073152kB) = 409784KB < min (410416kB) > > > > > > And the third line shows there were no free pages in any > > > MIGRATE_HIGHATOMIC pageblocks, which otherwise would show up as type > > > 'H'. Therefore __zone_watermark_unusable_free() overestimated free > > > highatomic reserves. IOW, it underestimated the usable free memory by > > > over 1GB, which resulted in the unnecessary OOM kill. > > > > Why doesn't unreserve_highatomic_pageblock deal with this situation? > > The current behavior of unreserve_highatomic_pageblock() seems WAI to > me: it unreserves highatomic pageblocks that contain *free* pages so > that those pages can become usable to others. There is nothing to > unreserve when they have no free pages. I do not follow. How can you have reserved highatomic pages of that size without having page blocks with free memory. In other words is this an accounting problem or reserves problem? This is not really clear from your description. -- Michal Hocko SUSE Labs