From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5E4D3C92D for ; Mon, 21 Oct 2024 17:18:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 079AA6B0088; Mon, 21 Oct 2024 13:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0281B6B0092; Mon, 21 Oct 2024 13:18:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E587D6B0093; Mon, 21 Oct 2024 13:18:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C6F7B6B0088 for ; Mon, 21 Oct 2024 13:18:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C0678161AA4 for ; Mon, 21 Oct 2024 17:17:44 +0000 (UTC) X-FDA: 82698266532.08.62552DB Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf12.hostedemail.com (Postfix) with ESMTP id 66E194000E for ; Mon, 21 Oct 2024 17:17:53 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=F7vpcAWe; spf=pass (imf12.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729530931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4SNZei01JeOBQ15iTYNw9RzviG1U9b/t4xS90culTc=; b=yWIF6NNY4HlA7x/KCaWNOOA7NeWOJ5vK5codzkrB12MmbFne/4+y099FYdjCnzId19gz0H VmMsP9kqLsU1x/G5a2sdzk+5t1cc6ZaD8rvJSetOdhnDpOxSl0AV6eZsx/GVvQOQxuQxLv 0FOuIiALcIVcBdgIyXRmlTAFYQ+0kXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729530931; a=rsa-sha256; cv=none; b=XirqMKtgkzeuQPzaimdFVcLuLRpLTzATX+oG4DwJjXcIgbd+xktJde4mYMg902flz+1AvW DsleSJbqf0RggRJiHksdgH6i+u5BJQO1hWb8ncKqrW7u6vF3JYUvsyG06DrHIpEKmvcPma UxSATgN7JuY8ASZYEJpm08NgqDwFHlU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=F7vpcAWe; spf=pass (imf12.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 21 Oct 2024 17:17:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729531077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L4SNZei01JeOBQ15iTYNw9RzviG1U9b/t4xS90culTc=; b=F7vpcAWerwfV9NLZf23xW8XdUGEVI21G4wiz6MYWyOhKiEcKzzcwMjtXTa8TJqXMCgwntJ yVyqmhBJcd9BfeZMJr7e1/JQMWpfqnR3BmZME0k8bi7pe5JkPsHnNxcyxwKamrmLGkvK07 SOaApyeYvQ0hFeDVGijl40JWfIF3ptU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hugh Dickins , Matthew Wilcox Subject: Re: [PATCH] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021164837.2681358-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 66E194000E X-Stat-Signature: b3efud8jkss3pi51jz69rumt3dt9fbfb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729531073-237837 X-HE-Meta: U2FsdGVkX18JS6J2W1z91zCGpT2yLBqqpezq25WKi1LsMxELTjtcGoZ61pQrEdEfIlgiobS9E1HdfHKVxrhOjREZec5wlnMvhVKw2bIs97Xx0wOYW1F+TASop+JmfgqXQei0J2U5DmHhMiiGBnjkpFZ7zxNgiABTczQZIopwUP/cNOoWCK2xgGM7Dp4qDRDHzGKdKSYbLRtQM0SEuefdSrMl2qJrdMmo32x+KwMmnsGjzUz+yHx8iPYLbBVYRTuMNEETDaf61KqW4j7M6cJyB3RF6Gzpet5j6lz++B944GXNjH8jKSHQXRbf5PifIAu3l6dLJJOes6RnSbHX/pRhb9qxpyLZui27I8YnTacBHqVxdFFMZFNhZSMx7akijxO/foA8fUV1lqlyPKA3+J9USj7ZpHzU9rs+kybrblfhdZKL8qy/RuWY/uIyKts56148FxSsSGXSmvGSvWRYyj+wysYD+XvP2k8zcwL6lbG3pwo2udATOAYC8T/q7WHaJTDn+ltjIBk6t8P6G7oL4A5TlmEmtOTQ/bECGJG/CkpeWX1H7lca/tZYnTeNjk/EBJC1cr+eHOhkMjpSMnEgY4ORfUkyAvuZheJJ2pGCxMrfGWK/SQ3vQPt3WyuVS32TaYPopemD9mu/wc7ODdabM2v3Jy3ox1g44fceuvoiOwu9kysHdWwC4CcXUrXnw9s0P9Y/TTKPHAhmWN5GkYYtd0pyI5vmxbfhK2iOs5xSXaLII3Cae9VutdLSK4N5O3wW4HjmfEjUMZDG3gwt2By9SdwOyZDQGmkdu2w6SUZVrHibnC7ejmM+UWDbrljTL7D+laIZaFk7JvQMnfx05FtKX0LH7chVJN4mKpfLK6NFI6WYoIY3jANX4osGcLDKH5EutXezWQCOGqQZTJgdRkeLApOIlLo/udSdRu2jcLw0X/HL1BYoZLCyyWv7v+u1wCQJvubVtr7J2r2eiXq2VOVA7Co +Kf0Y1QV f6oM2KLEY54ZyFgqnkq/dvDzaRYEGLjuQLB9e0f+TNCoqwaKQaaQ8EFAvpQaLD5BWiMaRYGO7b+sHNpVVemiZ7tRcT6hS51tCVqL9X1xi1t+qW/2jvUu8mT73irtDWTPi810bpbhq/Kc53K47Pyx0o5fYmI/xWYj0WVo3hGenF7tLGtQsNh+k0Zglyhqno5VuoyXIGmLOEgJmHURCtyLgq0vh5pSLpnWcCdpdZ7oLriHS3JwSRyrqLhoSelv03iHS/mBSA1OD3X0BsDV1ToR36/3Ifsp3+j1Q/mfyXO6beD/HQ0fkj+0F2CnYKuYl0R/VFs9bevS1FztFNVDsSTMeyurJTQMLmTZS89FCf8gAHzDdPE8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 07:01:59PM +0200, Vlastimil Babka wrote: > On 10/21/24 18:48, Roman Gushchin wrote: > > Syzbot reported [1] a bad page state problem caused by a page > > being freed using free_page() still having a mlocked flag at > > free_pages_prepare() stage: > > > > BUG: Bad page state in process syz.0.15 pfn:1137bb > > page: refcount:0 mapcount:0 mapping:0000000000000000 index:0xffff8881137bb870 pfn:0x1137bb > > flags: 0x400000000080000(mlocked|node=0|zone=1) > > raw: 0400000000080000 0000000000000000 dead000000000122 0000000000000000 > > raw: ffff8881137bb870 0000000000000000 00000000ffffffff 0000000000000000 > > page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set > > page_owner tracks the page as allocated > > page last allocated via order 0, migratetype Unmovable, gfp_mask > > 0x400dc0(GFP_KERNEL_ACCOUNT|__GFP_ZERO), pid 3005, tgid > > 3004 (syz.0.15), ts 61546 608067, free_ts 61390082085 > > set_page_owner include/linux/page_owner.h:32 [inline] > > post_alloc_hook+0x1f3/0x230 mm/page_alloc.c:1537 > > prep_new_page mm/page_alloc.c:1545 [inline] > > get_page_from_freelist+0x3008/0x31f0 mm/page_alloc.c:3457 > > __alloc_pages_noprof+0x292/0x7b0 mm/page_alloc.c:4733 > > alloc_pages_mpol_noprof+0x3e8/0x630 mm/mempolicy.c:2265 > > kvm_coalesced_mmio_init+0x1f/0xf0 virt/kvm/coalesced_mmio.c:99 > > kvm_create_vm virt/kvm/kvm_main.c:1235 [inline] > > kvm_dev_ioctl_create_vm virt/kvm/kvm_main.c:5500 [inline] > > kvm_dev_ioctl+0x13bb/0x2320 virt/kvm/kvm_main.c:5542 > > vfs_ioctl fs/ioctl.c:51 [inline] > > __do_sys_ioctl fs/ioctl.c:907 [inline] > > __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 > > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > > do_syscall_64+0x69/0x110 arch/x86/entry/common.c:83 > > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > page last free pid 951 tgid 951 stack trace: > > reset_page_owner include/linux/page_owner.h:25 [inline] > > free_pages_prepare mm/page_alloc.c:1108 [inline] > > free_unref_page+0xcb1/0xf00 mm/page_alloc.c:2638 > > vfree+0x181/0x2e0 mm/vmalloc.c:3361 > > delayed_vfree_work+0x56/0x80 mm/vmalloc.c:3282 > > process_one_work kernel/workqueue.c:3229 [inline] > > process_scheduled_works+0xa5c/0x17a0 kernel/workqueue.c:3310 > > worker_thread+0xa2b/0xf70 kernel/workqueue.c:3391 > > kthread+0x2df/0x370 kernel/kthread.c:389 > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > The problem was originally introduced by > > commit b109b87050df ("mm/munlock: replace clear_page_mlock() by final > > clearance"): it was handling focused on handling pagecache > > and anonymous memory and wasn't suitable for lower level > > get_page()/free_page() API's used for example by KVM, as with > > this reproducer. > > Does that mean KVM is mlocking pages that are not pagecache nor anonymous, > thus not LRU? How and why (and since when) is that done? KVM allows to mmap and mlock several pages allocated directly. Please, take a look at the reproducer: https://syzkaller.appspot.com/x/repro.c?x=1437939f980000 > > > Fix it by moving the mlocked flag clearance down to > > free_page_prepare(). > > > > The bug itself if fairly old and harmless (aside from generating these > > warnings), so the stable backport is likely not justified. > > But since there's a Cc: stable below, it will be backported :) My bad, I changed my mind in the last minute and added Cc: stable but forgot to drop this sentence. > > > Closes: https://syzkaller.appspot.com/x/report.txt?x=169a47d0580000 > > Fixes: b109b87050df ("mm/munlock: replace clear_page_mlock() by final clearance") > > Signed-off-by: Roman Gushchin > > Cc: > > Cc: Hugh Dickins > > Cc: Matthew Wilcox > > --- > > mm/page_alloc.c | 9 +++++++++ > > mm/swap.c | 14 -------------- > > 2 files changed, 9 insertions(+), 14 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index bc55d39eb372..24200651ad92 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1044,6 +1044,7 @@ __always_inline bool free_pages_prepare(struct page *page, > > bool skip_kasan_poison = should_skip_kasan_poison(page); > > bool init = want_init_on_free(); > > bool compound = PageCompound(page); > > + struct folio *folio = page_folio(page); > > > > VM_BUG_ON_PAGE(PageTail(page), page); > > > > @@ -1053,6 +1054,14 @@ __always_inline bool free_pages_prepare(struct page *page, > > if (memcg_kmem_online() && PageMemcgKmem(page)) > > __memcg_kmem_uncharge_page(page, order); > > > > + if (unlikely(folio_test_mlocked(folio))) { > > + long nr_pages = folio_nr_pages(folio); > > + > > + __folio_clear_mlocked(folio); > > + zone_stat_mod_folio(folio, NR_MLOCK, -nr_pages); > > + count_vm_events(UNEVICTABLE_PGCLEARED, nr_pages); > > + } > > Why drop the useful comment? Agree. Sounds like I need to restore the comment, drop no stable backport recommendation and send v2. Thank you for taking a look!