From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45994D17130 for ; Mon, 21 Oct 2024 20:34:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B98606B0099; Mon, 21 Oct 2024 16:34:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47286B009A; Mon, 21 Oct 2024 16:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A35FB6B009B; Mon, 21 Oct 2024 16:34:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 84C986B0099 for ; Mon, 21 Oct 2024 16:34:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6E81C41BAC for ; Mon, 21 Oct 2024 20:34:22 +0000 (UTC) X-FDA: 82698762006.16.7C25FD1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id ED2F7100020 for ; Mon, 21 Oct 2024 20:33:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="X6pGH1/t"; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729542819; a=rsa-sha256; cv=none; b=tm05UVhoFnF+iMiBWvm8Ww4Qh/fjKpWF60F3y3vSmjI7o/kvlAE5UdQh1Y7QcI3dogK58m RHXCWt6p8TKxQD+mrkjcoDJpwAQ1/ZuuULv6wFeO4WbA1R2kZ/acFd+hsVMXNugJV/ah2y fWCnke5KpcNtox68qy5xhoqd3c/wvIk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="X6pGH1/t"; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729542819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TCoATayQL6ScqW1XAVqLhkU9X3nCi6KYSYnaGXGM4LI=; b=Eb7JwqO4jes2s9v4l0xHIKUy7DPun5iWT+cpJSEYpa3lzXMA1aBq2Nh8Dxz6UKyLxcJkVP IVAd7ex1h5n25Ff5WXs15I6FLbSdV+DPiEj++C8bwtGOeDCzldMVTVoLxMf52bFkUvmEPV OesTc6BYJYU0OOsIA3AmSpmZByrJlNo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TCoATayQL6ScqW1XAVqLhkU9X3nCi6KYSYnaGXGM4LI=; b=X6pGH1/t3oiG4Ha7YTPU9ThRaR ygQodXSJRJFYQqvjHoIsRj25x+RiRRkkCh98SMXGninHw2E5QGRrfP73EW0Eg1Xi6WrSaBYzqejTV CvAkBc4fAV0YQyh/teyiR7+Zt4zvnDRjYIo0GrVNjmNZhth6kIFFr3YPyDQRMOpo4ueREjbweg1Kb q7yt0D0xdCcx70ahdamezMTzOHsACXDa2BdvL1Na/3yL1zjIatEvepnLUmove7pSiTYQpiSy5yiGU 4DWQqBi7TRQGDgEZz5xcdhB2ryFpyddI2DBE7MEQjkrl2yWGpPSnGL1ZwMyaORUQ7ax+tssGchAMS WgBEJSwg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t2z6f-0000000Gjj7-0W2g; Mon, 21 Oct 2024 20:34:25 +0000 Date: Mon, 21 Oct 2024 21:34:24 +0100 From: Matthew Wilcox To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241021173455.2691973-1-roman.gushchin@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: ED2F7100020 X-Rspamd-Server: rspam01 X-Stat-Signature: q1548goprdbw1tpdfmq55rjifp1oh3tq X-HE-Tag: 1729542839-60857 X-HE-Meta: U2FsdGVkX19P0V8rjE5zaCxGp9ZEBa6bY+DFcUzMk14dVZiEdY7+vlaCqTKnpDJHC4HCJ2C0BJ/StB9Y8Shs3zSxHko2d6osAVsBp6PwPlKDGukUl2AspUP4rGCRiVI2hKwOEmgyDhEmzu3sDZtBD6JpGkvuivo2hD9mAIdmIeoJriSUT4hFdNBtTgRC4BppREOLOJmhwJMoNLa0Mc0fhg/a28sdbTB3fCMhd9O6MSh0lT5jWdT+vhYZ3PTk6V8ZTmBOK3XS+s2782p1M9cCTk6/k63nxW4323cCm4eLo8bssEVLWSLE+hgNBzNLOPlyQ1GXPoT0HoU3oga1MjS3jZHAkQRTABbdWrv4PZvqmDTv7q4463aVja5I2pPCw9Kt2niKHDgl+wESUKa7BdH5gM69984pIlwN4Z7CFiIjwnO2VGs+IYv6qwVfZyXVIkH2zde4nyc9oJxMYeK8YVTbdWGw7SiGew3+hvGbo8UtMvD6wQnF7dGP6bvZZZw9u/aS5WTMCuDR506yZ5cV30kBdWKWz67wlNkTUCOW3a7LkQZuk1i77y/iwEN48t3/rfSfAwnMHOBjCYxxxjHaiHEmmQSUyEprOGN2CpG91B573zZxTSFjq7QBiSvb0sTzFuu/IPH6FI6R+gEnIBC7RfOxyM+mlr9cYIgnrQyoc44+FRw0L+/upXOHKRe/by541J9AkQVbmKTxgAK/A2bpeoPiDyuW+ofvqCfcDHES5fslbXTac26LS7Dhv5PsJ+OVo2U3d+m05MDfbVe81mwNqUNr9bECuTn3/1bgeEMSBOqcMn/f+I4baNTwx0504TKALzapmePy57RP8m25B6gt3KMoMVz4U6GSr2DZs7WNtWEnFocaZiQdvRvpWBNC1yICYhzM/rt7hJIabXqAIacOTzFofHcFDEV04xMz3fOPWL86rjUF3ztNF4we/lA0z+K8f8AQ42c0qUFz0x2cnkOwnBN qtaM4fTs 2XJDymZrUhkw9K8c2IdBym92ByFHNKtmOZVd2rt01u2Jlj5qt4FyGI6phrMPh30zSDzc9nkD9E/cZ3I/i6wk9fVhkjMbEobqlhklmxES8pTbBEt5EjjU1KueOx4Fakre9NiqOv39r7wQ7QHOl5X0X6Yo6axO8x8Y1yIIgiD9Vb/WPMo4Mef4UHahWZoSTAYvBb/4UsWPmHOdvpCwJVH0TKRUh+9VSasRdsZRSVKMDVx0A2XwcVVpS943PMoxcUhWg84dZ2X+YsFmNm2v1K5tTXCYetQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote: > Fix it by moving the mlocked flag clearance down to > free_page_prepare(). Urgh, I don't like this new reference to folio in free_pages_prepare(). It feels like a layering violation. I'll think about where else we could put this.