From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D60D15DA8 for ; Mon, 21 Oct 2024 14:46:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 628C56B0083; Mon, 21 Oct 2024 10:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B1A56B0088; Mon, 21 Oct 2024 10:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42C556B0089; Mon, 21 Oct 2024 10:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 213F66B0083 for ; Mon, 21 Oct 2024 10:46:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2E079405DF for ; Mon, 21 Oct 2024 14:46:32 +0000 (UTC) X-FDA: 82697885508.04.C3AFCAB Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by imf05.hostedemail.com (Postfix) with ESMTP id AFF9510001A for ; Mon, 21 Oct 2024 14:46:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=FFouLqIb; spf=pass (imf05.hostedemail.com: domain of gourry@gourry.net designates 209.85.161.52 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729521848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MsDignzYuKlqXw/v8Zg5uk4bZz/6JufrnHpxYgN6eVQ=; b=P+O46cfvvfhVVJnXKjWpzfPHyKRtwjOmyeUx71ePz9nSXLTcMIw8Yep3SkV0+GiRq+QSk+ sQ5xF9739fE258Q+gIHMJufxdgdNMyi5MhVCFF/cVPNt+2Ek23tT0Lc0mhAg4BQOpC0bgS ZP+Tb1aa94UGXd0fG0LNRBbH8KxsTw4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729521848; a=rsa-sha256; cv=none; b=KREprWdVJk9fMGoyqltDsjQD7GyRHuTV5YtDDbG8ysFoLbt89+vnb0tZNK6e9xD8GznnLE b2h63VnhVXzrLZX/GfVVGpMW6zHqNvdHA+a4PuwNhs7LdO5x86wUf3dPOWFMgQiNMtjaIq rLcAL3p3XSQzvVFQaB7i6+jvHMPkL6s= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=FFouLqIb; spf=pass (imf05.hostedemail.com: domain of gourry@gourry.net designates 209.85.161.52 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5eb60f6b4a7so1771561eaf.0 for ; Mon, 21 Oct 2024 07:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1729521998; x=1730126798; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MsDignzYuKlqXw/v8Zg5uk4bZz/6JufrnHpxYgN6eVQ=; b=FFouLqIbOP3Faci4uAMk8oOIDa7yE5HGExHwkDxOkVD7K/aMbyTzSuTBrpsKaH8cjv HZtSVxRLBJ00UclczOp8k2I2oYrH4bU5E0piZqp3gp0Ae0Qkv0daI+g1usWyM3ZRXkbj tiBmOOTBSWUBeraN7EINd/aDc6sBBNnE/c+A+FXVdDmEe2UT38aikNMyE7AL3Rsq1VXv mYxmz3Hf3wSzYAr94AP2n7/FVi+/oYMUjpKaRAxrq3QTNaUfIyVYmC8mkNEkpXE3k4b2 vzn+mImfBCvxa/vzgwgOAkZV/IDzUu7Q/tXjb5nTkeu9YNbr7w1cCT8Fmrr5SySdXFfT Zy4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729521998; x=1730126798; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MsDignzYuKlqXw/v8Zg5uk4bZz/6JufrnHpxYgN6eVQ=; b=BNP6auoD1tv9umbYzTLwHh0r4PfZQ+FkxdxgmYQcbRPtApc66Vt1Gdt/DwOaqMOhoU rRhsjQUvwXyeJk2Jptxe5Mgz+UEWvVmGVYO9611JNYHljUsj0HPQcDMD0LSpvfm/J/OZ fJpnxeNoR/+MFhZca3L7hTYKpxmItK1Df0hGy9QZjly0yBIznSpqSx8iENRTq2HHq6su pzMwqachGVDkWmQe+Tvjaylx2XX5GaiZ/deLnvEM3BYlmE95Ysf55wJHmhVK15j63m8K UzgI7NfzdOz97qU8C5cwzs+kjNkP5z61L6n87RxpsiGuULO0iWmgXgi2KR4647YDTjoN L/Zg== X-Forwarded-Encrypted: i=1; AJvYcCX+NLlCD9LlsAToGsBuC1TIF1l7HqULUKN+TBg+QSk7rtmZpuJLciMiNbq+FLEDNxYebM7iaio09w==@kvack.org X-Gm-Message-State: AOJu0YwlyQkBJInP85648XH22CWtlXbytpZ2ZcPdGgFtaGJX4qw+sDfe Jz2vct74x6alQ2oYG5GjtTNivb24Xtd1Nemqf0eBVoQCkVSxVf72RwpoBhEOGZ8= X-Google-Smtp-Source: AGHT+IH8bF+r1trizhxlQoSSNxbPm2L6fElkRzftR2yQOQVb1awE/KpRqJZ24oBCNJAQNVwu6op3pw== X-Received: by 2002:a05:6359:5e1b:b0:1b5:e9e2:cbe5 with SMTP id e5c5f4694b2df-1c39e025e0amr247022555d.20.1729521997686; Mon, 21 Oct 2024 07:46:37 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b165a61e6bsm172745285a.77.2024.10.21.07.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 07:46:37 -0700 (PDT) Date: Mon, 21 Oct 2024 10:46:38 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, ira.weiny@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, Jonathan.Cameron@huawei.com, rrichter@amd.com, ytcoode@gmail.com, haibo1.xu@intel.com, dave.jiang@intel.com Subject: Re: [PATCH v2 2/3] x86: probe memblock size advisement value during mm init Message-ID: References: <20241016192445.3118-1-gourry@gourry.net> <20241016192445.3118-3-gourry@gourry.net> <7b877356-f5c5-4996-904b-6c3b71389255@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b877356-f5c5-4996-904b-6c3b71389255@redhat.com> X-Stat-Signature: 47zaadfwpcmfdnyrt6y1zpug7jwnwuj5 X-Rspamd-Queue-Id: AFF9510001A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729521970-832122 X-HE-Meta: U2FsdGVkX1/7bjGVCEDN9lADhbRGOhcu4JsUB3obBpGSOxJdcoMN01TK0SDk4zmfJWjVfeJfa+wO9VioucyYcWK5SrWXyKAFvk2IaEhePyUsDD7ArYrtD9HxWRjA4v1DJebqYr94hMluzcaX9SM9DeYaVDEa5OqaCDjqad3f5g1hF0qhKfc0tl6Xb94TOpzYyCtV3YCemliMMMWbwGT3B0JenRINEswqpibDbkNcjuv2otOO9I+wLhGfiRdO4RJok/wN87FoJoCWUB0tTYaLPnUBPpcFHqffS0xgQ6NhMjUFGasE7ll/ppDbQEonQyWHDO1xlb+71V/pzY1VhWVksIUb9gc31NvxxkYKi+JxMJtNgNGW7zO4I8ntrXoCeHEcY/VaH0UUi/Tp+LMuk8GfzfLWLlZXavlb/pARRJROGdbCMzYxYTgcchFAa9KiF+wEeeJpvVLen5i7AfcUKAjgRe/mUIvczd4NcorS4hbWOW06sS45b3pDiR5P1mldEBp8KvU8HvUvnEBzTvYQ56T4Xp5CJjoSRZb9uLA3ZZsgAKoSPuGJPLCuUb6YO7BbEJ9CweZq+9tiMfvFGanpcIlkDK1xuqHZuKQQ2vtKq8jAvb6P2FRtccom2B/hUr7T3ARf3gfnuaOm0095QqcT8I1XtOMYVrAUEMT2a1dt3jhb0+SoVPxbLiJe4yFJXP49X/m6I7+8x4ZmNKp34wvGdIoqQ4fDtXj/EXC3eARC3T3ucqSwnCxHIFIGG8KiIkVOBbOQII50alCkB+rzqcn3909cHYEgAc7eCB1zRRZv6ADLH9NQ/+WKqEdpaj2u5npoGZgr6BDFtjhBscMzFIgIQiItl/xDlqdl6irqh9V7jDRU7bpIX8ODrECcGGRjvCBXfK6P+Llz7gNXLKL6IQJ6pdMiiuRgFV26KkNbezm9PjPbcQeDCRRXHSKoJfYtSLX2Pypx4ic51HYM+NxCclioC4A QDD5iBrp 9vYAX4VSR300F10DNZfpn/B2AUWqRfF9e3+JAQ3wQio1PjcpoXsZDonu552MJjD04FsKSWK+T45qUDPOS/O8oJiPKXvwij9PR32vDYeJfhqUHjP7HRfxUF0Izy2qZPipHlkAVZvRYckTg8AbCbUmdAWl2lcc6RyhbZqL4vbu54H/DumXrT12YH0Krw4VMsfLRObkyheMvlRaMcEvrGU7HpGOID7lG8lHtbOdwbVwxAVRywqWeoxsPchDiB4mZ6RDkFbTRLSOzh4eXUWFHDX3j48FQGLwBg/LySUkvRRIf+1gOVkvPRVznV58LAD7xy26riO6F9LZFagQKEAV+1L2RnWbHAYX3Jq1l+BG2St9CCqh0RBcrf0jbzdBRQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote: > > > Am 16.10.24 um 21:24 schrieb Gregory Price: > > Systems with hotplug may provide an advisement value on what the > > memblock size should be. Probe this value when the rest of the > > configuration values are considered. > > > > The new heuristic is as follows > > > > 1) set_memory_block_size_order value if already set (cmdline param) > > 2) minimum block size if memory is less than large block limit > > 3) [new] hotplug advise: lesser of advise value or memory alignment > > 4) Max block size if system is bare-metal > > 5) Largest size that aligns to end of memory. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Gregory Price > > --- > > arch/x86/mm/init_64.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index ff253648706f..b72923b12d99 100644 > > --- a/arch/x86/mm/init_64.c > > +++ b/arch/x86/mm/init_64.c > > @@ -1439,6 +1439,7 @@ static unsigned long probe_memory_block_size(void) > > { > > unsigned long boot_mem_end = max_pfn << PAGE_SHIFT; > > unsigned long bz; > > + int order; > > /* If memory block size has been set, then use it */ > > bz = set_memory_block_size; > > @@ -1451,6 +1452,21 @@ static unsigned long probe_memory_block_size(void) > > goto done; > > } > > + /* Consider hotplug advisement value (if set) */ > > + order = memblock_probe_size_order(); > > "size_order" is a very weird name. Just return a size? > > memory_block_advised_max_size() > > or sth like that? > There isn't technically an overall "max block size", nor any alignment requirements - so order was a nice way of enforcing 2-order alignment while also having the ability to get a -1/-EBUSY/whatever out. I can change it if it's a big sticking point - but that's my reasoning. > > + bz = order > 0 ? (1UL << order) : 0; > > + if (bz) { > > + /* Align down to max and up to min supported */ > > + bz = + /* Use lesser of advisement and end of memory alignment */ > > + for (; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { > > + if (IS_ALIGNED(boot_mem_end, bz)) > > + goto done; > > This looks like duplicate code wit the loop below. > > Could we refactored it into something like: > > advised_max_size = memory_block_advised_max_size(); > if (!advised_max_size) { > bz = MAX_BLOCK_SIZE; > if (!boot_cpu_has(X86_FEATURE_HYPERVISOR) > goto done, > } else { > bz = max(min(advised_max_size, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); > } > > for (; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { > if (IS_ALIGNED(boot_mem_end, bz)) > break; > > this is better, will update. > > -- > Cheers, > > David / dhildenb >