From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6F2D15DA0 for ; Mon, 21 Oct 2024 14:39:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254F26B0083; Mon, 21 Oct 2024 10:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 204B26B0088; Mon, 21 Oct 2024 10:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD0C6B0089; Mon, 21 Oct 2024 10:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E2E546B0083 for ; Mon, 21 Oct 2024 10:39:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9075120EBE for ; Mon, 21 Oct 2024 14:39:39 +0000 (UTC) X-FDA: 82697868120.06.1D0C117 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf17.hostedemail.com (Postfix) with ESMTP id 0A4684000E for ; Mon, 21 Oct 2024 14:39:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=VMzWaHgd; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.53 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729521541; a=rsa-sha256; cv=none; b=ie3avHuHSVSvfXUvMIIh8Dkp/H7R7R0z//GqR+ATlq/BxB7B8AvmcjG+Znm6Rx86AvHbPp B85MDrov49AQ4cc61gVYsJ8TfKuGvFoWfU1QpDdoEo5HHEi9GJGLgmORk//CUnFnqmjj+C GUYFvcVWLd/xRXTT31yJ1KI604vINNM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=VMzWaHgd; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.53 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729521541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QBwvaCcMFp61JVh2xwSwuOplQvwOE8lvZKAngP58VqI=; b=GedvyCcgS45C1zAmbBVlCJmhYazELNtx4PPI1Zf0glLTLSSgdWPAFzPvTAvpQs3eG8M0lO LXWvSPVoFArHrgS2aOYIikBEsJSChDjhtKKHoUSzRKKiKysZbW5Xw9wgx7WpPJpONj4CXR IxayXWkhyh5ewhszuJa8vEtlz5grT0I= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6cbd1ae26a6so28645886d6.1 for ; Mon, 21 Oct 2024 07:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1729521590; x=1730126390; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QBwvaCcMFp61JVh2xwSwuOplQvwOE8lvZKAngP58VqI=; b=VMzWaHgdcbCF1fc6nY3viHxNBZYhcebvk166fjyOPzOSLbPpMljldo/i6jR3WJoNDP y71uLiFxsXdNjBpvcHstTL8rRgkATREOH+VAeknEJf51/QexfYg2meBNKPfnGSC0yqH5 Kp+moaG1WvkaoNkARU8jtQI+ngNz5WjW2i1l8uXeyCVM9/fx1gNd1hGslSgAVeYbWsiB 7H6g5SxDYR2HQntSb4LPd5xTMMg/ibB5npXOA8Kya3/2fOwpjUEp9vDDyir+4AhkxrBx tLq5W/n3gD8nrkvLueHS4AgGWefvqTp8YfUNyASmhiEhAmU7jwHR7sn+TOwtRiaq4DD/ zSdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729521590; x=1730126390; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QBwvaCcMFp61JVh2xwSwuOplQvwOE8lvZKAngP58VqI=; b=QBw3kxOmNsF3ZcUCfklUd/mGHYG6W68Q8jZDPAab5lD41ym0QYkJTimBOrenLVFYP2 nGrCIfKRX68cowAkJr2lR64SlfotOcPcfjGCDKT7vm82XHz4zuVWL2bS8dawK7TCu/Xw I2ydUVlYw/4vzq50Od3h69IbXoT9cn4YADZ92lv3cK2XcWC/7GVE5Ko92SajdwW4guoM bVN9fUIqIl2XXkkSPEOWA/Y+rpaXSn3qIiOBm8Me9neTPhxRl716QFkhx83zx8US+VYO FNcvpnj23PU5tH/wiTanpJRq2xCsaDYdJBL/CNdEcB4HnseVprbfbGoMBEu9gbPS7FxR lhNg== X-Forwarded-Encrypted: i=1; AJvYcCW+1qWCW8Ju+GRb1iMHXwoBH+4rgle1v1BxdA1ASTisJY6+UeBhjyPUP8cq9KjdMXhvsv4aSY1vcg==@kvack.org X-Gm-Message-State: AOJu0YxzjcV++pOdTsdFY2WgD9dwd2emYOz4B7qqr9xqtAE6xWgqemdT riLZvE9d3/XkxMFGjj6AhS4aHFHQh28vDifTnwkGbiOkHDqGj3q4SVd5DJOK4lo= X-Google-Smtp-Source: AGHT+IGwsR9nAFy5MvyVbGW/I5DDauVanyhn/ZsHEw5JDwji7gr1JZ+g7udLuUSB5y7QkaH+lDD7BQ== X-Received: by 2002:a0c:c690:0:b0:6cd:fa19:2b64 with SMTP id 6a1803df08f44-6cdfa192c79mr99765406d6.39.1729521590563; Mon, 21 Oct 2024 07:39:50 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ce0091ad82sm17423896d6.63.2024.10.21.07.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 07:39:50 -0700 (PDT) Date: Mon, 21 Oct 2024 10:39:51 -0400 From: Gregory Price To: Mike Rapoport Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, ira.weiny@intel.com, david@redhat.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, Jonathan.Cameron@huawei.com, rrichter@amd.com, ytcoode@gmail.com, haibo1.xu@intel.com, dave.jiang@intel.com Subject: Re: [PATCH v2 1/3] mm/memblock: implement memblock_advise_size_order and probe functions Message-ID: References: <20241016192445.3118-1-gourry@gourry.net> <20241016192445.3118-2-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 0A4684000E X-Rspamd-Server: rspam01 X-Stat-Signature: exica3x4op61m78kcokchgrzdp8zt3wt X-HE-Tag: 1729521579-453753 X-HE-Meta: U2FsdGVkX18ja6DAkk3Ywz+zz0HD6Z3ow3Pwf6wg2WnlSklcS5d0n7gvPCchF8tXB97uLLmdSdiZfqZz1Nqg9yy3PWgCHDnWTotVGGX6t4SjkCrk2cFTZZd4W9YqaFp+1R8lk+ZoJOr8aGizXrAY9rRa8x9118w2aBPwkhk0hPBSm6OgoMvbh1MowkjYA2zD83UpL+nhm2gSmt2/uqGZOZaIRhYD4VKcQJm36Ut6NxzD9V5l0V5jLPdJQi84fBEtYoNOg/atrT/X7jicdtXEaWde46oTOfBDIK6J1LI8pwTcr9K4Wxo73M+iu8YhL1VC82YqHRB7vYSUtF1quNQMbVzR3P2roTcYOgaJ8GhqkvAVRhU1y3B/Sij8GbDE3wNZxxrj/rX1kd2HtkBdpQbErrWsy8AkSRgRQxRyIWyEBhyFbMDzbr3wMlrl3lHSzdX4dT4yQoZEF3/beH/27WIvzlBcrVe4a3jxCzeRmG5vvubU6P8p8mfRtonMEOv6RxcRJ2Y6t6opB46VOJ0PqRTDpNLeLrifvVnISPWWgO8e8ac44o+B9ibF7mIY6l6xl0YLK1eCr8428J/zW4dzyfrrYS+nlh+OAbku14q4dlEi5o5zNG5dHi2SULQoV0k5k4qg8Ziq5qAtOLhJdlSCr4WehuPaR5cCgQAVkZh1GbPUFymNhjIqdekoUF9fJ390AGa8QZshAoF2uV5SRqjygA2jJx/byWTXpUQLP5MYjOOj7m9rISGtjkJDro9BN7fTQs3QDHBzQMKMx6Tyq0RZhlKBLU3n6aeV0FCuXRs+ddXlJekcN0oUYllWEAv9h/iElBW1VbEI5PrIqlDwz8rNrUFWlmhFnok5BUtQdsxpzttBYM7ANxV7RdN3JpTta55yBoJRCJsZP8l0IlVwRExFiD0S8L0jBDEgVk5NhunOvkrSAwO1b9IfLuHMN+j9lumVk5xBqmVPl1aNS15BWIACGP4 SC0tU/4V ji89o1MiOpPbfvNkygVJ+6fi9FTiFfKMgUZLDuBMhZKBZk0Fof1x4CQpMs9aZaH0vf92MZpkFllYZLFz0zmYjdTukkD5Y0jxWXxNA4VT12U2a1ucZQ8MliLu99R4/1h3cFH8eVp5QbX6v6cLp+Fb6k9i2g8DoA0HXYAvgJx1s9K3uHIRzMAD1WW6FERyZNYEfB7OqV8a0Jat5m8YaUlmXkUl334uXRM2+LkHQc1OqUyqxhswL2pyxYwvx0Ef8/hS+pIakyIfHMTrmAMaAPvuR5/iYS0D7JPgM5AvvqYRCXNpsNv1Qax1XdYq+R3lnVZ9DIhf+6dnEgNEsB0JLWSDt3SYJDMeU9f90foYx5TO0JLw8qUvCLS5CEh0VW9xZhQRQUJ2ZqJ7RAjhm4j9qvNbvhtRE6zyvZlLVXOSTRWWUU/KpCRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 20, 2024 at 11:57:27AM +0300, Mike Rapoport wrote: > On Wed, Oct 16, 2024 at 03:24:43PM -0400, Gregory Price wrote: > > Hotplug memory sources may have opinions on what the memblock size > > should be - usually for alignment purposes. For example, CXL memory > > extents can be as small as 256MB with a matching physical alignment. > > > > Implement memblock_advise_size_order for use during early init, prior > > to allocator and smp init, for software to advise the system as to what > > the preferred block size should be. > > > > The probe function is meant for arch_init code to fetch this value > > once during memblock size calculation. Use of the advisement value > > is arch-specific, and no guarantee is made that it will be used. > > I'm confused. > > Aren't we talking about memory blocks for hotplugable memory here? > This functionality rather belongs to drivers/base/memory.c, doesn't it? > You're right, I should have put it there - i got distracted by the ifdef mess around get_block_size_bytes/set...order and just tossed it into memblock to avoid it. I should be able to ifdef the definition in the header and move it into memory.c > > Calls to either function after probe results in -EBUSY to signal that > > advisement is ignored or that memblock_get_size_bytes should be used. > > > > Suggested-by: Ira Weiny > > Signed-off-by: Gregory Price > > --- > > include/linux/memblock.h | 2 ++ > > mm/memblock.c | 49 ++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 51 insertions(+) > >