From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BF0D15DB9 for ; Mon, 21 Oct 2024 16:23:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2EF56B0085; Mon, 21 Oct 2024 12:23:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADF766B0088; Mon, 21 Oct 2024 12:23:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97F386B0089; Mon, 21 Oct 2024 12:23:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7BE206B0085 for ; Mon, 21 Oct 2024 12:23:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8A9831A0390 for ; Mon, 21 Oct 2024 16:22:56 +0000 (UTC) X-FDA: 82698129150.15.1F6F190 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf09.hostedemail.com (Postfix) with ESMTP id 7414C14000B for ; Mon, 21 Oct 2024 16:23:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PWkYM3Yf; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729527652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lr/AUAtx/FQMtUh6AmIuvX+izsQVav8JTwTXqT9niQc=; b=qJadHepnF0yT5g0kP1eA/B1RkGXnAff7bZPDJN3252o1nVZSOaB/2DmChymw1vcusLYuIi h+gKZbG+yCAOxdEpwWuCRYueg+IqoqDK+8mC+2bud/+uwSXQv0S6uoFl1eyn9ETk+zuR9D WSOJlTRvSu4a7+Fj8ayeXVqtONtAb88= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729527652; a=rsa-sha256; cv=none; b=KoV8lNlRhn9RNf/ItijBUg/E6vkeqOmuG0Z4Bb0Wckm08XOFw2wM3JdjmjHhOOaj9gCuMT 5AZ3YHw1oyaxkEuSCzCpEH1Opn+6E3hmCFvCwVTdEzf4Wd0hdpPk2nJf2jBt4lJA7C3JCS 2AhL2SZx8XN3+GS8kcfeUC6YvdNUe4E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PWkYM3Yf; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a9a1b71d7ffso747584166b.1 for ; Mon, 21 Oct 2024 09:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729527800; x=1730132600; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Lr/AUAtx/FQMtUh6AmIuvX+izsQVav8JTwTXqT9niQc=; b=PWkYM3YfzpIlJpBOvN3tWjyZN7m5LeJR+UptAk0lCL4X+t2V80545ixfv2OUiUpzsh 5Klon8XywtJtj/hYX87SBBa8FKCeInJYmCPXED7fcNq/Y/PlOEFtiO0RckZwjPTLnLZK LDq+OoLBGNGgMBulJOtf/9dP0g+E/O4KLcZKRC1rKTLNcsNfh9PHwbypq7SFrgN4UT3T HlGh1cU6H76mUI67/Rzl/4RyLR1QU4EoX5OXiLPaaAQ9NaHhqn7DNzpO5FrSZdNAE9xb TNdLQwoiqHipvCejRK8ssgLle3n/P/P+MgdqPZuM5fYoIih4YtOLDnNqbMVASrxfj+eb 7awA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729527800; x=1730132600; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lr/AUAtx/FQMtUh6AmIuvX+izsQVav8JTwTXqT9niQc=; b=KO1TYJd9Zf/MnCB77Pwxs6lOycFGIFDDffpBc1cytUpRaDZIm5fB2900rGTe9ryeL0 NXsU6A0GScmR9idprqJPfbG5UE9lh5rmAyV2Cv1x82WICJd61rlnKnqvxHYZyYymxXpA 4i04mDy9MXTRAnsh12lX7ggxuED07DWwND+hcWAPN+jbRN3ZFvAe6e2BiBxWdevdBGxY 2vu6djiYc9XRWy9k8z/oN5d02p3m/zSUE1MyYwrCDHiTiRQcdvvZVD5aRV5RnEEs8HoE M5ddGaK6dTLFtVG5kzUiU2FMliXn0O4zT6vgivU+Ew+cmCxbgmTE6vGk/x2fiKJk/CO4 DMWQ== X-Forwarded-Encrypted: i=1; AJvYcCUCt2bnUx0iOXH8/yMCShoFreSVidkwUEAFWCKpyWT2u3oeWp4/6gDDTAf/kLV7zDKEO+aiofc8/g==@kvack.org X-Gm-Message-State: AOJu0Yzbf7ptOOhwbQaGvW0Tz2+5hYxd+GVrAHprWNrBmCBR7FcU6jOg FXOt99mZrX3oa7HL7Qz9xC/OOTmk0SUVi06WkyiGnHqf6EeCVMUMN/kWBx+A2sU= X-Google-Smtp-Source: AGHT+IGr0R5dZljnxHV96zyk0UIMCnazXHXjSfRrcJo+cGBtb2Xy0gcW6CKVZ25Le/NX8RyC9vegyw== X-Received: by 2002:a17:907:a4a:b0:a9a:5a14:b8d8 with SMTP id a640c23a62f3a-a9aa8a05ebcmr63573166b.43.1729527800271; Mon, 21 Oct 2024 09:23:20 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91306fc0sm220180266b.91.2024.10.21.09.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 09:23:19 -0700 (PDT) Date: Mon, 21 Oct 2024 18:23:19 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: David Hildenbrand , John Hubbard , Yosry Ahmed , akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags Message-ID: References: <62a7eb3f-fb27-43f4-8365-0fa0456c2f01@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7414C14000B X-Stat-Signature: 9xrhdzrrdrkuqu7twksbfxhge4bf19qa X-HE-Tag: 1729527791-231088 X-HE-Meta: U2FsdGVkX19630fKf/onKEwB7nB9WmohTNA6EuAU3DtASKduMsXPcLgbtD+LgU8SRbmkLkoCV0LhgyWzTPm3vlMrPCkNBdVeFkCyTjPp0u8jAEYDh90gtPZitErtfLso236Su654DN13nVMNMNS2F5EFFcM3aM/1Wbzmnglm5RlU1Vj+boB2UZKjEfR/mbd/3nJuI7AO0Idmu/gqFdWEs4V0CxDH7j3gRY3IWR7OhePQi4B/AbSa1ScQjSbl63xbZ1zzBkc2uSr7eJ5wEwXdeLWXK+pCED9AZK1AEYcrQcuRznUebHObeXShdKXLVWbNFTNGb1O7HKmXt6gSW6JLtFxZ8MKMYP8/hGgLMZxOXPx39fZ5rgpS2FabF6AmUMbFChuwZKyfjAkypP0HOx5JYBSWenmMfGADCDdwiDUEr9bKv///t4dFXuloNYCCfyXnj/WshzDFGDEB49fy7tyZcfY5BYI9pp2So1d41ngcFmYR9Kp99ECWbp8uIJsYlVyJLd5LKr/VOma+6zm2m6zBnjEONlEcuGm8NV/0f0Tboq6l/3LyPW2YOhrRh7r8YErCRQQmdlkixsV5p/q5kBC2lhmblVtK79pWiuR2CBBpA/V0z46rnAUvfmA8pwH8TiO+22t5qjEUOIIUSimGd/yReZYfZBArG44H7OabhUPSHAuLdtdMbtvfTHx3/BXBjV4FLmGeII04sGVWuL5wdfvOfdALplueOqf+2MG/m3CX2FhYODFO3uqrTAdSoWKj8Z8KzzbtUIhnrzsZ4VgyFw1wYWqgl87ol2/FTMEtIt/3DWT5Mp1wHhYJ7nwvNr7nIdn2nk2y8zUukcMjQ5XuXEQvepqw3tk4rTMg6PIF8Lc3FRPm2Ml3uIxOdQNENHBuDZEqKWCf7D2tXiTcp5C4lAUCg21yfv9+f8zEzEy3BNs3oTUP0xKm63+kbtNu2ia6PIJJkV3RcBBlJ6/UVrIHktf yEiuYfas m5VsGqFsN0snV0no6LXY/lPnmghv1/9ldzCG7uIz9JPXf6Ik0EyflBX6ZYf4/AP+gzX74hqu2lnOCYNGccvureELjzNSB44JaXIiMDT/y8iCiy7iAbuKGJ+Smn1epLMui4Ds4iZDuohN0Gw2MAgP2fICxzP4a1m8wQKPWtGIhRfdoqix9lwLg57NqEG4mJ61CZUjthigIszslcYFRFum1plEW2f8D+3ZKci8dtEnEMjEddfpqXuCLWy+P0m8koZoHDQjPZ63yeq5qtOb15X99ykc2V3HR6JTmHC1gb8gahPgw1HpAvcbXH0WoPyJBxVZUkDOCkzHftIjZ5OXoPmC0rgnCWlKhaEZO/C8HpDMhqCVA7vbEKdiVZKFdXFXX3uHOj3688tcZES7iQKSghN/H04qimhvw8oVmKxeCL9/XBFx/VPzepCDXbaw8n8pN5dLrwBgD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 21-10-24 09:16:14, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > > > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > > > [...] > > > > > Yeah, I thought about adding new values to "mem_profiling" but it's a > > > > > bit complicated. Today it's a tristate: > > > > > > > > > > mem_profiling=0|1|never > > > > > > > > > > 0/1 means we disable/enable memory profiling by default but the user > > > > > can enable it at runtime using a sysctl. This means that we enable > > > > > page_ext at boot even when it's set to 0. > > > > > "never" means we do not enable page_ext, memory profiling is disabled > > > > > and sysctl to enable it will not be exposed. Used when a distribution > > > > > has CONFIG_MEM_ALLOC_PROFILING=y but the user does not use it and does > > > > > not want to waste memory on enabling page_ext. > > > > > > > > > > I can add another option like "pgflags" but then it also needs to > > > > > specify whether we should enable or disable profiling by default > > > > > (similar to 0|1 for page_ext mode). IOW we will need to encode also > > > > > the default state we want. Something like this: > > > > > > > > > > mem_profiling=0|1|never|pgflags_on|pgflags_off > > > > > > > > > > Would this be acceptable? > > > > > > > > Isn't this overcomplicating it? Why cannot you simply go with > > > > mem_profiling={0|never|1}[,$YOUR_OPTIONS] > > > > > > > > While $YOUR_OPTIONS could be compress,fallback,ponies and it would apply > > > > or just be ignored if that is not applicable. > > > > > > Oh, you mean having 2 parts in the parameter with supported options being: > > > > > > mem_profiling=never > > > mem_profiling=0 > > > mem_profiling=1 > > > mem_profiling=0,pgflags > > > mem_profiling=1,pgflags > > > > > > Did I understand correctly? If so then yes, this should work. > > > > yes. I would just not call it pgflags because that just doesn't really > > tell what the option is to anybody but kernel developers. You could also > > have an option to override the default (disable profiling) failure strategy. > > Ok, how about "compressed" instead? Like this: > > mem_profiling=0,compressed Sounds good to me. And just to repeat, I do not really care about specific name but let's just stay away from something as specific as page flags because that is really not helping to understand the purpose but rather the underlying mechanism which is not telling much to most users outside of kernel developers. -- Michal Hocko SUSE Labs